github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-03-17 18:43:11 -05:00
Code Issues 144 Packages Projects Releases 116 Wiki Activity

[PR #1692] [MERGED] Improve Delete Account UI #3058

New Issue
Closed
opened 2025-11-26 23:27:46 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-26 23:27:46 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/1692
Author: @fedemkr
Created: 12/16/2021
Status: ✅ Merged
Merged: 12/20/2021
Merged by: @fedemkr

Base: master ← Head: delete-account-red-changes

📝 Commits (2)

  • 8dd59af Updated Delete account view UI
  • b08e1e9 Merge branch 'master' into delete-account-red-changes

📊 Changes

12 files changed (+139 additions, -18 deletions)

View changed files

📝 src/Android/Resources/drawable/ic_warning.xml (+1 -1)
📝 src/App/Pages/Accounts/DeleteAccountPage.xaml (+38 -13)
📝 src/App/Styles/Android.xaml (+42 -1)
📝 src/App/Styles/Black.xaml (+2 -0)
📝 src/App/Styles/Dark.xaml (+2 -0)
📝 src/App/Styles/Light.xaml (+2 -0)
📝 src/App/Styles/Nord.xaml (+2 -0)
📝 src/App/Styles/iOS.xaml (+48 -1)
📝 src/iOS/Resources/Assets.xcassets/ic_warning.imageset/Contents.json (+1 -1)
➕ src/iOS/Resources/Assets.xcassets/ic_warning.imageset/ic_warning-1.pdf (+0 -0)
➖ src/iOS/Resources/Assets.xcassets/ic_warning.imageset/ic_warning.pdf (+0 -0)
📝 src/iOS/iOS.csproj (+1 -1)

📄 Description

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

Update the Delete Account view UI/UX (colors, font sizes, layout)

Code changes

  • Styles Added more styles for danger things, titles
  • DeleteAccountPage.xaml: Applied updated UI

Screenshots

image

Testing requirements

All the functionality should be the same as before, this was purely UI. Check #1621

Before you submit

  • I have added unit tests where it makes sense to do so (encouraged but not required)
  • This change requires a documentation update (notify the documentation team)
  • This change has particular deployment requirements (notify the DevOps team)

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/1692 **Author:** [@fedemkr](https://github.com/fedemkr) **Created:** 12/16/2021 **Status:** ✅ Merged **Merged:** 12/20/2021 **Merged by:** [@fedemkr](https://github.com/fedemkr) **Base:** `master` ← **Head:** `delete-account-red-changes` --- ### 📝 Commits (2) - [`8dd59af`](https://github.com/bitwarden/android/commit/8dd59af18d7e72390ce71c9cf99a4b0eb6ae937a) Updated Delete account view UI - [`b08e1e9`](https://github.com/bitwarden/android/commit/b08e1e9e643bab4a95c340455a9fb43536f2eac9) Merge branch 'master' into delete-account-red-changes ### 📊 Changes **12 files changed** (+139 additions, -18 deletions) <details> <summary>View changed files</summary> 📝 `src/Android/Resources/drawable/ic_warning.xml` (+1 -1) 📝 `src/App/Pages/Accounts/DeleteAccountPage.xaml` (+38 -13) 📝 `src/App/Styles/Android.xaml` (+42 -1) 📝 `src/App/Styles/Black.xaml` (+2 -0) 📝 `src/App/Styles/Dark.xaml` (+2 -0) 📝 `src/App/Styles/Light.xaml` (+2 -0) 📝 `src/App/Styles/Nord.xaml` (+2 -0) 📝 `src/App/Styles/iOS.xaml` (+48 -1) 📝 `src/iOS/Resources/Assets.xcassets/ic_warning.imageset/Contents.json` (+1 -1) ➕ `src/iOS/Resources/Assets.xcassets/ic_warning.imageset/ic_warning-1.pdf` (+0 -0) ➖ `src/iOS/Resources/Assets.xcassets/ic_warning.imageset/ic_warning.pdf` (+0 -0) 📝 `src/iOS/iOS.csproj` (+1 -1) </details> ### 📄 Description ## Type of change - [ ] Bug fix - [ ] New feature development - [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc) - [ ] Build/deploy pipeline (DevOps) - [X] Other ## Objective <!--Describe what the purpose of this PR is. For example: what bug you're fixing or what new feature you're adding--> Update the Delete Account view UI/UX (colors, font sizes, layout) ## Code changes <!--Explain the changes you've made to each file or major component. This should help the reviewer understand your changes--> <!--Also refer to any related changes or PRs in other repositories--> * **Styles** Added more styles for _danger_ things, titles * **DeleteAccountPage.xaml:** Applied updated UI ## Screenshots ![image](https://user-images.githubusercontent.com/15682323/146451623-bdb8c5f2-6250-4e93-8c88-2526d0ce3cea.png) ## Testing requirements <!--What functionality requires testing by QA? This includes testing new behavior and regression testing--> All the functionality should be the same as before, this was purely UI. Check #1621 ## Before you submit - [ ] I have added **unit tests** where it makes sense to do so (encouraged but not required) - [ ] This change requires a **documentation update** (notify the documentation team) - [ ] This change has particular **deployment requirements** (notify the DevOps team) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-26 23:27:46 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#3058
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?