github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-03-09 11:44:41 -05:00
Code Issues 144 Packages Projects Releases 116 Wiki Activity

[PR #5590] [MERGED] [PM-24112] Remove Password Manager strings and translations #5895

New Issue
Closed
opened 2025-11-27 00:16:30 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-27 00:16:30 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/5590
Author: @SaintPatrck
Created: 7/25/2025
Status: ✅ Merged
Merged: 7/30/2025
Merged by: @SaintPatrck

Base: main ← Head: PM-24112/delete-password-manager-translations

📝 Commits (1)

  • 559fc19 [PM-24112] Remove Password Manager strings and translations

📊 Changes

64 files changed (+3 additions, -62038 deletions)

View changed files

➖ app/src/main/res/values-af-rZA/strings.xml (+0 -1000)
➖ app/src/main/res/values-ar-rSA/strings.xml (+0 -1000)
➖ app/src/main/res/values-az-rAZ/strings.xml (+0 -1001)
➖ app/src/main/res/values-be-rBY/strings.xml (+0 -999)
➖ app/src/main/res/values-bg-rBG/strings.xml (+0 -1002)
➖ app/src/main/res/values-bn-rBD/strings.xml (+0 -1000)
➖ app/src/main/res/values-bs-rBA/strings.xml (+0 -999)
➖ app/src/main/res/values-ca-rES/strings.xml (+0 -1000)
➖ app/src/main/res/values-cs-rCZ/strings.xml (+0 -1001)
➖ app/src/main/res/values-cy-rGB/strings.xml (+0 -1000)
➖ app/src/main/res/values-da-rDK/strings.xml (+0 -1000)
➖ app/src/main/res/values-de-rDE/strings.xml (+0 -999)
➖ app/src/main/res/values-el-rGR/strings.xml (+0 -1000)
➖ app/src/main/res/values-en-rGB/strings.xml (+0 -1002)
➖ app/src/main/res/values-en-rIN/strings.xml (+0 -1002)
➖ app/src/main/res/values-es-rES/strings.xml (+0 -0)
➖ app/src/main/res/values-et-rEE/strings.xml (+0 -0)
➖ app/src/main/res/values-eu-rES/strings.xml (+0 -0)
➖ app/src/main/res/values-fa-rIR/strings.xml (+0 -0)
➖ app/src/main/res/values-fi-rFI/strings.xml (+0 -0)

...and 44 more files

📄 Description

🎟️ Tracking

PM-24112

📔 Objective

This commit removes all strings and translations from app module that have been migrated to the ui module.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/5590 **Author:** [@SaintPatrck](https://github.com/SaintPatrck) **Created:** 7/25/2025 **Status:** ✅ Merged **Merged:** 7/30/2025 **Merged by:** [@SaintPatrck](https://github.com/SaintPatrck) **Base:** `main` ← **Head:** `PM-24112/delete-password-manager-translations` --- ### 📝 Commits (1) - [`559fc19`](https://github.com/bitwarden/android/commit/559fc19702325f67e2a06314e01df0642c56052d) [PM-24112] Remove Password Manager strings and translations ### 📊 Changes **64 files changed** (+3 additions, -62038 deletions) <details> <summary>View changed files</summary> ➖ `app/src/main/res/values-af-rZA/strings.xml` (+0 -1000) ➖ `app/src/main/res/values-ar-rSA/strings.xml` (+0 -1000) ➖ `app/src/main/res/values-az-rAZ/strings.xml` (+0 -1001) ➖ `app/src/main/res/values-be-rBY/strings.xml` (+0 -999) ➖ `app/src/main/res/values-bg-rBG/strings.xml` (+0 -1002) ➖ `app/src/main/res/values-bn-rBD/strings.xml` (+0 -1000) ➖ `app/src/main/res/values-bs-rBA/strings.xml` (+0 -999) ➖ `app/src/main/res/values-ca-rES/strings.xml` (+0 -1000) ➖ `app/src/main/res/values-cs-rCZ/strings.xml` (+0 -1001) ➖ `app/src/main/res/values-cy-rGB/strings.xml` (+0 -1000) ➖ `app/src/main/res/values-da-rDK/strings.xml` (+0 -1000) ➖ `app/src/main/res/values-de-rDE/strings.xml` (+0 -999) ➖ `app/src/main/res/values-el-rGR/strings.xml` (+0 -1000) ➖ `app/src/main/res/values-en-rGB/strings.xml` (+0 -1002) ➖ `app/src/main/res/values-en-rIN/strings.xml` (+0 -1002) ➖ `app/src/main/res/values-es-rES/strings.xml` (+0 -0) ➖ `app/src/main/res/values-et-rEE/strings.xml` (+0 -0) ➖ `app/src/main/res/values-eu-rES/strings.xml` (+0 -0) ➖ `app/src/main/res/values-fa-rIR/strings.xml` (+0 -0) ➖ `app/src/main/res/values-fi-rFI/strings.xml` (+0 -0) _...and 44 more files_ </details> ### 📄 Description ## 🎟️ Tracking PM-24112 ## 📔 Objective This commit removes all strings and translations from `app` module that have been migrated to the `ui` module. ## ⏰ Reminders before review - Contributor guidelines followed - All formatters and local linters executed and passed - Written new unit and / or integration tests where applicable - Protected functional changes with optionality (feature flags) - Used internationalization (i18n) for all UI strings - CI builds passed - Communicated to DevOps any deployment requirements - Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team ## 🦮 Reviewer guidelines <!-- Suggested interactions but feel free to use (or not) as you desire! --> - 👍 (`:+1:`) or similar for great changes - 📝 (`:memo:`) or ℹ️ (`:information_source:`) for notes or general info - ❓ (`:question:`) for questions - 🤔 (`:thinking:`) or 💭 (`:thought_balloon:`) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion - 🎨 (`:art:`) for suggestions / improvements - ❌ (`:x:`) or ⚠️ (`:warning:`) for more significant problems or concerns needing attention - 🌱 (`:seedling:`) or ♻️ (`:recycle:`) for future improvements or indications of technical debt - ⛏ (`:pick:`) for minor or nitpick changes --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-27 00:16:30 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#5895
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?