github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-05-06 07:48:22 -05:00
Code Issues 1.1k Packages Projects Releases 122 Wiki Activity

[PR #5895] [MERGED] [BRE-1194] temporarily enable hourly checks for github release #36633

New Issue
Closed
opened 2026-04-21 03:47:45 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-21 03:47:45 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/5895
Author: @AmyLGalles
Created: 9/16/2025
Status: ✅ Merged
Merged: 10/14/2025
Merged by: @AmyLGalles

Base: main ← Head: agalles/BRE-1118

📝 Commits (10+)

  • 0864b2d temporarily enable hourly checks for github release
  • f5833ee update actions with dry run options and actions permission
  • 898ea3c add dry run to run name
  • 70a266e test enable disable again
  • e188a8e test enable disable again
  • 8006189 test enable disable again
  • d5e9463 remove test options
  • c13973c add specific branch for testing
  • 12ea84c add write permissions
  • 836b3cc remove test settings

📊 Changes

3 files changed (+47 additions, -16 deletions)

View changed files

📝 .github/workflows/publish-github-release-bwa.yml (+2 -15)
➕ .github/workflows/publish-github-release-bwpm.yml (+24 -0)
📝 .github/workflows/publish-store.yml (+21 -1)

📄 Description

This updated was tested during the 10/2/25 clients release

Added dry-run option to publish-store.yml

publish-store.yml will enable github release workflows once release to the ios app store is complete.

publish-github-release.yml is now publish-github-release-bwa.yml and publish-github-release-bwa.yml so that they can be enabled or disabled based on which project was released. They now run hourly when enabled.

The workflow gh-actions/_publish-mobile-github-release.yml disables the workflow that ran it once it completes successfully.

🎟️ Tracking

Original Ticket
Follow up for testing

📔 Objective

Right now the check runs at 3am M-F, so if it fails on a Friday it doesn’t run again until Monday, which causes CI jobs to fail. This happens since they use the existing GH release to determine the version and cannot upload using the same version that’s currently rolling out.

📸 Screenshots

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/5895 **Author:** [@AmyLGalles](https://github.com/AmyLGalles) **Created:** 9/16/2025 **Status:** ✅ Merged **Merged:** 10/14/2025 **Merged by:** [@AmyLGalles](https://github.com/AmyLGalles) **Base:** `main` ← **Head:** `agalles/BRE-1118` --- ### 📝 Commits (10+) - [`0864b2d`](https://github.com/bitwarden/android/commit/0864b2deeb78391adef826d054ee674c4e10d144) temporarily enable hourly checks for github release - [`f5833ee`](https://github.com/bitwarden/android/commit/f5833eec71ddcf7cd9de80d7921da675bbe5720c) update actions with dry run options and actions permission - [`898ea3c`](https://github.com/bitwarden/android/commit/898ea3c050fb94660e6572e8872820f6d70fb8f8) add dry run to run name - [`70a266e`](https://github.com/bitwarden/android/commit/70a266e6c7a951631635d11a9718acc22520d17f) test enable disable again - [`e188a8e`](https://github.com/bitwarden/android/commit/e188a8eef83e2f57b866d49c6b2dd6b9f4525826) test enable disable again - [`8006189`](https://github.com/bitwarden/android/commit/8006189dbaa7116a8c7deb0b031cc1f3931ec2f8) test enable disable again - [`d5e9463`](https://github.com/bitwarden/android/commit/d5e9463dfa4ec30690c241ba9f78677da693058d) remove test options - [`c13973c`](https://github.com/bitwarden/android/commit/c13973c22ac085bd64132833005da1b82227557e) add specific branch for testing - [`12ea84c`](https://github.com/bitwarden/android/commit/12ea84c548795fd2cb51942a23abfadc66eae4a3) add write permissions - [`836b3cc`](https://github.com/bitwarden/android/commit/836b3ccf1f435b1c942aab821df34a97937e3cfe) remove test settings ### 📊 Changes **3 files changed** (+47 additions, -16 deletions) <details> <summary>View changed files</summary> 📝 `.github/workflows/publish-github-release-bwa.yml` (+2 -15) ➕ `.github/workflows/publish-github-release-bwpm.yml` (+24 -0) 📝 `.github/workflows/publish-store.yml` (+21 -1) </details> ### 📄 Description This updated was tested during the 10/2/25 clients release Added dry-run option to publish-store.yml publish-store.yml will enable github release workflows once release to the ios app store is complete. publish-github-release.yml is now publish-github-release-bwa.yml and publish-github-release-bwa.yml so that they can be enabled or disabled based on which project was released. They now run hourly when enabled. The workflow gh-actions/_publish-mobile-github-release.yml disables the workflow that ran it once it completes successfully. ## 🎟️ Tracking [Original Ticket](https://bitwarden.atlassian.net/browse/BRE-1118) [Follow up for testing](https://bitwarden.atlassian.net/browse/BRE-1194) ## 📔 Objective Right now the check runs at 3am M-F, so if it fails on a Friday it doesn’t run again until Monday, which causes CI jobs to fail. This happens since they use the existing GH release to determine the version and cannot upload using the same version that’s currently rolling out. ## 📸 Screenshots <!-- Required for any UI changes; delete if not applicable. Use fixed width images for better display. --> ## ⏰ Reminders before review - Contributor guidelines followed - All formatters and local linters executed and passed - Written new unit and / or integration tests where applicable - Protected functional changes with optionality (feature flags) - Used internationalization (i18n) for all UI strings - CI builds passed - Communicated to DevOps any deployment requirements - Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team ## 🦮 Reviewer guidelines <!-- Suggested interactions but feel free to use (or not) as you desire! --> - 👍 (`:+1:`) or similar for great changes - 📝 (`:memo:`) or ℹ️ (`:information_source:`) for notes or general info - ❓ (`:question:`) for questions - 🤔 (`:thinking:`) or 💭 (`:thought_balloon:`) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion - 🎨 (`:art:`) for suggestions / improvements - ❌ (`:x:`) or ⚠️ (`:warning:`) for more significant problems or concerns needing attention - 🌱 (`:seedling:`) or ♻️ (`:recycle:`) for future improvements or indications of technical debt - ⛏ (`:pick:`) for minor or nitpick changes --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-21 03:47:45 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#36633
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?