github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-03-22 12:32:53 -05:00
Code Issues 144 Packages Projects Releases 93 Wiki Activity

[PR #5401] [MERGED] [PM-22903] fix unit test execution #5736

New Issue
Closed
opened 2025-11-27 00:13:26 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-27 00:13:26 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/5401
Author: @Nailik
Created: 6/21/2025
Status: ✅ Merged
Merged: 6/24/2025
Merged by: @SaintPatrck

Base: main ← Head: feature/fix-unit-test-execution

📝 Commits (3)

  • 1e63724 add JDK setup to README because some unit tests containing date formatting do not work using JDK 21. JDK 21 uses NNBSP in a date before the pm/am, example: Oct 27, 2023, 12:00(NNBSP)PM
  • 1dd6265 Merge branch 'bitwarden:main' into feature/fix-unit-test-execution
  • b6e19e6 Merge branch 'main' into feature/fix-unit-test-execution

📊 Changes

2 files changed (+11 additions, -1 deletions)

View changed files

📝 README.md (+10 -0)
📝 app/build.gradle.kts (+1 -1)

📄 Description

📔 Objective

  • fix unit test results regardless of the user device location (date formatting in unit tests is tied to US date formatting)
  • add JDK setup to README bc tests will return an error using JDK 21 (date formatting has changed in JDK 21 using NNSPB whitespace before AM/PM)

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/5401 **Author:** [@Nailik](https://github.com/Nailik) **Created:** 6/21/2025 **Status:** ✅ Merged **Merged:** 6/24/2025 **Merged by:** [@SaintPatrck](https://github.com/SaintPatrck) **Base:** `main` ← **Head:** `feature/fix-unit-test-execution` --- ### 📝 Commits (3) - [`1e63724`](https://github.com/bitwarden/android/commit/1e63724b622abf8d7968d71c52c5bdbbce58820b) add JDK setup to README because some unit tests containing date formatting do not work using JDK 21. JDK 21 uses NNBSP in a date before the pm/am, example: Oct 27, 2023, 12:00(NNBSP)PM - [`1dd6265`](https://github.com/bitwarden/android/commit/1dd6265a9c7768e22f5cc777038c6fdc949bc16c) Merge branch 'bitwarden:main' into feature/fix-unit-test-execution - [`b6e19e6`](https://github.com/bitwarden/android/commit/b6e19e685484174338b739ce173607334daeb02a) Merge branch 'main' into feature/fix-unit-test-execution ### 📊 Changes **2 files changed** (+11 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `README.md` (+10 -0) 📝 `app/build.gradle.kts` (+1 -1) </details> ### 📄 Description ## 📔 Objective - fix unit test results regardless of the user device location (date formatting in unit tests is tied to US date formatting) - add JDK setup to README bc tests will return an error using JDK 21 (date formatting has changed in JDK 21 using NNSPB whitespace before AM/PM) ## 🦮 Reviewer guidelines <!-- Suggested interactions but feel free to use (or not) as you desire! --> - 👍 (`:+1:`) or similar for great changes - 📝 (`:memo:`) or ℹ️ (`:information_source:`) for notes or general info - ❓ (`:question:`) for questions - 🤔 (`:thinking:`) or 💭 (`:thought_balloon:`) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion - 🎨 (`:art:`) for suggestions / improvements - ❌ (`:x:`) or ⚠️ (`:warning:`) for more significant problems or concerns needing attention - 🌱 (`:seedling:`) or ♻️ (`:recycle:`) for future improvements or indications of technical debt - ⛏ (`:pick:`) for minor or nitpick changes --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-27 00:13:26 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#5736
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?