github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-03-22 06:11:38 -05:00
Code Issues 144 Packages Projects Releases 116 Wiki Activity

[PR #5012] [PM-20026] RTL text direction #5401

New Issue
Open
opened 2025-11-26 23:59:19 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-26 23:59:19 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/5012
Author: @codokie
Created: 4/9/2025
Status: 🔄 Open

Base: main ← Head: rtl

📝 Commits (7)

  • d8d0469 Force LTR text direction for sensitive fields
  • 363a8a2 Set text direction based on content
  • 511c63e Use layout direction to fix text alignment
  • d7f26e4 Don't use TextAlign.Start, fallback to text style alignment
  • 217929b Add comment
  • feaf9a4 Merge branch 'refs/heads/main' into rtl
  • 64445d9 Add newline at EOF

📊 Changes

12 files changed (+69 additions, -26 deletions)

View changed files

📝 app/src/main/kotlin/com/x8bit/bitwarden/ui/auth/feature/enterprisesignon/EnterpriseSignOnScreen.kt (+0 -2)
📝 app/src/main/kotlin/com/x8bit/bitwarden/ui/auth/feature/loginwithdevice/LoginWithDeviceScreen.kt (+0 -7)
📝 app/src/main/kotlin/com/x8bit/bitwarden/ui/auth/feature/vaultunlock/VaultUnlockScreen.kt (+0 -2)
📝 app/src/main/kotlin/com/x8bit/bitwarden/ui/platform/feature/settings/accountsecurity/deleteaccountconfirmation/DeleteAccountConfirmationScreen.kt (+0 -3)
📝 app/src/main/kotlin/com/x8bit/bitwarden/ui/platform/feature/settings/accountsecurity/loginapproval/LoginApprovalScreen.kt (+0 -2)
📝 app/src/main/kotlin/com/x8bit/bitwarden/ui/platform/feature/settings/accountsecurity/pendingrequests/PendingRequestsScreen.kt (+7 -4)
📝 app/src/main/kotlin/com/x8bit/bitwarden/ui/platform/feature/settings/exportvault/ExportVaultScreen.kt (+0 -2)
📝 ui/src/main/kotlin/com/bitwarden/ui/platform/components/card/BitwardenInfoCalloutCard.kt (+0 -2)
📝 ui/src/main/kotlin/com/bitwarden/ui/platform/components/text/BitwardenClickableText.kt (+0 -2)
📝 ui/src/main/kotlin/com/bitwarden/ui/platform/theme/BitwardenTheme.kt (+13 -0)
📝 ui/src/main/kotlin/com/bitwarden/ui/platform/theme/type/BitwardenTypography.kt (+29 -0)
📝 ui/src/main/kotlin/com/bitwarden/ui/platform/theme/type/Typography.kt (+20 -0)

📄 Description

🎟️ Tracking

#4753

📔 Objective

Fixing text direction of LTR text in RTL layout, and vice versa.

📸 Screenshots

Screenshot

(see "Steps To Reproduce" in the tracked issue)

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/5012 **Author:** [@codokie](https://github.com/codokie) **Created:** 4/9/2025 **Status:** 🔄 Open **Base:** `main` ← **Head:** `rtl` --- ### 📝 Commits (7) - [`d8d0469`](https://github.com/bitwarden/android/commit/d8d0469ce169e54636072ab7ca0ee98cdcfa8088) Force LTR text direction for sensitive fields - [`363a8a2`](https://github.com/bitwarden/android/commit/363a8a2d74ade9d17f0a0df14e07c9b79ee91655) Set text direction based on content - [`511c63e`](https://github.com/bitwarden/android/commit/511c63e72859390f8212193e1b9617b3d86f6121) Use layout direction to fix text alignment - [`d7f26e4`](https://github.com/bitwarden/android/commit/d7f26e49c5f511754a8a1ad2c00738ed96e604b7) Don't use TextAlign.Start, fallback to text style alignment - [`217929b`](https://github.com/bitwarden/android/commit/217929b27c7d1d0877c9689f8a4964cf4e606d25) Add comment - [`feaf9a4`](https://github.com/bitwarden/android/commit/feaf9a46aa0893743e24043e1f0b883f4b3b53ae) Merge branch 'refs/heads/main' into rtl - [`64445d9`](https://github.com/bitwarden/android/commit/64445d970ec4b479c23cc4d4a46163e4a98d8ccd) Add newline at EOF ### 📊 Changes **12 files changed** (+69 additions, -26 deletions) <details> <summary>View changed files</summary> 📝 `app/src/main/kotlin/com/x8bit/bitwarden/ui/auth/feature/enterprisesignon/EnterpriseSignOnScreen.kt` (+0 -2) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/ui/auth/feature/loginwithdevice/LoginWithDeviceScreen.kt` (+0 -7) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/ui/auth/feature/vaultunlock/VaultUnlockScreen.kt` (+0 -2) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/ui/platform/feature/settings/accountsecurity/deleteaccountconfirmation/DeleteAccountConfirmationScreen.kt` (+0 -3) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/ui/platform/feature/settings/accountsecurity/loginapproval/LoginApprovalScreen.kt` (+0 -2) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/ui/platform/feature/settings/accountsecurity/pendingrequests/PendingRequestsScreen.kt` (+7 -4) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/ui/platform/feature/settings/exportvault/ExportVaultScreen.kt` (+0 -2) 📝 `ui/src/main/kotlin/com/bitwarden/ui/platform/components/card/BitwardenInfoCalloutCard.kt` (+0 -2) 📝 `ui/src/main/kotlin/com/bitwarden/ui/platform/components/text/BitwardenClickableText.kt` (+0 -2) 📝 `ui/src/main/kotlin/com/bitwarden/ui/platform/theme/BitwardenTheme.kt` (+13 -0) 📝 `ui/src/main/kotlin/com/bitwarden/ui/platform/theme/type/BitwardenTypography.kt` (+29 -0) 📝 `ui/src/main/kotlin/com/bitwarden/ui/platform/theme/type/Typography.kt` (+20 -0) </details> ### 📄 Description ## 🎟️ Tracking #4753 ## 📔 Objective Fixing text direction of LTR text in RTL layout, and vice versa. ## 📸 Screenshots ![Screenshot](https://github.com/user-attachments/assets/9f47a7b3-9dc0-48bd-a90a-4288d5575b8a) (see "Steps To Reproduce" in the tracked issue) ## ⏰ Reminders before review - Contributor guidelines followed - All formatters and local linters executed and passed - Written new unit and / or integration tests where applicable - Protected functional changes with optionality (feature flags) - Used internationalization (i18n) for all UI strings - CI builds passed - Communicated to DevOps any deployment requirements - Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team ## 🦮 Reviewer guidelines - 👍 (`:+1:`) or similar for great changes - 📝 (`:memo:`) or ℹ️ (`:information_source:`) for notes or general info - ❓ (`:question:`) for questions - 🤔 (`:thinking:`) or 💭 (`:thought_balloon:`) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion - 🎨 (`:art:`) for suggestions / improvements - ❌ (`:x:`) or ⚠️ (`:warning:`) for more significant problems or concerns needing attention - 🌱 (`:seedling:`) or ♻️ (`:recycle:`) for future improvements or indications of technical debt - ⛏ (`:pick:`) for minor or nitpick changes --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-26 23:59:19 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#5401
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?