github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-03-14 14:16:23 -05:00
Code Issues 144 Packages Projects Releases 116 Wiki Activity

[PR #5295] [CLOSED] Agalles/automate android fastlane patch #5650

New Issue
Closed
opened 2025-11-27 00:11:37 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-27 00:11:37 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/5295
Author: @AmyLGalles
Created: 6/2/2025
Status: ❌ Closed

Base: agalles/automate-android-fastlane ← Head: agalles/automate-android-fastlane-patch

📝 Commits (10+)

  • 9deb39d adding release notes to Fastlane
  • c05f621 add lane for updating notes and promoting to prod
  • 9e7cddd add workflow for publishing to production
  • b1ce525 move original release notes lane back
  • 7fe2919 remove whitespace
  • ad6b0bb clarify some option text
  • 8f7c985 removing unnecessary brackets
  • f04bc7e fix formatting
  • 9fd6578 refactoring redundant code
  • ba3b7f7 removing run from fastlane command

📊 Changes

4 files changed (+292 additions, -4 deletions)

View changed files

📝 .github/workflows/publish.yml (+132 -4)
📝 fastlane/Fastfile (+47 -0)
➕ fastlane/patches/supply_custom_promote.rb (+83 -0)
➕ fastlane/patches/supply_custom_promote_config.rb (+30 -0)

📄 Description

🎟️ Tracking

📔 Objective

📸 Screenshots

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/5295 **Author:** [@AmyLGalles](https://github.com/AmyLGalles) **Created:** 6/2/2025 **Status:** ❌ Closed **Base:** `agalles/automate-android-fastlane` ← **Head:** `agalles/automate-android-fastlane-patch` --- ### 📝 Commits (10+) - [`9deb39d`](https://github.com/bitwarden/android/commit/9deb39d7451a41a8f969bcfad3000cacebe28d60) adding release notes to Fastlane - [`c05f621`](https://github.com/bitwarden/android/commit/c05f6219a94410aa9c28fc51f9555a9717066158) add lane for updating notes and promoting to prod - [`9e7cddd`](https://github.com/bitwarden/android/commit/9e7cddd24fcbfe2b6738913f8cb4387f3c1db934) add workflow for publishing to production - [`b1ce525`](https://github.com/bitwarden/android/commit/b1ce52596f60c3132ce3cee517aa11c8d065703d) move original release notes lane back - [`7fe2919`](https://github.com/bitwarden/android/commit/7fe29198a2a455cc6a4c93a3b4576d0b59a174e9) remove whitespace - [`ad6b0bb`](https://github.com/bitwarden/android/commit/ad6b0bb5600ea20c19fb3c258a77a644def2d75c) clarify some option text - [`8f7c985`](https://github.com/bitwarden/android/commit/8f7c98574f34efa8e7700e2dfa9cc6a60b155940) removing unnecessary brackets - [`f04bc7e`](https://github.com/bitwarden/android/commit/f04bc7e2c3978e27591d839a232cfc5e556f918b) fix formatting - [`9fd6578`](https://github.com/bitwarden/android/commit/9fd6578083a2f09d27cab841e485a6a3d179a1d2) refactoring redundant code - [`ba3b7f7`](https://github.com/bitwarden/android/commit/ba3b7f71350d9083549a1706ea8b94dd407276fe) removing run from fastlane command ### 📊 Changes **4 files changed** (+292 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `.github/workflows/publish.yml` (+132 -4) 📝 `fastlane/Fastfile` (+47 -0) ➕ `fastlane/patches/supply_custom_promote.rb` (+83 -0) ➕ `fastlane/patches/supply_custom_promote_config.rb` (+30 -0) </details> ### 📄 Description ## 🎟️ Tracking <!-- Paste the link to the Jira or GitHub issue or otherwise describe / point to where this change is coming from. --> ## 📔 Objective <!-- Describe what the purpose of this PR is, for example what bug you're fixing or new feature you're adding. --> ## 📸 Screenshots <!-- Required for any UI changes; delete if not applicable. Use fixed width images for better display. --> ## ⏰ Reminders before review - Contributor guidelines followed - All formatters and local linters executed and passed - Written new unit and / or integration tests where applicable - Protected functional changes with optionality (feature flags) - Used internationalization (i18n) for all UI strings - CI builds passed - Communicated to DevOps any deployment requirements - Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team ## 🦮 Reviewer guidelines <!-- Suggested interactions but feel free to use (or not) as you desire! --> - 👍 (`:+1:`) or similar for great changes - 📝 (`:memo:`) or ℹ️ (`:information_source:`) for notes or general info - ❓ (`:question:`) for questions - 🤔 (`:thinking:`) or 💭 (`:thought_balloon:`) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion - 🎨 (`:art:`) for suggestions / improvements - ❌ (`:x:`) or ⚠️ (`:warning:`) for more significant problems or concerns needing attention - 🌱 (`:seedling:`) or ♻️ (`:recycle:`) for future improvements or indications of technical debt - ⛏ (`:pick:`) for minor or nitpick changes --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-27 00:11:37 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#5650
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?