github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-03-13 13:44:36 -05:00
Code Issues 144 Packages Projects Releases 116 Wiki Activity

[PR #4897] [CLOSED] Update multi-tonal illustrations and icons to support dynamic colors #5295

New Issue
Closed
opened 2025-11-26 23:57:23 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-26 23:57:23 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/4897
Author: @david-livefront
Created: 3/19/2025
Status: ❌ Closed

Base: innovation-sprint/dynamic-colors/base ← Head: multi-tonal-imagery

📝 Commits (5)

  • 763422a Add support for dynamic colors
  • ab3ff4c Refactor: Update toggle button switch dynamic color scheme
  • e0ec47e Display a warning dialog when enabling dynamic colors
  • f844653 [DynamicColors] Update toggle button switch dynamic color scheme
  • 5c4aa5c Update multi-tonal illustrations and icons to support dynamic colors

📊 Changes

63 files changed (+1653 additions, -2241 deletions)

View changed files

📝 app/src/main/java/com/x8bit/bitwarden/MainActivity.kt (+4 -1)
📝 app/src/main/java/com/x8bit/bitwarden/MainViewModel.kt (+20 -0)
📝 app/src/main/java/com/x8bit/bitwarden/data/platform/datasource/disk/SettingsDiskSource.kt (+10 -0)
📝 app/src/main/java/com/x8bit/bitwarden/data/platform/datasource/disk/SettingsDiskSourceImpl.kt (+15 -0)
📝 app/src/main/java/com/x8bit/bitwarden/data/platform/repository/SettingsRepository.kt (+10 -0)
📝 app/src/main/java/com/x8bit/bitwarden/data/platform/repository/SettingsRepositoryImpl.kt (+16 -0)
📝 app/src/main/java/com/x8bit/bitwarden/ui/platform/components/util/RememberVectorPainter.kt (+92 -1)
📝 app/src/main/java/com/x8bit/bitwarden/ui/platform/feature/settings/appearance/AppearanceScreen.kt (+39 -0)
📝 app/src/main/java/com/x8bit/bitwarden/ui/platform/feature/settings/appearance/AppearanceViewModel.kt (+68 -1)
📝 app/src/main/java/com/x8bit/bitwarden/ui/platform/theme/color/BitwardenColorScheme.kt (+5 -0)
📝 app/src/main/java/com/x8bit/bitwarden/ui/platform/theme/color/ColorScheme.kt (+28 -5)
➖ app/src/main/res/drawable-night/account_setup.xml (+0 -51)
➖ app/src/main/res/drawable-night/blocked_uri.xml (+0 -38)
➖ app/src/main/res/drawable-night/ic_generator_filled.xml (+0 -32)
➖ app/src/main/res/drawable-night/ic_send_filled.xml (+0 -17)
➖ app/src/main/res/drawable-night/ic_settings_filled.xml (+0 -21)
➖ app/src/main/res/drawable-night/ic_vault_filled.xml (+0 -17)
➖ app/src/main/res/drawable-night/img_2fa.xml (+0 -73)
➖ app/src/main/res/drawable-night/img_authenticator.xml (+0 -68)
➖ app/src/main/res/drawable-night/img_folder_question.xml (+0 -37)

...and 43 more files

📄 Description

🎟️ Tracking

N/A

📔 Objective

Add support for dynamic colors in multi-tonal vector illustrations and icons.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • ���� (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/4897 **Author:** [@david-livefront](https://github.com/david-livefront) **Created:** 3/19/2025 **Status:** ❌ Closed **Base:** `innovation-sprint/dynamic-colors/base` ← **Head:** `multi-tonal-imagery` --- ### 📝 Commits (5) - [`763422a`](https://github.com/bitwarden/android/commit/763422a54fe5c5daf4b974203d04e30b94601e9f) Add support for dynamic colors - [`ab3ff4c`](https://github.com/bitwarden/android/commit/ab3ff4cc1d3f691c8758da53a2129fc63826f22c) Refactor: Update toggle button switch dynamic color scheme - [`e0ec47e`](https://github.com/bitwarden/android/commit/e0ec47e3718fb63218f0a1d6cc1c6eefc2fbf6fc) Display a warning dialog when enabling dynamic colors - [`f844653`](https://github.com/bitwarden/android/commit/f8446539a8d8167dab7498f3e1336b77bbd11912) [DynamicColors] Update toggle button switch dynamic color scheme - [`5c4aa5c`](https://github.com/bitwarden/android/commit/5c4aa5cdba91066c92f4bdb830375086f304ef9d) Update multi-tonal illustrations and icons to support dynamic colors ### 📊 Changes **63 files changed** (+1653 additions, -2241 deletions) <details> <summary>View changed files</summary> 📝 `app/src/main/java/com/x8bit/bitwarden/MainActivity.kt` (+4 -1) 📝 `app/src/main/java/com/x8bit/bitwarden/MainViewModel.kt` (+20 -0) 📝 `app/src/main/java/com/x8bit/bitwarden/data/platform/datasource/disk/SettingsDiskSource.kt` (+10 -0) 📝 `app/src/main/java/com/x8bit/bitwarden/data/platform/datasource/disk/SettingsDiskSourceImpl.kt` (+15 -0) 📝 `app/src/main/java/com/x8bit/bitwarden/data/platform/repository/SettingsRepository.kt` (+10 -0) 📝 `app/src/main/java/com/x8bit/bitwarden/data/platform/repository/SettingsRepositoryImpl.kt` (+16 -0) 📝 `app/src/main/java/com/x8bit/bitwarden/ui/platform/components/util/RememberVectorPainter.kt` (+92 -1) 📝 `app/src/main/java/com/x8bit/bitwarden/ui/platform/feature/settings/appearance/AppearanceScreen.kt` (+39 -0) 📝 `app/src/main/java/com/x8bit/bitwarden/ui/platform/feature/settings/appearance/AppearanceViewModel.kt` (+68 -1) 📝 `app/src/main/java/com/x8bit/bitwarden/ui/platform/theme/color/BitwardenColorScheme.kt` (+5 -0) 📝 `app/src/main/java/com/x8bit/bitwarden/ui/platform/theme/color/ColorScheme.kt` (+28 -5) ➖ `app/src/main/res/drawable-night/account_setup.xml` (+0 -51) ➖ `app/src/main/res/drawable-night/blocked_uri.xml` (+0 -38) ➖ `app/src/main/res/drawable-night/ic_generator_filled.xml` (+0 -32) ➖ `app/src/main/res/drawable-night/ic_send_filled.xml` (+0 -17) ➖ `app/src/main/res/drawable-night/ic_settings_filled.xml` (+0 -21) ➖ `app/src/main/res/drawable-night/ic_vault_filled.xml` (+0 -17) ➖ `app/src/main/res/drawable-night/img_2fa.xml` (+0 -73) ➖ `app/src/main/res/drawable-night/img_authenticator.xml` (+0 -68) ➖ `app/src/main/res/drawable-night/img_folder_question.xml` (+0 -37) _...and 43 more files_ </details> ### 📄 Description ## 🎟️ Tracking N/A ## 📔 Objective Add support for dynamic colors in multi-tonal vector illustrations and icons. ## ⏰ Reminders before review - Contributor guidelines followed - All formatters and local linters executed and passed - Written new unit and / or integration tests where applicable - Protected functional changes with optionality (feature flags) - Used internationalization (i18n) for all UI strings - CI builds passed - Communicated to DevOps any deployment requirements - Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team ## 🦮 Reviewer guidelines <!-- Suggested interactions but feel free to use (or not) as you desire! --> - 👍 (`:+1:`) or similar for great changes - 📝 (`:memo:`) or ℹ️ (`:information_source:`) for notes or general info - ❓ (`:question:`) for questions - ���� (`:thinking:`) or 💭 (`:thought_balloon:`) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion - 🎨 (`:art:`) for suggestions / improvements - ❌ (`:x:`) or ⚠️ (`:warning:`) for more significant problems or concerns needing attention - 🌱 (`:seedling:`) or ♻️ (`:recycle:`) for future improvements or indications of technical debt - ⛏ (`:pick:`) for minor or nitpick changes --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-26 23:57:23 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#5295
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?