github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-03-12 05:04:17 -05:00
Code Issues 144 Packages Projects Releases 116 Wiki Activity

[PR #5242] [CLOSED] [PM-21891] Migrate BitwardenOutlinedButton to UI module #5603

New Issue
Closed
opened 2025-11-27 00:10:41 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-27 00:10:41 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/5242
Author: @SaintPatrck
Created: 5/21/2025
Status: ❌ Closed

Base: main ← Head: ui-module/bitwarden-outlined-button

📝 Commits (5)

  • a5cbc63 Rename all java source dirs to kotlin
  • fa42de8 [PM-21851] Use rememberVectorPainter from platform UI in Authenticator
  • 4389cc3 [PM-21888] Migrate icon buttons to ui module
  • 67e9bbf Introduce BitwardenDrawable type alias
  • c9bc3b0 [PM-21889] Move BitwardenOutlinedButton to UI module

📊 Changes

1476 files changed (+132 additions, -267 deletions)

View changed files

📝 app/src/fdroid/kotlin/com/x8bit/bitwarden/data/platform/manager/LogsManagerImpl.kt (+0 -0)
📝 app/src/fdroid/kotlin/com/x8bit/bitwarden/ui/platform/manager/review/AppReviewManagerImpl.kt (+0 -0)
📝 app/src/main/kotlin/com/x8bit/bitwarden/AccessibilityActivity.kt (+0 -0)
📝 app/src/main/kotlin/com/x8bit/bitwarden/AuthCallbackActivity.kt (+0 -0)
📝 app/src/main/kotlin/com/x8bit/bitwarden/AuthCallbackViewModel.kt (+0 -0)
📝 app/src/main/kotlin/com/x8bit/bitwarden/AutofillTotpCopyActivity.kt (+0 -0)
📝 app/src/main/kotlin/com/x8bit/bitwarden/AutofillTotpCopyViewModel.kt (+0 -0)
📝 app/src/main/kotlin/com/x8bit/bitwarden/BitwardenAppComponentFactory.kt (+0 -0)
📝 app/src/main/kotlin/com/x8bit/bitwarden/BitwardenApplication.kt (+0 -0)
📝 app/src/main/kotlin/com/x8bit/bitwarden/BitwardenLegacyAppComponents.kt (+0 -0)
📝 app/src/main/kotlin/com/x8bit/bitwarden/MainActivity.kt (+0 -0)
📝 app/src/main/kotlin/com/x8bit/bitwarden/MainViewModel.kt (+0 -0)
📝 app/src/main/kotlin/com/x8bit/bitwarden/data/auth/datasource/disk/AuthDiskSource.kt (+0 -0)
📝 app/src/main/kotlin/com/x8bit/bitwarden/data/auth/datasource/disk/AuthDiskSourceImpl.kt (+0 -0)
📝 app/src/main/kotlin/com/x8bit/bitwarden/data/auth/datasource/disk/di/AuthDiskModule.kt (+0 -0)
📝 app/src/main/kotlin/com/x8bit/bitwarden/data/auth/datasource/disk/model/AccountJson.kt (+0 -0)
📝 app/src/main/kotlin/com/x8bit/bitwarden/data/auth/datasource/disk/model/AccountTokensJson.kt (+0 -0)
📝 app/src/main/kotlin/com/x8bit/bitwarden/data/auth/datasource/disk/model/ForcePasswordResetReason.kt (+0 -0)
📝 app/src/main/kotlin/com/x8bit/bitwarden/data/auth/datasource/disk/model/OnboardingStatus.kt (+0 -0)
📝 app/src/main/kotlin/com/x8bit/bitwarden/data/auth/datasource/disk/model/PendingAuthRequestJson.kt (+0 -0)

...and 80 more files

📄 Description

🎟️ Tracking

PM-21891

📔 Objective

This commit moves the BitwardenOutlinedButton composable and its associated BitwardenOutlinedButtonColors data class from the app module to the ui module.

This change also updates all import statements across the application to reflect the new location of these components.

The BitwardenOutlinedButton within the authenticator module has been removed, as the ui module's version will now be used.

Important

There is a visual change as a direct result of this migration. See the screenshot below.

📸 Screeshots

Before After
image image

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/5242 **Author:** [@SaintPatrck](https://github.com/SaintPatrck) **Created:** 5/21/2025 **Status:** ❌ Closed **Base:** `main` ← **Head:** `ui-module/bitwarden-outlined-button` --- ### 📝 Commits (5) - [`a5cbc63`](https://github.com/bitwarden/android/commit/a5cbc63a55473ca7cc3ce0a18e3d3b4c627cf717) Rename all `java` source dirs to `kotlin` - [`fa42de8`](https://github.com/bitwarden/android/commit/fa42de859c4718b63e898b89b4ddf87cf2d88f56) [PM-21851] Use `rememberVectorPainter` from platform UI in Authenticator - [`4389cc3`](https://github.com/bitwarden/android/commit/4389cc3a912d9dc87c4bda48888b378c00fd6fca) [PM-21888] Migrate icon buttons to ui module - [`67e9bbf`](https://github.com/bitwarden/android/commit/67e9bbfdf54e1bc387153688a2facfc4698850e6) Introduce BitwardenDrawable type alias - [`c9bc3b0`](https://github.com/bitwarden/android/commit/c9bc3b0d519758ffd0f937a3cd1a31e6750474ea) [PM-21889] Move BitwardenOutlinedButton to UI module ### 📊 Changes **1476 files changed** (+132 additions, -267 deletions) <details> <summary>View changed files</summary> 📝 `app/src/fdroid/kotlin/com/x8bit/bitwarden/data/platform/manager/LogsManagerImpl.kt` (+0 -0) 📝 `app/src/fdroid/kotlin/com/x8bit/bitwarden/ui/platform/manager/review/AppReviewManagerImpl.kt` (+0 -0) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/AccessibilityActivity.kt` (+0 -0) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/AuthCallbackActivity.kt` (+0 -0) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/AuthCallbackViewModel.kt` (+0 -0) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/AutofillTotpCopyActivity.kt` (+0 -0) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/AutofillTotpCopyViewModel.kt` (+0 -0) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/BitwardenAppComponentFactory.kt` (+0 -0) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/BitwardenApplication.kt` (+0 -0) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/BitwardenLegacyAppComponents.kt` (+0 -0) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/MainActivity.kt` (+0 -0) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/MainViewModel.kt` (+0 -0) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/data/auth/datasource/disk/AuthDiskSource.kt` (+0 -0) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/data/auth/datasource/disk/AuthDiskSourceImpl.kt` (+0 -0) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/data/auth/datasource/disk/di/AuthDiskModule.kt` (+0 -0) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/data/auth/datasource/disk/model/AccountJson.kt` (+0 -0) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/data/auth/datasource/disk/model/AccountTokensJson.kt` (+0 -0) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/data/auth/datasource/disk/model/ForcePasswordResetReason.kt` (+0 -0) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/data/auth/datasource/disk/model/OnboardingStatus.kt` (+0 -0) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/data/auth/datasource/disk/model/PendingAuthRequestJson.kt` (+0 -0) _...and 80 more files_ </details> ### 📄 Description ## 🎟️ Tracking PM-21891 ## 📔 Objective This commit moves the `BitwardenOutlinedButton` composable and its associated `BitwardenOutlinedButtonColors` data class from the `app` module to the `ui` module. This change also updates all import statements across the application to reflect the new location of these components. The `BitwardenOutlinedButton` within the `authenticator` module has been removed, as the `ui` module's version will now be used. > [!IMPORTANT] > There is a visual change as a direct result of this migration. See the screenshot below. ## 📸 Screeshots | Before | After | |--------|--------| | <img width="457" alt="image" src="https://github.com/user-attachments/assets/80ae047e-aa61-452f-8439-fc6e32376352" /> | <img width="455" alt="image" src="https://github.com/user-attachments/assets/09d6f8c6-6600-4ff2-993d-d78f225c397d" /> | ## ⏰ Reminders before review - Contributor guidelines followed - All formatters and local linters executed and passed - Written new unit and / or integration tests where applicable - Protected functional changes with optionality (feature flags) - Used internationalization (i18n) for all UI strings - CI builds passed - Communicated to DevOps any deployment requirements - Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team ## 🦮 Reviewer guidelines <!-- Suggested interactions but feel free to use (or not) as you desire! --> - 👍 (`:+1:`) or similar for great changes - 📝 (`:memo:`) or ℹ️ (`:information_source:`) for notes or general info - ❓ (`:question:`) for questions - 🤔 (`:thinking:`) or 💭 (`:thought_balloon:`) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion - 🎨 (`:art:`) for suggestions / improvements - ❌ (`:x:`) or ⚠️ (`:warning:`) for more significant problems or concerns needing attention - 🌱 (`:seedling:`) or ♻️ (`:recycle:`) for future improvements or indications of technical debt - ⛏ (`:pick:`) for minor or nitpick changes --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-27 00:10:41 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#5603
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?