github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-03-13 21:54:17 -05:00
Code Issues 144 Packages Projects Releases 116 Wiki Activity

[PR #4823] [MERGED] PM-17087 update notification payloads to support camelCase JSON keys. #5242

New Issue
Closed
opened 2025-11-26 23:56:14 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-26 23:56:14 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/4823
Author: @dseverns-livefront
Created: 3/5/2025
Status: ✅ Merged
Merged: 3/10/2025
Merged by: @dseverns-livefront

Base: main ← Head: PM-17087-update-json-names-to-support-mult-case

📝 Commits (3)

  • 75060f2 PM-17087 update notification payloads to support camelCase JSON keys.
  • 69666b5 fix test/serialization of userId
  • 006be4f 86 \n

📊 Changes

1 file changed (+18 additions, -16 deletions)

View changed files

📝 app/src/main/java/com/x8bit/bitwarden/data/platform/manager/model/NotificationPayload.kt (+18 -16)

📄 Description

🎟️ Tracking

PM-17087

📔 Objective

  • Support servers which are pushing the notification payload with camelCase key names. (ex: qa-team.sh.bitwarden.pw).
  • Interestingly it does look like the server code is pushing the response using camelCase but we have been using PascalCase and are not seeing these issues reported on production builds. NotificationHubPushService

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/4823 **Author:** [@dseverns-livefront](https://github.com/dseverns-livefront) **Created:** 3/5/2025 **Status:** ✅ Merged **Merged:** 3/10/2025 **Merged by:** [@dseverns-livefront](https://github.com/dseverns-livefront) **Base:** `main` ← **Head:** `PM-17087-update-json-names-to-support-mult-case` --- ### 📝 Commits (3) - [`75060f2`](https://github.com/bitwarden/android/commit/75060f2ba3e78f22ba063d07fec66d82b8d56f24) PM-17087 update notification payloads to support camelCase JSON keys. - [`69666b5`](https://github.com/bitwarden/android/commit/69666b5de311a0c1e83f147f50db049b54777125) fix test/serialization of userId - [`006be4f`](https://github.com/bitwarden/android/commit/006be4f0d2773ac490c5a5d823f87a586cbe18a1) 86 \n ### 📊 Changes **1 file changed** (+18 additions, -16 deletions) <details> <summary>View changed files</summary> 📝 `app/src/main/java/com/x8bit/bitwarden/data/platform/manager/model/NotificationPayload.kt` (+18 -16) </details> ### 📄 Description ## 🎟️ Tracking [PM-17087](https://bitwarden.atlassian.net/browse/PM-17087) <!-- Paste the link to the Jira or GitHub issue or otherwise describe / point to where this change is coming from. --> ## 📔 Objective - Support servers which are pushing the notification payload with `camelCase` key names. (ex: `qa-team.sh.bitwarden.pw`). - Interestingly it does look like the server code is pushing the response using `camelCase` but we have been using `PascalCase` and are not seeing these issues reported on production builds. [NotificationHubPushService](https://github.com/bitwarden/server/blob/main/src/Core/NotificationHub/NotificationHubPushRegistrationService.cs#L50) <!-- Describe what the purpose of this PR is, for example what bug you're fixing or new feature you're adding. --> <!-- Required for any UI changes; delete if not applicable. Use fixed width images for better display. --> ## ⏰ Reminders before review - Contributor guidelines followed - All formatters and local linters executed and passed - Written new unit and / or integration tests where applicable - Protected functional changes with optionality (feature flags) - Used internationalization (i18n) for all UI strings - CI builds passed - Communicated to DevOps any deployment requirements - Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team ## 🦮 Reviewer guidelines <!-- Suggested interactions but feel free to use (or not) as you desire! --> - 👍 (`:+1:`) or similar for great changes - 📝 (`:memo:`) or ℹ️ (`:information_source:`) for notes or general info - ❓ (`:question:`) for questions - 🤔 (`:thinking:`) or 💭 (`:thought_balloon:`) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion - 🎨 (`:art:`) for suggestions / improvements - ❌ (`:x:`) or ⚠️ (`:warning:`) for more significant problems or concerns needing attention - 🌱 (`:seedling:`) or ♻️ (`:recycle:`) for future improvements or indications of technical debt - ⛏ (`:pick:`) for minor or nitpick changes [PM-17087]: https://bitwarden.atlassian.net/browse/PM-17087?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-26 23:56:14 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#5242
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?