github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-03-13 21:54:17 -05:00
Code Issues 144 Packages Projects Releases 116 Wiki Activity

[PR #5100] [MERGED] [PM-20466] Invalid master password returns generic error. #5480

New Issue
Closed
opened 2025-11-27 00:03:52 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-27 00:03:52 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/5100
Author: @andrebispo5
Created: 4/25/2025
Status: ✅ Merged
Merged: 5/1/2025
Merged by: @andrebispo5

Base: main ← Head: pm-20466/remove-password-message-bug

📝 Commits (9)

  • 682e0e5 [PM-20466] Add error message to RemovePasswordResult.
  • 2bb2aee [PM-20466] Add WrongPasswordError to RemovePasswordResult.
  • 62b532f Merge branch 'main' into pm-20466/remove-password-message-bug
  • ef49420 [PM-20466] Remove import
  • 9e5bc6d [PM-20466] Move wrong password error handling to VaultSdkSource and propagate it to ViewModel.
  • ebd0ff2 Merge branch 'main' into pm-20466/remove-password-message-bug
  • 644be8f [PM-20466] Fix viewmodel test
  • aefa6a6 [PM-20466] Lint
  • e72376c [PM-20466] Fix chain

📊 Changes

13 files changed (+405 additions, -41 deletions)

View changed files

📝 app/src/main/java/com/x8bit/bitwarden/data/auth/manager/KeyConnectorManager.kt (+2 -1)
📝 app/src/main/java/com/x8bit/bitwarden/data/auth/manager/KeyConnectorManagerImpl.kt (+32 -4)
➕ app/src/main/java/com/x8bit/bitwarden/data/auth/manager/model/MigrateExistingUserToKeyConnectorResult.kt (+23 -0)
📝 app/src/main/java/com/x8bit/bitwarden/data/auth/repository/AuthRepositoryImpl.kt (+24 -11)
📝 app/src/main/java/com/x8bit/bitwarden/data/auth/repository/model/RemovePasswordResult.kt (+5 -0)
📝 app/src/main/java/com/x8bit/bitwarden/data/vault/datasource/sdk/VaultSdkSource.kt (+2 -1)
📝 app/src/main/java/com/x8bit/bitwarden/data/vault/datasource/sdk/VaultSdkSourceImpl.kt (+22 -11)
➕ app/src/main/java/com/x8bit/bitwarden/data/vault/datasource/sdk/model/DeriveKeyConnectorResult.kt (+26 -0)
📝 app/src/main/java/com/x8bit/bitwarden/ui/auth/feature/removepassword/RemovePasswordViewModel.kt (+11 -0)
📝 app/src/test/java/com/x8bit/bitwarden/data/auth/manager/KeyConnectorManagerTest.kt (+47 -10)
📝 app/src/test/java/com/x8bit/bitwarden/data/auth/repository/AuthRepositoryTest.kt (+83 -2)
📝 app/src/test/java/com/x8bit/bitwarden/data/vault/datasource/sdk/VaultSdkSourceTest.kt (+95 -1)
📝 app/src/test/java/com/x8bit/bitwarden/ui/auth/feature/removepassword/RemovePasswordViewModelTest.kt (+33 -0)

📄 Description

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-20466

📔 Objective

When removing the master password after SSO login, the error message for wrong password was not being shown to the user.

📸 Screenshots

https://github.com/user-attachments/assets/8a07e7c7-41f0-4519-b3ba-832b2f15ac80

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/5100 **Author:** [@andrebispo5](https://github.com/andrebispo5) **Created:** 4/25/2025 **Status:** ✅ Merged **Merged:** 5/1/2025 **Merged by:** [@andrebispo5](https://github.com/andrebispo5) **Base:** `main` ← **Head:** `pm-20466/remove-password-message-bug` --- ### 📝 Commits (9) - [`682e0e5`](https://github.com/bitwarden/android/commit/682e0e55d307b48ea3ae9469752e352b338c7e48) [PM-20466] Add error message to RemovePasswordResult. - [`2bb2aee`](https://github.com/bitwarden/android/commit/2bb2aee0c3ceb251337e774d4b4acea1781bb2ef) [PM-20466] Add WrongPasswordError to RemovePasswordResult. - [`62b532f`](https://github.com/bitwarden/android/commit/62b532f08e9fbb5e5ab759a7c4918501409d68e8) Merge branch 'main' into pm-20466/remove-password-message-bug - [`ef49420`](https://github.com/bitwarden/android/commit/ef49420a02536b20dae8114bd2a7f1bae8a1c22a) [PM-20466] Remove import - [`9e5bc6d`](https://github.com/bitwarden/android/commit/9e5bc6dcc31398ccf0e1476042511f83940ee17c) [PM-20466] Move wrong password error handling to VaultSdkSource and propagate it to ViewModel. - [`ebd0ff2`](https://github.com/bitwarden/android/commit/ebd0ff27f14b97a117a1f8353781b20c35a274f1) Merge branch 'main' into pm-20466/remove-password-message-bug - [`644be8f`](https://github.com/bitwarden/android/commit/644be8f5e047abf2613aaa3adcfbe6b773647b9f) [PM-20466] Fix viewmodel test - [`aefa6a6`](https://github.com/bitwarden/android/commit/aefa6a63291235cf9906a5269f1952aef528cb34) [PM-20466] Lint - [`e72376c`](https://github.com/bitwarden/android/commit/e72376cc02156f8bf775aed0b1f58c8dae40be31) [PM-20466] Fix chain ### 📊 Changes **13 files changed** (+405 additions, -41 deletions) <details> <summary>View changed files</summary> 📝 `app/src/main/java/com/x8bit/bitwarden/data/auth/manager/KeyConnectorManager.kt` (+2 -1) 📝 `app/src/main/java/com/x8bit/bitwarden/data/auth/manager/KeyConnectorManagerImpl.kt` (+32 -4) ➕ `app/src/main/java/com/x8bit/bitwarden/data/auth/manager/model/MigrateExistingUserToKeyConnectorResult.kt` (+23 -0) 📝 `app/src/main/java/com/x8bit/bitwarden/data/auth/repository/AuthRepositoryImpl.kt` (+24 -11) 📝 `app/src/main/java/com/x8bit/bitwarden/data/auth/repository/model/RemovePasswordResult.kt` (+5 -0) 📝 `app/src/main/java/com/x8bit/bitwarden/data/vault/datasource/sdk/VaultSdkSource.kt` (+2 -1) 📝 `app/src/main/java/com/x8bit/bitwarden/data/vault/datasource/sdk/VaultSdkSourceImpl.kt` (+22 -11) ➕ `app/src/main/java/com/x8bit/bitwarden/data/vault/datasource/sdk/model/DeriveKeyConnectorResult.kt` (+26 -0) 📝 `app/src/main/java/com/x8bit/bitwarden/ui/auth/feature/removepassword/RemovePasswordViewModel.kt` (+11 -0) 📝 `app/src/test/java/com/x8bit/bitwarden/data/auth/manager/KeyConnectorManagerTest.kt` (+47 -10) 📝 `app/src/test/java/com/x8bit/bitwarden/data/auth/repository/AuthRepositoryTest.kt` (+83 -2) 📝 `app/src/test/java/com/x8bit/bitwarden/data/vault/datasource/sdk/VaultSdkSourceTest.kt` (+95 -1) 📝 `app/src/test/java/com/x8bit/bitwarden/ui/auth/feature/removepassword/RemovePasswordViewModelTest.kt` (+33 -0) </details> ### 📄 Description ## 🎟️ Tracking <!-- Paste the link to the Jira or GitHub issue or otherwise describe / point to where this change is coming from. --> https://bitwarden.atlassian.net/browse/PM-20466 ## 📔 Objective <!-- Describe what the purpose of this PR is, for example what bug you're fixing or new feature you're adding. --> When removing the master password after SSO login, the error message for wrong password was not being shown to the user. ## 📸 Screenshots <!-- Required for any UI changes; delete if not applicable. Use fixed width images for better display. --> https://github.com/user-attachments/assets/8a07e7c7-41f0-4519-b3ba-832b2f15ac80 ## ⏰ Reminders before review - Contributor guidelines followed - All formatters and local linters executed and passed - Written new unit and / or integration tests where applicable - Protected functional changes with optionality (feature flags) - Used internationalization (i18n) for all UI strings - CI builds passed - Communicated to DevOps any deployment requirements - Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team ## 🦮 Reviewer guidelines <!-- Suggested interactions but feel free to use (or not) as you desire! --> - 👍 (`:+1:`) or similar for great changes - 📝 (`:memo:`) or ℹ️ (`:information_source:`) for notes or general info - ❓ (`:question:`) for questions - 🤔 (`:thinking:`) or 💭 (`:thought_balloon:`) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion - 🎨 (`:art:`) for suggestions / improvements - ❌ (`:x:`) or ⚠️ (`:warning:`) for more significant problems or concerns needing attention - 🌱 (`:seedling:`) or ♻️ (`:recycle:`) for future improvements or indications of technical debt - ⛏ (`:pick:`) for minor or nitpick changes --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-27 00:03:52 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#5480
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?