github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-03-13 05:34:14 -05:00
Code Issues 144 Packages Projects Releases 116 Wiki Activity

[PR #4647] [MERGED] PM-17384 PM-17386 - Create Account Design Audit #5100

New Issue
Closed
opened 2025-11-26 23:54:01 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-26 23:54:01 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/4647
Author: @phil-livefront
Created: 1/29/2025
Status: ✅ Merged
Merged: 1/29/2025
Merged by: @phil-livefront

Base: main ← Head: phil/PM-17384-PM-17386-create-account-design-audit

📝 Commits (8)

  • bdc07c3 PM-17384 PM-17386 - Create Account design audit
  • ad70241 removed commented out spacers which shouldn't have been there
  • d4d972f fix tests
  • 57360b0 update content description for navigation icon button
  • c44ded9 update back button verbiage to close and updated tests
  • 0fc9863 Merge branch 'main' into phil/PM-17384-PM-17386-create-account-design-audit
  • ab83a1b update naming in favor of CloseClick
  • 539b8a3 Merge branch 'main' into phil/PM-17384-PM-17386-create-account-design-audit

📊 Changes

6 files changed (+73 additions, -62 deletions)

View changed files

📝 app/src/main/java/com/x8bit/bitwarden/ui/auth/feature/landing/LandingScreen.kt (+1 -1)
📝 app/src/main/java/com/x8bit/bitwarden/ui/auth/feature/startregistration/StartRegistrationScreen.kt (+56 -47)
📝 app/src/main/java/com/x8bit/bitwarden/ui/auth/feature/startregistration/StartRegistrationViewModel.kt (+5 -5)
📝 app/src/main/java/com/x8bit/bitwarden/ui/auth/feature/startregistration/handlers/StartRegistrationHandler.kt (+4 -2)
📝 app/src/test/java/com/x8bit/bitwarden/ui/auth/feature/startregistration/StartRegistrationScreenTest.kt (+5 -5)
📝 app/src/test/java/com/x8bit/bitwarden/ui/auth/feature/startregistration/StartRegistrationViewModelTest.kt (+2 -2)

📄 Description

🎟️ Tracking

PM-17384
PM-17386

📔 Objective

  • Change color of non-link text to Text-Secondary
  • Remove Vault illustration in favor of the Bitwarden logo and align spacing
  • Reverse order of the name and email fields
  • Update back button icon to be a “X” close button
  • Update the email address placeholder to Email address (required)

📸 Screenshots

With new boarding flag on

Screenshot_1738179826

With new onboarding flag on (Self hosted)

Screenshot_1738179567

With new boarding flag off

Screenshot_1738179834

With new onboarding flag off (Self hosted)

Screenshot_1738179583

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed
    issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/4647 **Author:** [@phil-livefront](https://github.com/phil-livefront) **Created:** 1/29/2025 **Status:** ✅ Merged **Merged:** 1/29/2025 **Merged by:** [@phil-livefront](https://github.com/phil-livefront) **Base:** `main` ← **Head:** `phil/PM-17384-PM-17386-create-account-design-audit` --- ### 📝 Commits (8) - [`bdc07c3`](https://github.com/bitwarden/android/commit/bdc07c3f4a4870abe5fd0e555fe3ff7b8983945f) PM-17384 PM-17386 - Create Account design audit - [`ad70241`](https://github.com/bitwarden/android/commit/ad70241226c5572bb9ab43a78805102188a3e763) removed commented out spacers which shouldn't have been there - [`d4d972f`](https://github.com/bitwarden/android/commit/d4d972fe8642458864d269716e552231c549a6e2) fix tests - [`57360b0`](https://github.com/bitwarden/android/commit/57360b08705af3bacc1b108451fa2220eb7627d4) update content description for navigation icon button - [`c44ded9`](https://github.com/bitwarden/android/commit/c44ded9cdd8f71892cb715813f61766bf550be8d) update back button verbiage to close and updated tests - [`0fc9863`](https://github.com/bitwarden/android/commit/0fc9863933dae19467519fe5d519ebe65ab18645) Merge branch 'main' into phil/PM-17384-PM-17386-create-account-design-audit - [`ab83a1b`](https://github.com/bitwarden/android/commit/ab83a1b2aa973294615a034bab955e8915bf2ea7) update naming in favor of CloseClick - [`539b8a3`](https://github.com/bitwarden/android/commit/539b8a3b41e101be6450b83f2c30db7846222d71) Merge branch 'main' into phil/PM-17384-PM-17386-create-account-design-audit ### 📊 Changes **6 files changed** (+73 additions, -62 deletions) <details> <summary>View changed files</summary> 📝 `app/src/main/java/com/x8bit/bitwarden/ui/auth/feature/landing/LandingScreen.kt` (+1 -1) 📝 `app/src/main/java/com/x8bit/bitwarden/ui/auth/feature/startregistration/StartRegistrationScreen.kt` (+56 -47) 📝 `app/src/main/java/com/x8bit/bitwarden/ui/auth/feature/startregistration/StartRegistrationViewModel.kt` (+5 -5) 📝 `app/src/main/java/com/x8bit/bitwarden/ui/auth/feature/startregistration/handlers/StartRegistrationHandler.kt` (+4 -2) 📝 `app/src/test/java/com/x8bit/bitwarden/ui/auth/feature/startregistration/StartRegistrationScreenTest.kt` (+5 -5) 📝 `app/src/test/java/com/x8bit/bitwarden/ui/auth/feature/startregistration/StartRegistrationViewModelTest.kt` (+2 -2) </details> ### 📄 Description ## 🎟️ Tracking [PM-17384](https://bitwarden.atlassian.net/browse/PM-17384) [PM-17386](https://bitwarden.atlassian.net/browse/PM-17386) ## 📔 Objective - Change color of non-link text to Text-Secondary - Remove Vault illustration in favor of the Bitwarden logo and align spacing - Reverse order of the name and email fields - Update back button icon to be a “X” close button - Update the email address placeholder to `Email address (required)` ## 📸 Screenshots ### With new boarding flag on ![Screenshot_1738179826](https://github.com/user-attachments/assets/840ff120-4c75-419e-8208-e5e665412e09) ### With new onboarding flag on (Self hosted) ![Screenshot_1738179567](https://github.com/user-attachments/assets/9d3f36f5-7dd7-4bb2-a109-fc15641e166b) ### With new boarding flag off ![Screenshot_1738179834](https://github.com/user-attachments/assets/cf20fb8f-0284-4f7e-942a-f070c90dadd4) ### With new onboarding flag off (Self hosted) ![Screenshot_1738179583](https://github.com/user-attachments/assets/60843fa7-8498-49e0-9064-6bfa89ba4802) ## ⏰ Reminders before review - Contributor guidelines followed - All formatters and local linters executed and passed - Written new unit and / or integration tests where applicable - Used internationalization (i18n) for all UI strings - CI builds passed - Communicated to DevOps any deployment requirements - Updated any necessary documentation or informed the documentation team ## 🦮 Reviewer guidelines <!-- Suggested interactions but feel free to use (or not) as you desire! --> - 👍 (`:+1:`) or similar for great changes - 📝 (`:memo:`) or ℹ️ (`:information_source:`) for notes or general info - ❓ (`:question:`) for questions - 🤔 (`:thinking:`) or 💭 (`:thought_balloon:`) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion - 🎨 (`:art:`) for suggestions / improvements - ❌ (`:x:`) or ⚠️ (`:warning:`) for more significant problems or concerns needing attention - 🌱 (`:seedling:`) or ♻️ (`:recycle:`) for future improvements or indications of technical debt - ⛏ (`:pick:`) for minor or nitpick changes [PM-17384]: https://bitwarden.atlassian.net/browse/PM-17384?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ [PM-17386]: https://bitwarden.atlassian.net/browse/PM-17386?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-26 23:54:01 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#5100
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?