github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-03-14 14:16:23 -05:00
Code Issues 144 Packages Projects Releases 116 Wiki Activity

[PR #5047] [MERGED] [PM-20189] Migrate IdentityService and related components to network module #5430

New Issue
Closed
opened 2025-11-26 23:59:44 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-26 23:59:44 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/5047
Author: @SaintPatrck
Created: 4/14/2025
Status: ✅ Merged
Merged: 4/15/2025
Merged by: @SaintPatrck

Base: main ← Head: network-module/identity-service

📝 Commits (1)

  • 1955352 [PM-20189] Migrate IdentityService and related components to network module

📊 Changes

15 files changed (+37 additions, -37 deletions)

View changed files

📝 app/src/main/java/com/x8bit/bitwarden/data/auth/datasource/network/di/AuthNetworkModule.kt (+2 -2)
📝 app/src/main/java/com/x8bit/bitwarden/data/auth/repository/AuthRepository.kt (+1 -1)
📝 app/src/main/java/com/x8bit/bitwarden/data/auth/repository/AuthRepositoryImpl.kt (+5 -5)
📝 app/src/main/java/com/x8bit/bitwarden/data/auth/repository/di/AuthRepositoryModule.kt (+1 -1)
📝 app/src/main/java/com/x8bit/bitwarden/ui/auth/feature/twofactorlogin/TwoFactorLoginViewModel.kt (+1 -1)
📝 app/src/test/java/com/x8bit/bitwarden/data/auth/repository/AuthRepositoryTest.kt (+5 -5)
📝 app/src/test/java/com/x8bit/bitwarden/ui/auth/feature/twofactorlogin/TwoFactorLoginViewModelTest.kt (+1 -1)
📝 network/src/main/kotlin/com/bitwarden/network/model/IdentityTokenAuthModel.kt (+1 -1)
📝 network/src/main/kotlin/com/bitwarden/network/model/SendVerificationEmailResponseJson.kt (+1 -1)
📝 network/src/main/kotlin/com/bitwarden/network/model/TwoFactorDataModel.kt (+1 -1)
📝 network/src/main/kotlin/com/bitwarden/network/model/VerifyEmailTokenResponseJson.kt (+1 -1)
📝 network/src/main/kotlin/com/bitwarden/network/service/IdentityService.kt (+5 -5)
📝 network/src/main/kotlin/com/bitwarden/network/service/IdentityServiceImpl.kt (+6 -6)
📝 network/src/main/kotlin/com/bitwarden/network/util/DeviceModelProvider.kt (+1 -1)
📝 network/src/test/kotlin/com/bitwarden/network/service/IdentityServiceTest.kt (+5 -5)

📄 Description

🎟️ Tracking

PM-20189

📔 Objective

Moved IdentityService, IdentityServiceImpl and DeviceModelProvider from the app module to the network module. IdentityTokenAuthModel, TwoFactorDataModel, SendVerificationEmailResponseJson, and VerifyEmailTokenResponseJson have also been moved to the network module.

The changes include:

  • Model Relocation: Moved IdentityTokenAuthModel, TwoFactorDataModel, SendVerificationEmailResponseJson, VerifyEmailTokenResponseJson, IdentityService, IdentityServiceImpl and DeviceModelProvider to the network module.
  • Removal from app module: Removed the previous files from the app module.
  • Update usages: Updated all usages of IdentityTokenAuthModel, TwoFactorDataModel, SendVerificationEmailResponseJson, and VerifyEmailTokenResponseJson to use the new implementation in network.
  • Update tests: Added or updated tests in network module.

📸 Screenshots

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/5047 **Author:** [@SaintPatrck](https://github.com/SaintPatrck) **Created:** 4/14/2025 **Status:** ✅ Merged **Merged:** 4/15/2025 **Merged by:** [@SaintPatrck](https://github.com/SaintPatrck) **Base:** `main` ← **Head:** `network-module/identity-service` --- ### 📝 Commits (1) - [`1955352`](https://github.com/bitwarden/android/commit/19553526e53298de3264cc9d59a5f6e798e3b3e9) [PM-20189] Migrate IdentityService and related components to `network` module ### 📊 Changes **15 files changed** (+37 additions, -37 deletions) <details> <summary>View changed files</summary> 📝 `app/src/main/java/com/x8bit/bitwarden/data/auth/datasource/network/di/AuthNetworkModule.kt` (+2 -2) 📝 `app/src/main/java/com/x8bit/bitwarden/data/auth/repository/AuthRepository.kt` (+1 -1) 📝 `app/src/main/java/com/x8bit/bitwarden/data/auth/repository/AuthRepositoryImpl.kt` (+5 -5) 📝 `app/src/main/java/com/x8bit/bitwarden/data/auth/repository/di/AuthRepositoryModule.kt` (+1 -1) 📝 `app/src/main/java/com/x8bit/bitwarden/ui/auth/feature/twofactorlogin/TwoFactorLoginViewModel.kt` (+1 -1) 📝 `app/src/test/java/com/x8bit/bitwarden/data/auth/repository/AuthRepositoryTest.kt` (+5 -5) 📝 `app/src/test/java/com/x8bit/bitwarden/ui/auth/feature/twofactorlogin/TwoFactorLoginViewModelTest.kt` (+1 -1) 📝 `network/src/main/kotlin/com/bitwarden/network/model/IdentityTokenAuthModel.kt` (+1 -1) 📝 `network/src/main/kotlin/com/bitwarden/network/model/SendVerificationEmailResponseJson.kt` (+1 -1) 📝 `network/src/main/kotlin/com/bitwarden/network/model/TwoFactorDataModel.kt` (+1 -1) 📝 `network/src/main/kotlin/com/bitwarden/network/model/VerifyEmailTokenResponseJson.kt` (+1 -1) 📝 `network/src/main/kotlin/com/bitwarden/network/service/IdentityService.kt` (+5 -5) 📝 `network/src/main/kotlin/com/bitwarden/network/service/IdentityServiceImpl.kt` (+6 -6) 📝 `network/src/main/kotlin/com/bitwarden/network/util/DeviceModelProvider.kt` (+1 -1) 📝 `network/src/test/kotlin/com/bitwarden/network/service/IdentityServiceTest.kt` (+5 -5) </details> ### 📄 Description ## 🎟️ Tracking PM-20189 ## 📔 Objective Moved `IdentityService`, `IdentityServiceImpl` and `DeviceModelProvider` from the `app` module to the `network` module. `IdentityTokenAuthModel`, `TwoFactorDataModel`, `SendVerificationEmailResponseJson`, and `VerifyEmailTokenResponseJson` have also been moved to the `network` module. The changes include: - **Model Relocation:** Moved `IdentityTokenAuthModel`, `TwoFactorDataModel`, `SendVerificationEmailResponseJson`, `VerifyEmailTokenResponseJson`, `IdentityService`, `IdentityServiceImpl` and `DeviceModelProvider` to the `network` module. - **Removal from app module:** Removed the previous files from the `app` module. - **Update usages**: Updated all usages of `IdentityTokenAuthModel`, `TwoFactorDataModel`, `SendVerificationEmailResponseJson`, and `VerifyEmailTokenResponseJson` to use the new implementation in `network`. - **Update tests**: Added or updated tests in `network` module. ## 📸 Screenshots <!-- Required for any UI changes; delete if not applicable. Use fixed width images for better display. --> ## ⏰ Reminders before review - Contributor guidelines followed - All formatters and local linters executed and passed - Written new unit and / or integration tests where applicable - Protected functional changes with optionality (feature flags) - Used internationalization (i18n) for all UI strings - CI builds passed - Communicated to DevOps any deployment requirements - Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team ## 🦮 Reviewer guidelines <!-- Suggested interactions but feel free to use (or not) as you desire! --> - 👍 (`:+1:`) or similar for great changes - 📝 (`:memo:`) or ℹ️ (`:information_source:`) for notes or general info - ❓ (`:question:`) for questions - 🤔 (`:thinking:`) or 💭 (`:thought_balloon:`) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion - 🎨 (`:art:`) for suggestions / improvements - ❌ (`:x:`) or ⚠️ (`:warning:`) for more significant problems or concerns needing attention - 🌱 (`:seedling:`) or ♻️ (`:recycle:`) for future improvements or indications of technical debt - ⛏ (`:pick:`) for minor or nitpick changes --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-26 23:59:44 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#5430
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?