github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-03-15 06:59:05 -05:00
Code Issues 144 Packages Projects Releases 116 Wiki Activity

[PR #4571] [MERGED] PM-16631 Applying CoachMarkContainer to the AddLoginItem content. #5047

New Issue
Closed
opened 2025-11-26 23:53:18 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-26 23:53:18 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/4571
Author: @dseverns-livefront
Created: 1/15/2025
Status: ✅ Merged
Merged: 1/21/2025
Merged by: @dseverns-livefront

Base: main ← Head: PM-16631-add-coachmark-to-add-login

📝 Commits (10+)

📊 Changes

19 files changed (+1752 additions, -147 deletions)

View changed files

📝 app/src/main/java/com/x8bit/bitwarden/ui/platform/base/util/ModifierExtensions.kt (+56 -4)
➕ app/src/main/java/com/x8bit/bitwarden/ui/platform/components/coachmark/CoachMarkActionText.kt (+24 -0)
➕ app/src/main/java/com/x8bit/bitwarden/ui/platform/components/coachmark/CoachMarkContainer.kt (+246 -0)
➕ app/src/main/java/com/x8bit/bitwarden/ui/platform/components/coachmark/CoachMarkScope.kt (+126 -0)
➕ app/src/main/java/com/x8bit/bitwarden/ui/platform/components/coachmark/CoachMarkScopeInstance.kt (+307 -0)
➕ app/src/main/java/com/x8bit/bitwarden/ui/platform/components/coachmark/CoachMarkState.kt (+265 -0)
➕ app/src/main/java/com/x8bit/bitwarden/ui/platform/components/coachmark/LazyListCoachMarkState.kt (+175 -0)
➕ app/src/main/java/com/x8bit/bitwarden/ui/platform/components/coachmark/model/CoachMarkHighlightShape.kt (+16 -0)
➕ app/src/main/java/com/x8bit/bitwarden/ui/platform/components/coachmark/model/CoachMarkHighlightState.kt (+22 -0)
➕ app/src/main/java/com/x8bit/bitwarden/ui/platform/components/tooltip/BitwardenToolTip.kt (+75 -0)
➕ app/src/main/java/com/x8bit/bitwarden/ui/platform/components/tooltip/color/BitwardenToolTipColors.kt (+25 -0)
📝 app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/addedit/VaultAddEditItemContent.kt (+23 -2)
📝 app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/addedit/VaultAddEditLoginItems.kt (+103 -41)
📝 app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/addedit/VaultAddEditScreen.kt (+149 -100)
📝 app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/addedit/VaultAddEditViewModel.kt (+5 -0)
➕ app/src/main/res/drawable/ic_close_small.xml (+9 -0)
📝 app/src/main/res/values/strings.xml (+6 -0)
📝 app/src/test/java/com/x8bit/bitwarden/ui/util/ComposeTestHelpers.kt (+10 -0)
📝 app/src/test/java/com/x8bit/bitwarden/ui/vault/feature/addedit/VaultAddEditScreenTest.kt (+110 -0)

📄 Description

🎟️ Tracking

PM-16631
PM-16633
PM-16634

📔 Objective

  • Apply the CoachMarkContainer to the appropriate AddLoginItem content.
  • Add event to trigger showing the coach mark tour.
  • Some modifications to CoachMark* classes to better support Lazy items

📸 Screenshots

https://github.com/user-attachments/assets/d3c9b308-243e-45b2-96f6-fc1ac1333aeb

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed
    issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/4571 **Author:** [@dseverns-livefront](https://github.com/dseverns-livefront) **Created:** 1/15/2025 **Status:** ✅ Merged **Merged:** 1/21/2025 **Merged by:** [@dseverns-livefront](https://github.com/dseverns-livefront) **Base:** `main` ← **Head:** `PM-16631-add-coachmark-to-add-login` --- ### 📝 Commits (10+) - [`4c04cd9`](https://github.com/bitwarden/android/commit/4c04cd979597e6e896b588b50a711b4807606410) PM-16631 Adding coach mark container and state to allow for guided screen tours - [`ac4accc`](https://github.com/bitwarden/android/commit/ac4accc3753f26b26561a0436a547476bb5fe47c) PM-16631 Applying the CoachMarkContainer to the AddLoginItem content. - [`b5cc4af`](https://github.com/bitwarden/android/commit/b5cc4af6d5e76a7b5db831eb921f26ea71bde8b0) pollish - [`c463178`](https://github.com/bitwarden/android/commit/c46317802ae40b9be538242fb83e43f185850377) pr feedback - [`255d419`](https://github.com/bitwarden/android/commit/255d419d3a28b7ea79a83788d4e650e4f8992342) a name - [`63489f3`](https://github.com/bitwarden/android/commit/63489f3c910484fa63474bed9516159c594a900f) use theme shape for tooltip - [`11fc5c4`](https://github.com/bitwarden/android/commit/11fc5c49ae6ba5b7493749ee31ae9c953d06394e) Pr feedback - [`5bd70ce`](https://github.com/bitwarden/android/commit/5bd70cea5a5faf99b7dcd764bb9fd0e0a7e2572d) one mo thang - [`d062514`](https://github.com/bitwarden/android/commit/d0625144917c10905dd8f2110dca3f62666e3233) remove used of - [`c30b098`](https://github.com/bitwarden/android/commit/c30b09876ba0e2193750121ec0edc7135f940fa3) comment for clarity ### 📊 Changes **19 files changed** (+1752 additions, -147 deletions) <details> <summary>View changed files</summary> 📝 `app/src/main/java/com/x8bit/bitwarden/ui/platform/base/util/ModifierExtensions.kt` (+56 -4) ➕ `app/src/main/java/com/x8bit/bitwarden/ui/platform/components/coachmark/CoachMarkActionText.kt` (+24 -0) ➕ `app/src/main/java/com/x8bit/bitwarden/ui/platform/components/coachmark/CoachMarkContainer.kt` (+246 -0) ➕ `app/src/main/java/com/x8bit/bitwarden/ui/platform/components/coachmark/CoachMarkScope.kt` (+126 -0) ➕ `app/src/main/java/com/x8bit/bitwarden/ui/platform/components/coachmark/CoachMarkScopeInstance.kt` (+307 -0) ➕ `app/src/main/java/com/x8bit/bitwarden/ui/platform/components/coachmark/CoachMarkState.kt` (+265 -0) ➕ `app/src/main/java/com/x8bit/bitwarden/ui/platform/components/coachmark/LazyListCoachMarkState.kt` (+175 -0) ➕ `app/src/main/java/com/x8bit/bitwarden/ui/platform/components/coachmark/model/CoachMarkHighlightShape.kt` (+16 -0) ➕ `app/src/main/java/com/x8bit/bitwarden/ui/platform/components/coachmark/model/CoachMarkHighlightState.kt` (+22 -0) ➕ `app/src/main/java/com/x8bit/bitwarden/ui/platform/components/tooltip/BitwardenToolTip.kt` (+75 -0) ➕ `app/src/main/java/com/x8bit/bitwarden/ui/platform/components/tooltip/color/BitwardenToolTipColors.kt` (+25 -0) 📝 `app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/addedit/VaultAddEditItemContent.kt` (+23 -2) 📝 `app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/addedit/VaultAddEditLoginItems.kt` (+103 -41) 📝 `app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/addedit/VaultAddEditScreen.kt` (+149 -100) 📝 `app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/addedit/VaultAddEditViewModel.kt` (+5 -0) ➕ `app/src/main/res/drawable/ic_close_small.xml` (+9 -0) 📝 `app/src/main/res/values/strings.xml` (+6 -0) 📝 `app/src/test/java/com/x8bit/bitwarden/ui/util/ComposeTestHelpers.kt` (+10 -0) 📝 `app/src/test/java/com/x8bit/bitwarden/ui/vault/feature/addedit/VaultAddEditScreenTest.kt` (+110 -0) </details> ### 📄 Description ## 🎟️ Tracking [PM-16631](https://bitwarden.atlassian.net/browse/PM-16631) [PM-16633](https://bitwarden.atlassian.net/browse/PM-16633) [PM-16634](https://bitwarden.atlassian.net/browse/PM-16634) ## 📔 Objective - Apply the CoachMarkContainer to the appropriate AddLoginItem content. - Add event to trigger showing the coach mark tour. - Some modifications to CoachMark* classes to better support Lazy items <!-- Describe what the purpose of this PR is, for example what bug you're fixing or new feature you're adding. --> ## 📸 Screenshots https://github.com/user-attachments/assets/d3c9b308-243e-45b2-96f6-fc1ac1333aeb <!-- Required for any UI changes; delete if not applicable. Use fixed width images for better display. --> ## ⏰ Reminders before review - Contributor guidelines followed - All formatters and local linters executed and passed - Written new unit and / or integration tests where applicable - Used internationalization (i18n) for all UI strings - CI builds passed - Communicated to DevOps any deployment requirements - Updated any necessary documentation or informed the documentation team ## 🦮 Reviewer guidelines <!-- Suggested interactions but feel free to use (or not) as you desire! --> - 👍 (`:+1:`) or similar for great changes - 📝 (`:memo:`) or ℹ️ (`:information_source:`) for notes or general info - ❓ (`:question:`) for questions - 🤔 (`:thinking:`) or 💭 (`:thought_balloon:`) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion - 🎨 (`:art:`) for suggestions / improvements - ❌ (`:x:`) or ⚠️ (`:warning:`) for more significant problems or concerns needing attention - 🌱 (`:seedling:`) or ♻️ (`:recycle:`) for future improvements or indications of technical debt - ⛏ (`:pick:`) for minor or nitpick changes [PM-16631]: https://bitwarden.atlassian.net/browse/PM-16631?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ [PM-16633]: https://bitwarden.atlassian.net/browse/PM-16633?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ [PM-16634]: https://bitwarden.atlassian.net/browse/PM-16634?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-26 23:53:18 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#5047
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?