github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-05-07 00:09:31 -05:00
Code Issues 1.1k Packages Projects Releases 122 Wiki Activity

[PR #4608] [MERGED] [PM-17424] Implement KeyManager for handling private keys #53285

New Issue
Closed
opened 2026-05-01 17:58:28 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-05-01 17:58:28 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/4608
Author: @SaintPatrck
Created: 1/21/2025
Status: ✅ Merged
Merged: 1/24/2025
Merged by: @SaintPatrck

Base: main ← Head: PM-17424/store-mtls-key-alias-and-host

📝 Commits (1)

  • 7a4cff3 [PM-17424] Implement KeyManager for handling private keys

📊 Changes

7 files changed (+979 additions, -0 deletions)

View changed files

➕ app/src/main/java/com/x8bit/bitwarden/data/platform/datasource/disk/model/ImportPrivateKeyResult.kt (+45 -0)
➕ app/src/main/java/com/x8bit/bitwarden/data/platform/datasource/disk/model/MutualTlsCertificate.kt (+36 -0)
➕ app/src/main/java/com/x8bit/bitwarden/data/platform/datasource/disk/model/MutualTlsKeyHost.kt (+16 -0)
➕ app/src/main/java/com/x8bit/bitwarden/data/platform/manager/KeyManager.kt (+37 -0)
➕ app/src/main/java/com/x8bit/bitwarden/data/platform/manager/KeyManagerImpl.kt (+188 -0)
📝 app/src/main/java/com/x8bit/bitwarden/data/platform/manager/di/PlatformManagerModule.kt (+8 -0)
➕ app/src/test/java/com/x8bit/bitwarden/data/platform/manager/KeyManagerTest.kt (+649 -0)

📄 Description

🎟️ Tracking

PM-17424

Relates to #4606, #4486

📔 Objective

Implement a new manager, KeyManager, for managing key-related data.
This includes:

  • Importing a mutual TLS certificate into the AndroidKeyStore.
  • Removing a mutual TLS certificate from the AndroidKeyStore.
  • Retrieving a mutual TLS certificate from the AndroidKeyStore or system KeyChain.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed
    issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/4608 **Author:** [@SaintPatrck](https://github.com/SaintPatrck) **Created:** 1/21/2025 **Status:** ✅ Merged **Merged:** 1/24/2025 **Merged by:** [@SaintPatrck](https://github.com/SaintPatrck) **Base:** `main` ← **Head:** `PM-17424/store-mtls-key-alias-and-host` --- ### 📝 Commits (1) - [`7a4cff3`](https://github.com/bitwarden/android/commit/7a4cff389d25db9baf6022321276e7a7d7d49ee1) [PM-17424] Implement KeyManager for handling private keys ### 📊 Changes **7 files changed** (+979 additions, -0 deletions) <details> <summary>View changed files</summary> ➕ `app/src/main/java/com/x8bit/bitwarden/data/platform/datasource/disk/model/ImportPrivateKeyResult.kt` (+45 -0) ➕ `app/src/main/java/com/x8bit/bitwarden/data/platform/datasource/disk/model/MutualTlsCertificate.kt` (+36 -0) ➕ `app/src/main/java/com/x8bit/bitwarden/data/platform/datasource/disk/model/MutualTlsKeyHost.kt` (+16 -0) ➕ `app/src/main/java/com/x8bit/bitwarden/data/platform/manager/KeyManager.kt` (+37 -0) ➕ `app/src/main/java/com/x8bit/bitwarden/data/platform/manager/KeyManagerImpl.kt` (+188 -0) 📝 `app/src/main/java/com/x8bit/bitwarden/data/platform/manager/di/PlatformManagerModule.kt` (+8 -0) ➕ `app/src/test/java/com/x8bit/bitwarden/data/platform/manager/KeyManagerTest.kt` (+649 -0) </details> ### 📄 Description ## 🎟️ Tracking PM-17424 Relates to #4606, #4486 ## 📔 Objective Implement a new manager, `KeyManager`, for managing key-related data. This includes: - Importing a mutual TLS certificate into the AndroidKeyStore. - Removing a mutual TLS certificate from the AndroidKeyStore. - Retrieving a mutual TLS certificate from the AndroidKeyStore or system KeyChain. ## ⏰ Reminders before review - Contributor guidelines followed - All formatters and local linters executed and passed - Written new unit and / or integration tests where applicable - Used internationalization (i18n) for all UI strings - CI builds passed - Communicated to DevOps any deployment requirements - Updated any necessary documentation or informed the documentation team ## 🦮 Reviewer guidelines <!-- Suggested interactions but feel free to use (or not) as you desire! --> - 👍 (`:+1:`) or similar for great changes - 📝 (`:memo:`) or ℹ️ (`:information_source:`) for notes or general info - ❓ (`:question:`) for questions - 🤔 (`:thinking:`) or 💭 (`:thought_balloon:`) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion - 🎨 (`:art:`) for suggestions / improvements - ❌ (`:x:`) or ⚠️ (`:warning:`) for more significant problems or concerns needing attention - 🌱 (`:seedling:`) or ♻️ (`:recycle:`) for future improvements or indications of technical debt - ⛏ (`:pick:`) for minor or nitpick changes --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-05-01 17:58:28 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#53285
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?