github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-03-10 12:13:43 -05:00
Code Issues 144 Packages Projects Releases 116 Wiki Activity

[PR #4008] [MERGED] PM-12772 Add notification action card to security settings when applicable #4606

New Issue
Closed
opened 2025-11-26 23:47:12 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-26 23:47:12 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/4008
Author: @dseverns-livefront
Created: 10/1/2024
Status: ✅ Merged
Merged: 10/2/2024
Merged by: @dseverns-livefront

Base: main ← Head: PM-12772-action-card-security-screen

📝 Commits (5)

  • 0804695 PM-12772 Create new action card using BW Theme
  • 9197990 PM-12772 Add action card and dismiss actions to security settings screen
  • 4883e74 pr feedback fmt and 86 Material
  • bd7fd68 feedbackpt2
  • 16533c6 ol weight trick

📊 Changes

10 files changed (+406 additions, -63 deletions)

View changed files

📝 app/src/main/java/com/x8bit/bitwarden/ui/auth/feature/completeregistration/CompleteRegistrationScreen.kt (+2 -2)
📝 app/src/main/java/com/x8bit/bitwarden/ui/auth/feature/masterpasswordguidance/MasterPasswordGuidanceScreen.kt (+2 -2)
📝 app/src/main/java/com/x8bit/bitwarden/ui/platform/components/card/BitwardenActionCard.kt (+63 -57)
➕ app/src/main/java/com/x8bit/bitwarden/ui/platform/components/card/BitwardenActionCardSmall.kt (+119 -0)
📝 app/src/main/java/com/x8bit/bitwarden/ui/platform/feature/settings/SettingsViewModel.kt (+2 -2)
📝 app/src/main/java/com/x8bit/bitwarden/ui/platform/feature/settings/accountsecurity/AccountSecurityScreen.kt (+34 -0)
📝 app/src/main/java/com/x8bit/bitwarden/ui/platform/feature/settings/accountsecurity/AccountSecurityViewModel.kt (+60 -0)
📝 app/src/main/res/values/strings.xml (+1 -0)
📝 app/src/test/java/com/x8bit/bitwarden/ui/platform/feature/settings/accountsecurity/AccountSecurityScreenTest.kt (+37 -0)
📝 app/src/test/java/com/x8bit/bitwarden/ui/platform/feature/settings/accountsecurity/AccountSecurityViewModelTest.kt (+86 -0)

📄 Description

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-12772

📔 Objective

  • Show new card on settings sub screen when there is a notification badge to show

📸 Screenshots

https://github.com/user-attachments/assets/d2096699-a3ea-4660-be18-5e559baf3198

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed
    issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/4008 **Author:** [@dseverns-livefront](https://github.com/dseverns-livefront) **Created:** 10/1/2024 **Status:** ✅ Merged **Merged:** 10/2/2024 **Merged by:** [@dseverns-livefront](https://github.com/dseverns-livefront) **Base:** `main` ← **Head:** `PM-12772-action-card-security-screen` --- ### 📝 Commits (5) - [`0804695`](https://github.com/bitwarden/android/commit/0804695a7580900352754f28e33f25ad48fb4de5) PM-12772 Create new action card using BW Theme - [`9197990`](https://github.com/bitwarden/android/commit/9197990545388d15b1fc4d6ff9bce3e219ff2857) PM-12772 Add action card and dismiss actions to security settings screen - [`4883e74`](https://github.com/bitwarden/android/commit/4883e743e79759277c39881488e484bc4bce9c4d) pr feedback fmt and 86 Material - [`bd7fd68`](https://github.com/bitwarden/android/commit/bd7fd6836b9ad2a6793e936a2be233eb66274d88) feedbackpt2 - [`16533c6`](https://github.com/bitwarden/android/commit/16533c6ee999abeca2fab51888298eee75699725) ol weight trick ### 📊 Changes **10 files changed** (+406 additions, -63 deletions) <details> <summary>View changed files</summary> 📝 `app/src/main/java/com/x8bit/bitwarden/ui/auth/feature/completeregistration/CompleteRegistrationScreen.kt` (+2 -2) 📝 `app/src/main/java/com/x8bit/bitwarden/ui/auth/feature/masterpasswordguidance/MasterPasswordGuidanceScreen.kt` (+2 -2) 📝 `app/src/main/java/com/x8bit/bitwarden/ui/platform/components/card/BitwardenActionCard.kt` (+63 -57) ➕ `app/src/main/java/com/x8bit/bitwarden/ui/platform/components/card/BitwardenActionCardSmall.kt` (+119 -0) 📝 `app/src/main/java/com/x8bit/bitwarden/ui/platform/feature/settings/SettingsViewModel.kt` (+2 -2) 📝 `app/src/main/java/com/x8bit/bitwarden/ui/platform/feature/settings/accountsecurity/AccountSecurityScreen.kt` (+34 -0) 📝 `app/src/main/java/com/x8bit/bitwarden/ui/platform/feature/settings/accountsecurity/AccountSecurityViewModel.kt` (+60 -0) 📝 `app/src/main/res/values/strings.xml` (+1 -0) 📝 `app/src/test/java/com/x8bit/bitwarden/ui/platform/feature/settings/accountsecurity/AccountSecurityScreenTest.kt` (+37 -0) 📝 `app/src/test/java/com/x8bit/bitwarden/ui/platform/feature/settings/accountsecurity/AccountSecurityViewModelTest.kt` (+86 -0) </details> ### 📄 Description ## 🎟️ Tracking https://bitwarden.atlassian.net/browse/PM-12772 <!-- Paste the link to the Jira or GitHub issue or otherwise describe / point to where this change is coming from. --> ## 📔 Objective - Show new card on settings sub screen when there is a notification badge to show <!-- Describe what the purpose of this PR is, for example what bug you're fixing or new feature you're adding. --> ## 📸 Screenshots https://github.com/user-attachments/assets/d2096699-a3ea-4660-be18-5e559baf3198 <!-- Required for any UI changes; delete if not applicable. Use fixed width images for better display. --> ## ⏰ Reminders before review - Contributor guidelines followed - All formatters and local linters executed and passed - Written new unit and / or integration tests where applicable - Used internationalization (i18n) for all UI strings - CI builds passed - Communicated to DevOps any deployment requirements - Updated any necessary documentation or informed the documentation team ## 🦮 Reviewer guidelines <!-- Suggested interactions but feel free to use (or not) as you desire! --> - 👍 (`:+1:`) or similar for great changes - 📝 (`:memo:`) or ℹ️ (`:information_source:`) for notes or general info - ❓ (`:question:`) for questions - 🤔 (`:thinking:`) or 💭 (`:thought_balloon:`) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion - 🎨 (`:art:`) for suggestions / improvements - ❌ (`:x:`) or ⚠️ (`:warning:`) for more significant problems or concerns needing attention - 🌱 (`:seedling:`) or ♻️ (`:recycle:`) for future improvements or indications of technical debt - ⛏ (`:pick:`) for minor or nitpick changes --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-26 23:47:12 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#4606
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?