[PR #4928] [MERGED] [PM-19616] Move OmitFromCoverage annotation to core module #5322

New Issue

GiteaMirror · 2025-11-26T23:57:55-06:00

GiteaMirror commented

2025-11-26 23:57:55 -06:00

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/4928
Author: @SaintPatrck
Created: 3/27/2025
Status: ✅ Merged
Merged: 3/27/2025
Merged by: @SaintPatrck

Base: main ← Head: platform-module/omit-from-coverage-annotation

📝 Commits (1)

074f0aa Move OmitFromCoverage annotation to core module

📊 Changes

92 files changed (+95 additions, -104 deletions)

View changed files

📝 app/build.gradle.kts (+3 -1)
📝 app/src/main/java/com/x8bit/bitwarden/AccessibilityActivity.kt (+1 -1)
📝 app/src/main/java/com/x8bit/bitwarden/AuthCallbackActivity.kt (+1 -1)
📝 app/src/main/java/com/x8bit/bitwarden/AutofillTotpCopyActivity.kt (+1 -1)
📝 app/src/main/java/com/x8bit/bitwarden/BitwardenAppComponentFactory.kt (+1 -1)
📝 app/src/main/java/com/x8bit/bitwarden/BitwardenApplication.kt (+1 -1)
📝 app/src/main/java/com/x8bit/bitwarden/MainActivity.kt (+1 -1)
📝 app/src/main/java/com/x8bit/bitwarden/data/auth/manager/AuthRequestNotificationManagerImpl.kt (+1 -1)
📝 app/src/main/java/com/x8bit/bitwarden/data/auth/util/KdfParamsConstants.kt (+1 -1)
📝 app/src/main/java/com/x8bit/bitwarden/data/autofill/BitwardenAutofillService.kt (+1 -1)
📝 app/src/main/java/com/x8bit/bitwarden/data/autofill/accessibility/BitwardenAccessibilityService.kt (+1 -1)
📝 app/src/main/java/com/x8bit/bitwarden/data/autofill/accessibility/util/AccessibilityNodeInfoExtensions.kt (+1 -1)
📝 app/src/main/java/com/x8bit/bitwarden/data/autofill/accessibility/util/UriExtensions.kt (+1 -1)
📝 app/src/main/java/com/x8bit/bitwarden/data/autofill/fido2/BitwardenFido2ProviderService.kt (+1 -1)
📝 app/src/main/java/com/x8bit/bitwarden/data/autofill/manager/chrome/ChromeThirdPartyAutofillManagerImpl.kt (+1 -1)
📝 app/src/main/java/com/x8bit/bitwarden/data/autofill/util/ActivityExtensions.kt (+1 -1)
📝 app/src/main/java/com/x8bit/bitwarden/data/autofill/util/AutofillIntentUtils.kt (+1 -1)
📝 app/src/main/java/com/x8bit/bitwarden/data/autofill/util/HtmlInfoExtensions.kt (+1 -1)
📝 app/src/main/java/com/x8bit/bitwarden/data/autofill/util/IntExtensions.kt (+1 -1)
📝 app/src/main/java/com/x8bit/bitwarden/data/platform/datasource/disk/legacy/LegacySecureStorageImpl.kt (+1 -1)

...and 72 more files

📄 Description

🎟️ Tracking

PM-19616

📔 Objective

Move the OmitFromCoverage annotation to the core module.

Updated the authenticator & app module's dependencies to include the core module.
Updated the JaCoCo configurations to use the new OmitFromCoverage annotation location.
Removed the previous OmitFromCoverage annotation files.

⏰ Reminders before review

Contributor guidelines followed
All formatters and local linters executed and passed
Written new unit and / or integration tests where applicable
Protected functional changes with optionality (feature flags)
Used internationalization (i18n) for all UI strings
CI builds passed
Communicated to DevOps any deployment requirements
Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

👍 (:+1:) or similar for great changes
📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
❓ (:question:) for questions
🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
🎨 (:art:) for suggestions / improvements
❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
⛏ (:pick:) for minor or nitpick changes

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/4928 **Author:** [@SaintPatrck](https://github.com/SaintPatrck) **Created:** 3/27/2025 **Status:** ✅ Merged **Merged:** 3/27/2025 **Merged by:** [@SaintPatrck](https://github.com/SaintPatrck) **Base:** `main` ← **Head:** `platform-module/omit-from-coverage-annotation` --- ### 📝 Commits (1) - [`074f0aa`](https://github.com/bitwarden/android/commit/074f0aa62458d1ded79aa3df3093ef34abc8059f) Move OmitFromCoverage annotation to core module ### 📊 Changes **92 files changed** (+95 additions, -104 deletions) <details> <summary>View changed files</summary> 📝 `app/build.gradle.kts` (+3 -1) 📝 `app/src/main/java/com/x8bit/bitwarden/AccessibilityActivity.kt` (+1 -1) 📝 `app/src/main/java/com/x8bit/bitwarden/AuthCallbackActivity.kt` (+1 -1) 📝 `app/src/main/java/com/x8bit/bitwarden/AutofillTotpCopyActivity.kt` (+1 -1) 📝 `app/src/main/java/com/x8bit/bitwarden/BitwardenAppComponentFactory.kt` (+1 -1) 📝 `app/src/main/java/com/x8bit/bitwarden/BitwardenApplication.kt` (+1 -1) 📝 `app/src/main/java/com/x8bit/bitwarden/MainActivity.kt` (+1 -1) 📝 `app/src/main/java/com/x8bit/bitwarden/data/auth/manager/AuthRequestNotificationManagerImpl.kt` (+1 -1) 📝 `app/src/main/java/com/x8bit/bitwarden/data/auth/util/KdfParamsConstants.kt` (+1 -1) 📝 `app/src/main/java/com/x8bit/bitwarden/data/autofill/BitwardenAutofillService.kt` (+1 -1) 📝 `app/src/main/java/com/x8bit/bitwarden/data/autofill/accessibility/BitwardenAccessibilityService.kt` (+1 -1) 📝 `app/src/main/java/com/x8bit/bitwarden/data/autofill/accessibility/util/AccessibilityNodeInfoExtensions.kt` (+1 -1) 📝 `app/src/main/java/com/x8bit/bitwarden/data/autofill/accessibility/util/UriExtensions.kt` (+1 -1) 📝 `app/src/main/java/com/x8bit/bitwarden/data/autofill/fido2/BitwardenFido2ProviderService.kt` (+1 -1) 📝 `app/src/main/java/com/x8bit/bitwarden/data/autofill/manager/chrome/ChromeThirdPartyAutofillManagerImpl.kt` (+1 -1) 📝 `app/src/main/java/com/x8bit/bitwarden/data/autofill/util/ActivityExtensions.kt` (+1 -1) 📝 `app/src/main/java/com/x8bit/bitwarden/data/autofill/util/AutofillIntentUtils.kt` (+1 -1) 📝 `app/src/main/java/com/x8bit/bitwarden/data/autofill/util/HtmlInfoExtensions.kt` (+1 -1) 📝 `app/src/main/java/com/x8bit/bitwarden/data/autofill/util/IntExtensions.kt` (+1 -1) 📝 `app/src/main/java/com/x8bit/bitwarden/data/platform/datasource/disk/legacy/LegacySecureStorageImpl.kt` (+1 -1) _...and 72 more files_ </details> ### 📄 Description ## 🎟️ Tracking PM-19616 ## 📔 Objective Move the `OmitFromCoverage` annotation to the `core` module. - Updated the `authenticator` & `app` module's dependencies to include the `core` module. - Updated the JaCoCo configurations to use the new `OmitFromCoverage` annotation location. - Removed the previous `OmitFromCoverage` annotation files. ## ⏰ Reminders before review - Contributor guidelines followed - All formatters and local linters executed and passed - Written new unit and / or integration tests where applicable - Protected functional changes with optionality (feature flags) - Used internationalization (i18n) for all UI strings - CI builds passed - Communicated to DevOps any deployment requirements - Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team ## 🦮 Reviewer guidelines  - 👍 (`:+1:`) or similar for great changes - 📝 (`:memo:`) or ℹ️ (`:information_source:`) for notes or general info - ❓ (`:question:`) for questions - 🤔 (`:thinking:`) or 💭 (`:thought_balloon:`) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion - 🎨 (`:art:`) for suggestions / improvements - ❌ (`:x:`) or ⚠️ (`:warning:`) for more significant problems or concerns needing attention - 🌱 (`:seedling:`) or ♻️ (`:recycle:`) for future improvements or indications of technical debt - ⛏ (`:pick:`) for minor or nitpick changes --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

GiteaMirror added the pull-request label 2025-11-26 23:57:55 -06:00

GiteaMirror closed this issue