github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-03-12 05:04:17 -05:00
Code Issues 144 Packages Projects Releases 116 Wiki Activity

[PR #4926] [MERGED] Update the README dependencies section and clean up toml file #5320

New Issue
Closed
opened 2025-11-26 23:57:53 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-26 23:57:53 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/4926
Author: @david-livefront
Created: 3/27/2025
Status: ✅ Merged
Merged: 3/27/2025
Merged by: @david-livefront

Base: main ← Head: update-readme-dependnecies

📝 Commits (1)

  • 84fab52 Update the README dependencies section and clean up toml file

📊 Changes

3 files changed (+30 additions, -40 deletions)

View changed files

📝 README.md (+30 -28)
📝 app/build.gradle.kts (+0 -1)
📝 gradle/libs.versions.toml (+0 -11)

📄 Description

🎟️ Tracking

N/A

📔 Objective

This PR updates the apps Readme to ensure that the dependencies section is fully up-to-date and removes any dependencies from the toml file that are not in use.

  • We are removing several unused dependencies from the toml file (mock-android, fastlane-screengrab, androidx-test-runner, androidx-test-rules, androidx-test-espresso).
  • We are removing the zxcvbn4j dependency as it is incorporated directly inside the SDK.
  • We will assume kotlinx.serialization converter is implied by the inclusion of Retrofit and link to the Retrofit repo.
  • We’re specifically calling out Activity and Navigation since those should have been in the list.
  • We’re collapsing AndroidX Core SplashScreen down to AndroidX Core to imply anything from the overall Core dependency can be included.
  • We’re collapsing AndroidX CameraX Camera down to AndroidX Camera to imply anything from the overall Camera dependency can be included.
  • We’re splitting out the dependencies that will not appear in the F-Droid builds.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/4926 **Author:** [@david-livefront](https://github.com/david-livefront) **Created:** 3/27/2025 **Status:** ✅ Merged **Merged:** 3/27/2025 **Merged by:** [@david-livefront](https://github.com/david-livefront) **Base:** `main` ← **Head:** `update-readme-dependnecies` --- ### 📝 Commits (1) - [`84fab52`](https://github.com/bitwarden/android/commit/84fab52558d4d4e8e1a264732a3aedd8ca6edf4c) Update the README dependencies section and clean up toml file ### 📊 Changes **3 files changed** (+30 additions, -40 deletions) <details> <summary>View changed files</summary> 📝 `README.md` (+30 -28) 📝 `app/build.gradle.kts` (+0 -1) 📝 `gradle/libs.versions.toml` (+0 -11) </details> ### 📄 Description ## 🎟️ Tracking N/A ## 📔 Objective This PR updates the apps Readme to ensure that the dependencies section is fully up-to-date and removes any dependencies from the toml file that are not in use. * We are removing several unused dependencies from the toml file (mock-android, fastlane-screengrab, androidx-test-runner, androidx-test-rules, androidx-test-espresso). * We are removing the zxcvbn4j dependency as it is incorporated directly inside the SDK. * We will assume kotlinx.serialization converter is implied by the inclusion of Retrofit and link to the Retrofit repo. * We’re specifically calling out Activity and Navigation since those should have been in the list. * We’re collapsing AndroidX Core SplashScreen down to AndroidX Core to imply anything from the overall Core dependency can be included. * We’re collapsing AndroidX CameraX Camera down to AndroidX Camera to imply anything from the overall Camera dependency can be included. * We’re splitting out the dependencies that will not appear in the F-Droid builds. ## ⏰ Reminders before review - Contributor guidelines followed - All formatters and local linters executed and passed - Written new unit and / or integration tests where applicable - Protected functional changes with optionality (feature flags) - Used internationalization (i18n) for all UI strings - CI builds passed - Communicated to DevOps any deployment requirements - Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team ## 🦮 Reviewer guidelines <!-- Suggested interactions but feel free to use (or not) as you desire! --> - 👍 (`:+1:`) or similar for great changes - 📝 (`:memo:`) or ℹ️ (`:information_source:`) for notes or general info - ❓ (`:question:`) for questions - 🤔 (`:thinking:`) or 💭 (`:thought_balloon:`) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion - 🎨 (`:art:`) for suggestions / improvements - ❌ (`:x:`) or ⚠️ (`:warning:`) for more significant problems or concerns needing attention - 🌱 (`:seedling:`) or ♻️ (`:recycle:`) for future improvements or indications of technical debt - ⛏ (`:pick:`) for minor or nitpick changes --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-26 23:57:53 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#5320
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?