github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-03-13 21:54:17 -05:00
Code Issues 144 Packages Projects Releases 116 Wiki Activity

[PR #4409] [MERGED] [PM-11139] Setting icon on passkeys #4926

New Issue
Closed
opened 2025-11-26 23:51:37 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-26 23:51:37 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/4409
Author: @aj-rosado
Created: 12/3/2024
Status: ✅ Merged
Merged: 12/9/2024
Merged by: @aj-rosado

Base: main ← Head: PM-11139-passkey-credential-bw-icon

📝 Commits (6)

  • 551dc1f Setting ic_bw_passkey as the icon on passkeys
  • a64c043 added missing newline and trailing comma
  • 8ce0854 Merge branch 'main' into PM-11139-passkey-credential-bw-icon
  • 19aec95 Fixed Fido2ProviderProcessorTest
  • 7371926 Fixed Fido2CompletionManagerTest
  • 48b4ae8 setting mockk on setup and teardown Fido2ProdiverProcessorTest and Fido2CompletionManagerTest

📊 Changes

4 files changed (+33 additions, -0 deletions)

View changed files

📝 app/src/main/java/com/x8bit/bitwarden/data/autofill/fido2/processor/Fido2ProviderProcessorImpl.kt (+8 -0)
📝 app/src/main/java/com/x8bit/bitwarden/ui/autofill/fido2/manager/Fido2CompletionManagerImpl.kt (+8 -0)
📝 app/src/test/java/com/x8bit/bitwarden/data/autofill/fido2/processor/Fido2ProviderProcessorTest.kt (+12 -0)
📝 app/src/test/java/com/x8bit/bitwarden/ui/autofill/fido2/manager/Fido2CompletionManagerTest.kt (+5 -0)

📄 Description

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-11139

📔 Objective

Setting ic_bw_passkey as the passkey icon

📸 Screenshots

Screenshot_1733225459

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed
    issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/4409 **Author:** [@aj-rosado](https://github.com/aj-rosado) **Created:** 12/3/2024 **Status:** ✅ Merged **Merged:** 12/9/2024 **Merged by:** [@aj-rosado](https://github.com/aj-rosado) **Base:** `main` ← **Head:** `PM-11139-passkey-credential-bw-icon` --- ### 📝 Commits (6) - [`551dc1f`](https://github.com/bitwarden/android/commit/551dc1f29b5e552514c8688497e8c8d8d7431a9d) Setting ic_bw_passkey as the icon on passkeys - [`a64c043`](https://github.com/bitwarden/android/commit/a64c043eaac9bd0acf83150084037e17c6db0f3f) added missing newline and trailing comma - [`8ce0854`](https://github.com/bitwarden/android/commit/8ce08540f1ef2ca00f4eba4c9769ca4ba23077b6) Merge branch 'main' into PM-11139-passkey-credential-bw-icon - [`19aec95`](https://github.com/bitwarden/android/commit/19aec951ad2e436296544dfd0474e2235366c66b) Fixed Fido2ProviderProcessorTest - [`7371926`](https://github.com/bitwarden/android/commit/737192667a3da9fbe30fc35bc0540d724f65eb21) Fixed Fido2CompletionManagerTest - [`48b4ae8`](https://github.com/bitwarden/android/commit/48b4ae87dbb04c2faf8fe44862fc7e5bb630ca88) setting mockk on setup and teardown Fido2ProdiverProcessorTest and Fido2CompletionManagerTest ### 📊 Changes **4 files changed** (+33 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `app/src/main/java/com/x8bit/bitwarden/data/autofill/fido2/processor/Fido2ProviderProcessorImpl.kt` (+8 -0) 📝 `app/src/main/java/com/x8bit/bitwarden/ui/autofill/fido2/manager/Fido2CompletionManagerImpl.kt` (+8 -0) 📝 `app/src/test/java/com/x8bit/bitwarden/data/autofill/fido2/processor/Fido2ProviderProcessorTest.kt` (+12 -0) 📝 `app/src/test/java/com/x8bit/bitwarden/ui/autofill/fido2/manager/Fido2CompletionManagerTest.kt` (+5 -0) </details> ### 📄 Description ## 🎟️ Tracking https://bitwarden.atlassian.net/browse/PM-11139 ## 📔 Objective Setting `ic_bw_passkey` as the passkey icon ## 📸 Screenshots ![Screenshot_1733225459](https://github.com/user-attachments/assets/5549724f-b4d0-4c28-b9d5-310f2a329477) ## ⏰ Reminders before review - Contributor guidelines followed - All formatters and local linters executed and passed - Written new unit and / or integration tests where applicable - Used internationalization (i18n) for all UI strings - CI builds passed - Communicated to DevOps any deployment requirements - Updated any necessary documentation or informed the documentation team ## 🦮 Reviewer guidelines <!-- Suggested interactions but feel free to use (or not) as you desire! --> - 👍 (`:+1:`) or similar for great changes - 📝 (`:memo:`) or ℹ️ (`:information_source:`) for notes or general info - ❓ (`:question:`) for questions - 🤔 (`:thinking:`) or 💭 (`:thought_balloon:`) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion - 🎨 (`:art:`) for suggestions / improvements - ❌ (`:x:`) or ⚠️ (`:warning:`) for more significant problems or concerns needing attention - 🌱 (`:seedling:`) or ♻️ (`:recycle:`) for future improvements or indications of technical debt - ⛏ (`:pick:`) for minor or nitpick changes --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-26 23:51:37 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#4926
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?