github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-03-14 06:04:20 -05:00
Code Issues 144 Packages Projects Releases 116 Wiki Activity

[PR #4863] [MERGED] PM-18681 - Update Showing Coach Mark Tour Logic To Only Consider User's Personal Vault #5266

New Issue
Closed
opened 2025-11-26 23:56:42 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-26 23:56:42 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/4863
Author: @phil-livefront
Created: 3/13/2025
Status: ✅ Merged
Merged: 3/13/2025
Merged by: @phil-livefront

Base: main ← Head: phil/PM-18681-Update-Showing-Coach-Mark-Tour-Logic-To-Only-Consider-User's-Personal-Vault

📝 Commits (4)

  • c402892 PM-18681 - Update Showing Coach Mark Tour Logic To Only Consider User's Personal Vault
  • 0c0be94 PM-18681 - add logic to handle org only policy users seeing the coachmarks
  • 18bb87f fix lint errors
  • c7753d5 revert previous change associated with org only policy

📊 Changes

2 files changed (+4 additions, -72 deletions)

View changed files

📝 app/src/main/java/com/x8bit/bitwarden/data/platform/manager/FirstTimeActionManagerImpl.kt (+4 -9)
📝 app/src/test/java/com/x8bit/bitwarden/data/platform/manager/FirstTimeActionManagerTest.kt (+0 -63)

📄 Description

🎟️ Tracking

PM-18681

📔 Objective

  • Revert the logical changes from PR #4854. The previous test results were misleading due to personal items being present in the test account for testing out org only policies. The “Confirm that a user in an organization who has access to org items but has no individual vault due to org policy does see the Tours” use case was producing a false positive because of this.
  • The org-only change caused issues with another use case. However, after reverting to the original implementation and testing with valid accounts, all tests passed successfully.

📸 Screenshots

https://github.com/user-attachments/assets/fa0c1e0f-4ce6-444f-b6b7-cafc6ee75bff

  • First account has a personal login item and does not see the tours
  • Second account is an org only account, with no personal items, and does see the tours

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/4863 **Author:** [@phil-livefront](https://github.com/phil-livefront) **Created:** 3/13/2025 **Status:** ✅ Merged **Merged:** 3/13/2025 **Merged by:** [@phil-livefront](https://github.com/phil-livefront) **Base:** `main` ← **Head:** `phil/PM-18681-Update-Showing-Coach-Mark-Tour-Logic-To-Only-Consider-User's-Personal-Vault` --- ### 📝 Commits (4) - [`c402892`](https://github.com/bitwarden/android/commit/c402892eb793d4a7b3cd1119643326b2da26d887) PM-18681 - Update Showing Coach Mark Tour Logic To Only Consider User's Personal Vault - [`0c0be94`](https://github.com/bitwarden/android/commit/0c0be94327e40c99233d53c3a6b073822cc069ae) PM-18681 - add logic to handle org only policy users seeing the coachmarks - [`18bb87f`](https://github.com/bitwarden/android/commit/18bb87f21e0b9e1995e12a9dfc9c2d0fd4717731) fix lint errors - [`c7753d5`](https://github.com/bitwarden/android/commit/c7753d5c0c5e327a0d2c915f627cee235aecec14) revert previous change associated with org only policy ### 📊 Changes **2 files changed** (+4 additions, -72 deletions) <details> <summary>View changed files</summary> 📝 `app/src/main/java/com/x8bit/bitwarden/data/platform/manager/FirstTimeActionManagerImpl.kt` (+4 -9) 📝 `app/src/test/java/com/x8bit/bitwarden/data/platform/manager/FirstTimeActionManagerTest.kt` (+0 -63) </details> ### 📄 Description ## 🎟️ Tracking [PM-18681](https://bitwarden.atlassian.net/browse/PM-18681) ## 📔 Objective - Revert the logical changes from [PR #4854](https://github.com/bitwarden/android/pull/4854). The previous test results were misleading due to personal items being present in the test account for testing out org only policies. The “_Confirm that a user in an organization who has access to org items but has no individual vault due to org policy does see the Tours_” use case was producing a false positive because of this. - The org-only change caused issues with another use case. However, after reverting to the original implementation and testing with valid accounts, all tests passed successfully. ## 📸 Screenshots https://github.com/user-attachments/assets/fa0c1e0f-4ce6-444f-b6b7-cafc6ee75bff - First account has a personal login item and does not see the tours - Second account is an org only account, with no personal items, and does see the tours ## ⏰ Reminders before review - Contributor guidelines followed - All formatters and local linters executed and passed - Written new unit and / or integration tests where applicable - Protected functional changes with optionality (feature flags) - Used internationalization (i18n) for all UI strings - CI builds passed - Communicated to DevOps any deployment requirements - Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team ## 🦮 Reviewer guidelines <!-- Suggested interactions but feel free to use (or not) as you desire! --> - 👍 (`:+1:`) or similar for great changes - 📝 (`:memo:`) or ℹ️ (`:information_source:`) for notes or general info - ❓ (`:question:`) for questions - 🤔 (`:thinking:`) or 💭 (`:thought_balloon:`) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion - 🎨 (`:art:`) for suggestions / improvements - ❌ (`:x:`) or ⚠️ (`:warning:`) for more significant problems or concerns needing attention - 🌱 (`:seedling:`) or ♻️ (`:recycle:`) for future improvements or indications of technical debt - ⛏ (`:pick:`) for minor or nitpick changes [PM-18681]: https://bitwarden.atlassian.net/browse/PM-18681?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-26 23:56:42 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#5266
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?