github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-03-14 14:16:23 -05:00
Code Issues 144 Packages Projects Releases 116 Wiki Activity

[PR #4325] [MERGED] PM-12761 Talkback UI Focus misalignment bug. #4863

New Issue
Closed
opened 2025-11-26 23:50:47 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-26 23:50:47 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/4325
Author: @dseverns-livefront
Created: 11/18/2024
Status: ✅ Merged
Merged: 11/18/2024
Merged by: @dseverns-livefront

Base: main ← Head: PM-12761-carousel-talkback

📝 Commits (2)

  • 7faa171 PM-12761 remove indicator interaction semantics and improve page accessibility info
  • ab6db6a fmt

📊 Changes

2 files changed (+17 additions, -4 deletions)

View changed files

📝 app/src/main/java/com/x8bit/bitwarden/ui/auth/feature/welcome/WelcomeScreen.kt (+16 -4)
📝 app/src/main/res/values/strings.xml (+1 -0)

📄 Description

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-12761

📔 Objective

  • The focus/touch targets for the visual page indicator rows were misaligned. This was due to the their size + spacing being smaller than the minimum touch target implicitly applied.
  • After talking with design the conclusion was to remove the touch target from accessibility as it is meant to be a visual indicator and not a primary navigation component for the pager content.
  • Improve the existing accessibility on the pager content so its more indicative what page the user with a screen reader is on.

📸 Screenshots

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed
    issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/4325 **Author:** [@dseverns-livefront](https://github.com/dseverns-livefront) **Created:** 11/18/2024 **Status:** ✅ Merged **Merged:** 11/18/2024 **Merged by:** [@dseverns-livefront](https://github.com/dseverns-livefront) **Base:** `main` ← **Head:** `PM-12761-carousel-talkback` --- ### 📝 Commits (2) - [`7faa171`](https://github.com/bitwarden/android/commit/7faa1714608916a0ce0d78a2ec1626d039442c00) PM-12761 remove indicator interaction semantics and improve page accessibility info - [`ab6db6a`](https://github.com/bitwarden/android/commit/ab6db6aeec1c35ca820bd7066b053bee3d679a1b) fmt ### 📊 Changes **2 files changed** (+17 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `app/src/main/java/com/x8bit/bitwarden/ui/auth/feature/welcome/WelcomeScreen.kt` (+16 -4) 📝 `app/src/main/res/values/strings.xml` (+1 -0) </details> ### 📄 Description ## 🎟️ Tracking https://bitwarden.atlassian.net/browse/PM-12761 <!-- Paste the link to the Jira or GitHub issue or otherwise describe / point to where this change is coming from. --> ## 📔 Objective - The focus/touch targets for the visual page indicator rows were misaligned. This was due to the their size + spacing being smaller than the minimum touch target implicitly applied. - After talking with design the conclusion was to remove the touch target from accessibility as it is meant to be a visual indicator and not a primary navigation component for the pager content. - Improve the existing accessibility on the pager content so its more indicative what page the user with a screen reader is on. <!-- Describe what the purpose of this PR is, for example what bug you're fixing or new feature you're adding. --> ## 📸 Screenshots <!-- Required for any UI changes; delete if not applicable. Use fixed width images for better display. --> ## ⏰ Reminders before review - Contributor guidelines followed - All formatters and local linters executed and passed - Written new unit and / or integration tests where applicable - Used internationalization (i18n) for all UI strings - CI builds passed - Communicated to DevOps any deployment requirements - Updated any necessary documentation or informed the documentation team ## 🦮 Reviewer guidelines <!-- Suggested interactions but feel free to use (or not) as you desire! --> - 👍 (`:+1:`) or similar for great changes - 📝 (`:memo:`) or ℹ️ (`:information_source:`) for notes or general info - ❓ (`:question:`) for questions - 🤔 (`:thinking:`) or 💭 (`:thought_balloon:`) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion - 🎨 (`:art:`) for suggestions / improvements - ❌ (`:x:`) or ⚠️ (`:warning:`) for more significant problems or concerns needing attention - 🌱 (`:seedling:`) or ♻️ (`:recycle:`) for future improvements or indications of technical debt - ⛏ (`:pick:`) for minor or nitpick changes --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-26 23:50:47 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#4863
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?