github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-08-20 11:56:31 -05:00
Code Issues 2.4k Packages Projects Releases 129 Wiki Activity

[PR #3294] [MERGED] Fix release #52353

New Issue
Closed
opened 2026-05-01 16:19:43 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-05-01 16:19:43 -05:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/3294
Author: @michalchecinski
Created: 6/13/2024
Status: ✅ Merged
Merged: 6/13/2024
Merged by: @michalchecinski

Base: main ← Head: fix-release

📝 Commits (9)

📊 Changes

1 file changed (+9 additions, -2 deletions)

View changed files

📝 .github/workflows/release.yml (+9 -2)

📄 Description

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

bitwarden/gh-actions/download-artifacts doesn't unpack artifacts into subfolders. Because of it, the Prep Bitwarden iOS release asset step couldn't find the folder to zip. As a solution, I set the bitwarden/gh-actions/download-artifacts to skip unpacking artifacts, and unzipped them individually.

Code changes

  • .github/workflows/release.yml: Skip unpack afrifacts automatically after download. Unzip artifacts individually instead.

Screenshots

Before you submit

  • Please check for formatting errors (dotnet format --verify-no-changes) (required)
  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/3294 **Author:** [@michalchecinski](https://github.com/michalchecinski) **Created:** 6/13/2024 **Status:** ✅ Merged **Merged:** 6/13/2024 **Merged by:** [@michalchecinski](https://github.com/michalchecinski) **Base:** `main` ← **Head:** `fix-release` --- ### 📝 Commits (9) - [`ca8de5f`](https://github.com/bitwarden/android/commit/ca8de5ff2d1572799e6648b3c95124afec15bcf1) Add ls to release - [`cb1e1a8`](https://github.com/bitwarden/android/commit/cb1e1a843e01c0449c978753df5d2610b0f61e57) Unzip manually - [`5175920`](https://github.com/bitwarden/android/commit/5175920b4fe4bf47321203cd27d1e84dd16e62f9) FIx - [`142a670`](https://github.com/bitwarden/android/commit/142a670d2b618b90d42444aa0c706fc19387775a) Fix - [`5aa6500`](https://github.com/bitwarden/android/commit/5aa650034056da41aff9fc64fd18c425b33a6373) echo - [`617793f`](https://github.com/bitwarden/android/commit/617793faa205c775515f313e856ade4ec53be2e3) echo 2 - [`e8471b0`](https://github.com/bitwarden/android/commit/e8471b06521ed0258ac1d3e85fdd7eab71cf7af5) Fix - [`2bde481`](https://github.com/bitwarden/android/commit/2bde481897854caf49869dd50fee47c1b7fc03db) Move ls - [`41fa5fe`](https://github.com/bitwarden/android/commit/41fa5fe501cc5594b86f23761d55dba392ae7e5f) Remove ls ### 📊 Changes **1 file changed** (+9 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `.github/workflows/release.yml` (+9 -2) </details> ### 📄 Description ## Type of change - [ ] Bug fix - [ ] New feature development - [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc) - [x] Build/deploy pipeline (DevOps) - [ ] Other ## Objective <!--Describe what the purpose of this PR is. For example: what bug you're fixing or what new feature you're adding--> `bitwarden/gh-actions/download-artifacts` doesn't unpack artifacts into subfolders. Because of it, the `Prep Bitwarden iOS release asset` step couldn't find the folder to zip. As a solution, I set the `bitwarden/gh-actions/download-artifacts` to skip unpacking artifacts, and unzipped them individually. ## Code changes <!--Explain the changes you've made to each file or major component. This should help the reviewer understand your changes--> <!--Also refer to any related changes or PRs in other repositories--> * **.github/workflows/release.yml:** Skip unpack afrifacts automatically after download. Unzip artifacts individually instead. ## Screenshots <!--Required for any UI changes. Delete if not applicable--> ## Before you submit - Please check for formatting errors (`dotnet format --verify-no-changes`) (required) - Please add **unit tests** where it makes sense to do so (encouraged but not required) - If this change requires a **documentation update** - notify the documentation team - If this change has particular **deployment requirements** - notify the DevOps team --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-05-01 16:19:43 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No labels pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
GiteaMirror ninjasurge (Kaehlen Rog)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#52353