github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-03-16 16:57:18 -05:00
Code Issues 144 Packages Projects Releases 116 Wiki Activity

[PR #2016] [MERGED] [EC-371] Fix iOS extensions login more menu #3294

New Issue
Closed
opened 2025-11-26 23:30:50 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-26 23:30:50 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/2016
Author: @fedemkr
Created: 7/28/2022
Status: ✅ Merged
Merged: 8/8/2022
Merged by: @fedemkr

Base: master ← Head: bug/EC-371-fix-ios-extensions-login-more-menu

📝 Commits (4)

  • 2ddf072 EC-371 fix iOS extensions login more menu and HintPage to display correctly on extensions
  • f2f21ed Merge branch 'master' into bug/EC-371-fix-ios-extensions-login-more-menu
  • 4b45cdf Merge branch 'master' into bug/EC-371-fix-ios-extensions-login-more-menu
  • b643dfc EC-371 fix merge

📊 Changes

13 files changed (+101 additions, -71 deletions)

View changed files

📝 src/App/Pages/Accounts/HintPage.xaml (+1 -1)
📝 src/App/Pages/Accounts/HintPage.xaml.cs (+1 -10)
📝 src/App/Pages/Accounts/HintPageViewModel.cs (+15 -6)
📝 src/App/Pages/Accounts/LoginPage.xaml (+1 -0)
📝 src/App/Pages/Accounts/LoginPage.xaml.cs (+15 -24)
📝 src/App/Pages/Accounts/LoginPageViewModel.cs (+35 -0)
📝 src/App/Utilities/ThemeManager.cs (+2 -2)
📝 src/iOS.Autofill/CredentialProviderViewController.cs (+11 -10)
📝 src/iOS.Core/Controllers/BaseLockPasswordViewController.cs (+1 -1)
📝 src/iOS.Core/Controllers/LockPasswordViewController.cs (+1 -1)
📝 src/iOS.Core/Services/DeviceActionService.cs (+2 -2)
📝 src/iOS.Extension/LoadingViewController.cs (+11 -10)
📝 src/iOS.ShareExtension/LoadingViewController.cs (+5 -4)

📄 Description

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

The three dots more menu on iOS extensions' login view was not working. This fixes it and also fixes the style on HintPage and some things over there that weren't working because of being on an extension.

Code changes

  • HintPage.xaml: Changed event to command on more menu item
  • HintPage.xaml.cs: Removed Submit_Clicked
  • HintPageViewModel.cs: Added logging and to SubmitCommand and fixed alert display to call the one in IDeviceActionService instead of Page so it works on the extensions as well
  • LoginPage.xaml: Added binding for enabled on email
  • LoginPage.xaml.cs: Changed a bit the More_Clicked to call the VM command for the logic and just left the behavior with the overlay in there. Also added some logging and changed a bit some flags.
  • LoginPageViewModel.cs: Added MoreCommand to move the logic from the event on the page, also fixed alert display to call the one in IDeviceActionService instead of Page so it works on the extensions as well. And added IsEmailEnabled and IsIosExtension flags.
  • ThemeManager.cs: Changed ApplyResourcesToPage(ContentPage page) to ApplyResourcesTo(VisualElement element) so that we can use it on more places, like on a NavigationPage
  • CredentialProviderViewController.cs, Extension/LoadingViewController.cs, ShareExtension/LoadingViewController.cs: Now the AppOptions are passed to the LoginPage so we know it's from an extension, also updated the calls to ApplyResourcesTo(...)
  • DeviceActionService.cs: Added null checks to the UIViewController to return. If it was null, the Task was never ending which could be causing issues.

Screenshots

Login view iOS extension with three dots

Before you submit

  • I have checked for formatting errors (dotnet tool run dotnet-format --check) (required)
  • I have added unit tests where it makes sense to do so (encouraged but not required)
  • This change requires a documentation update (notify the documentation team)
  • This change has particular deployment requirements (notify the DevOps team)

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/2016 **Author:** [@fedemkr](https://github.com/fedemkr) **Created:** 7/28/2022 **Status:** ✅ Merged **Merged:** 8/8/2022 **Merged by:** [@fedemkr](https://github.com/fedemkr) **Base:** `master` ← **Head:** `bug/EC-371-fix-ios-extensions-login-more-menu` --- ### 📝 Commits (4) - [`2ddf072`](https://github.com/bitwarden/android/commit/2ddf072400269536755857d95017a5ec3b063622) EC-371 fix iOS extensions login more menu and HintPage to display correctly on extensions - [`f2f21ed`](https://github.com/bitwarden/android/commit/f2f21edaf29fce4776aebeb92e2085b9236609a4) Merge branch 'master' into bug/EC-371-fix-ios-extensions-login-more-menu - [`4b45cdf`](https://github.com/bitwarden/android/commit/4b45cdf32945ac8a81a942af478fe28eceaa5bda) Merge branch 'master' into bug/EC-371-fix-ios-extensions-login-more-menu - [`b643dfc`](https://github.com/bitwarden/android/commit/b643dfcc7bc247f86b9112072caea61b4face527) EC-371 fix merge ### 📊 Changes **13 files changed** (+101 additions, -71 deletions) <details> <summary>View changed files</summary> 📝 `src/App/Pages/Accounts/HintPage.xaml` (+1 -1) 📝 `src/App/Pages/Accounts/HintPage.xaml.cs` (+1 -10) 📝 `src/App/Pages/Accounts/HintPageViewModel.cs` (+15 -6) 📝 `src/App/Pages/Accounts/LoginPage.xaml` (+1 -0) 📝 `src/App/Pages/Accounts/LoginPage.xaml.cs` (+15 -24) 📝 `src/App/Pages/Accounts/LoginPageViewModel.cs` (+35 -0) 📝 `src/App/Utilities/ThemeManager.cs` (+2 -2) 📝 `src/iOS.Autofill/CredentialProviderViewController.cs` (+11 -10) 📝 `src/iOS.Core/Controllers/BaseLockPasswordViewController.cs` (+1 -1) 📝 `src/iOS.Core/Controllers/LockPasswordViewController.cs` (+1 -1) 📝 `src/iOS.Core/Services/DeviceActionService.cs` (+2 -2) 📝 `src/iOS.Extension/LoadingViewController.cs` (+11 -10) 📝 `src/iOS.ShareExtension/LoadingViewController.cs` (+5 -4) </details> ### 📄 Description ## Type of change - [X] Bug fix - [ ] New feature development - [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc) - [ ] Build/deploy pipeline (DevOps) - [ ] Other ## Objective <!--Describe what the purpose of this PR is. For example: what bug you're fixing or what new feature you're adding--> The three dots more menu on iOS extensions' login view was not working. This fixes it and also fixes the style on HintPage and some things over there that weren't working because of being on an extension. ## Code changes <!--Explain the changes you've made to each file or major component. This should help the reviewer understand your changes--> <!--Also refer to any related changes or PRs in other repositories--> * **HintPage.xaml:** Changed event to command on more menu item * **HintPage.xaml.cs:** Removed Submit_Clicked * **HintPageViewModel.cs:** Added logging and to SubmitCommand and fixed alert display to call the one in `IDeviceActionService` instead of `Page` so it works on the extensions as well * **LoginPage.xaml:** Added binding for enabled on email * **LoginPage.xaml.cs:** Changed a bit the More_Clicked to call the VM command for the logic and just left the behavior with the overlay in there. Also added some logging and changed a bit some flags. * **LoginPageViewModel.cs:** Added MoreCommand to move the logic from the event on the page, also fixed alert display to call the one in `IDeviceActionService` instead of `Page` so it works on the extensions as well. And added `IsEmailEnabled` and `IsIosExtension` flags. * **ThemeManager.cs:** Changed `ApplyResourcesToPage(ContentPage page)` to `ApplyResourcesTo(VisualElement element)` so that we can use it on more places, like on a `NavigationPage` * **CredentialProviderViewController.cs, Extension/LoadingViewController.cs, ShareExtension/LoadingViewController.cs:** Now the `AppOptions` are passed to the `LoginPage` so we know it's from an extension, also updated the calls to `ApplyResourcesTo(...)` * **DeviceActionService.cs:** Added null checks to the `UIViewController` to return. If it was null, the `Task` was never ending which could be causing issues. ## Screenshots <!--Required for any UI changes. Delete if not applicable--> <img width="312" alt="Login view iOS extension with three dots" src="https://user-images.githubusercontent.com/15682323/181518834-9c87e628-813b-41d7-a8d0-464b83fd03d5.jpeg"> ## Before you submit - [X] I have checked for formatting errors (`dotnet tool run dotnet-format --check`) (required) - [ ] I have added **unit tests** where it makes sense to do so (encouraged but not required) - [ ] This change requires a **documentation update** (notify the documentation team) - [ ] This change has particular **deployment requirements** (notify the DevOps team) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-26 23:30:51 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#3294
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?