[PR #4810] [MERGED] PM-18570 Update Owner Selection Field to Bottom Sheet Selector #5231

New Issue

2025-11-26T23:56:01-06:00

GiteaMirror commented

2025-11-26 23:56:01 -06:00

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/4810
Author: @phil-livefront
Created: 2/28/2025
Status: ✅ Merged
Merged: 3/4/2025
Merged by: @phil-livefront

Base: main ← Head: phil/PM-18570-Update-Owner-Selection-Field-to-Bottom-Sheet-Selector

📝 Commits (6)

a45b8d8 PM-18570 Update Owner Selection Field to Bottom Sheet Selector
a861904 PR comments - abstracted bottomSheetState to remove 2 separate bools and some spacing/extension cleanup
9988ec5 Merge branch 'main' into phil/PM-18570-Update-Owner-Selection-Field-to-Bottom-Sheet-Selector
0ab02a9 create a common dismiss handler for dismissing bottom sheets
c62b4cf remove unused function and fix typo
6e825dc Merge branch 'main' into phil/PM-18570-Update-Owner-Selection-Field-to-Bottom-Sheet-Selector

📊 Changes

7 files changed (+346 additions, -129 deletions)

View changed files

📝 app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/addedit/VaultAddEditItemContent.kt (+2 -9)
📝 app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/addedit/VaultAddEditScreen.kt (+130 -7)
📝 app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/addedit/VaultAddEditViewModel.kt (+54 -15)
📝 app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/addedit/handlers/VaultAddEditCommonHandlers.kt (+24 -10)
📝 app/src/test/java/com/x8bit/bitwarden/ui/vault/feature/addedit/VaultAddEditScreenTest.kt (+84 -61)
📝 app/src/test/java/com/x8bit/bitwarden/ui/vault/feature/addedit/VaultAddEditViewModelTest.kt (+46 -27)
📝 authenticator/build.gradle.kts (+6 -0)

📄 Description

🎟️ Tracking

PM-18570

📔 Objective

Refactored owner selection (when adding or editing an item) to use a bottom sheet instead of a dialog
Added BottomSheetState to handle showing/dismissing the 2 different bottom sheets supported (folders/owners)
Ensure consistent JVM target version for Detekt tasks. The authenticator was failing, so the same logic from the PM was applied to the auth app

📸 Screenshots

https://github.com/user-attachments/assets/00f582d2-21b3-4adb-bfdf-46bd0ef273ce

⏰ Reminders before review

Contributor guidelines followed
All formatters and local linters executed and passed
Written new unit and / or integration tests where applicable
Protected functional changes with optionality (feature flags)
Used internationalization (i18n) for all UI strings
CI builds passed
Communicated to DevOps any deployment requirements
Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

👍 (:+1:) or similar for great changes
📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
❓ (:question:) for questions
🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
🎨 (:art:) for suggestions / improvements
❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
⛏ (:pick:) for minor or nitpick changes

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/4810 **Author:** [@phil-livefront](https://github.com/phil-livefront) **Created:** 2/28/2025 **Status:** ✅ Merged **Merged:** 3/4/2025 **Merged by:** [@phil-livefront](https://github.com/phil-livefront) **Base:** `main` ← **Head:** `phil/PM-18570-Update-Owner-Selection-Field-to-Bottom-Sheet-Selector` --- ### 📝 Commits (6) - [`a45b8d8`](https://github.com/bitwarden/android/commit/a45b8d80eb42f41f5ad54c67204e53d17517ba8b) PM-18570 Update Owner Selection Field to Bottom Sheet Selector - [`a861904`](https://github.com/bitwarden/android/commit/a8619047f77b25053f70f36de8907d144b0fbc5a) PR comments - abstracted bottomSheetState to remove 2 separate bools and some spacing/extension cleanup - [`9988ec5`](https://github.com/bitwarden/android/commit/9988ec5d3ec20b049a399fd5db26b28f91b8ae29) Merge branch 'main' into phil/PM-18570-Update-Owner-Selection-Field-to-Bottom-Sheet-Selector - [`0ab02a9`](https://github.com/bitwarden/android/commit/0ab02a962177fbb702a99598d548530bdbf26eab) create a common dismiss handler for dismissing bottom sheets - [`c62b4cf`](https://github.com/bitwarden/android/commit/c62b4cf0eef1055682c0c54861ec47a4e89b2039) remove unused function and fix typo - [`6e825dc`](https://github.com/bitwarden/android/commit/6e825dcd9c7d24db4eca42b0497666cc715788fa) Merge branch 'main' into phil/PM-18570-Update-Owner-Selection-Field-to-Bottom-Sheet-Selector ### 📊 Changes **7 files changed** (+346 additions, -129 deletions) <details> <summary>View changed files</summary> 📝 `app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/addedit/VaultAddEditItemContent.kt` (+2 -9) 📝 `app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/addedit/VaultAddEditScreen.kt` (+130 -7) 📝 `app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/addedit/VaultAddEditViewModel.kt` (+54 -15) 📝 `app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/addedit/handlers/VaultAddEditCommonHandlers.kt` (+24 -10) 📝 `app/src/test/java/com/x8bit/bitwarden/ui/vault/feature/addedit/VaultAddEditScreenTest.kt` (+84 -61) 📝 `app/src/test/java/com/x8bit/bitwarden/ui/vault/feature/addedit/VaultAddEditViewModelTest.kt` (+46 -27) 📝 `authenticator/build.gradle.kts` (+6 -0) </details> ### 📄 Description ## 🎟️ Tracking [PM-18570](https://bitwarden.atlassian.net/browse/PM-18570) ## 📔 Objective - Refactored owner selection (when adding or editing an item) to use a bottom sheet instead of a dialog - Added `BottomSheetState` to handle showing/dismissing the 2 different bottom sheets supported (folders/owners) - Ensure consistent JVM target version for Detekt tasks. The authenticator was failing, so the same logic from the PM was applied to the auth app ## 📸 Screenshots https://github.com/user-attachments/assets/00f582d2-21b3-4adb-bfdf-46bd0ef273ce ## ⏰ Reminders before review - Contributor guidelines followed - All formatters and local linters executed and passed - Written new unit and / or integration tests where applicable - Protected functional changes with optionality (feature flags) - Used internationalization (i18n) for all UI strings - CI builds passed - Communicated to DevOps any deployment requirements - Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team ## 🦮 Reviewer guidelines  - 👍 (`:+1:`) or similar for great changes - 📝 (`:memo:`) or ℹ️ (`:information_source:`) for notes or general info - ❓ (`:question:`) for questions - 🤔 (`:thinking:`) or 💭 (`:thought_balloon:`) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion - 🎨 (`:art:`) for suggestions / improvements - ❌ (`:x:`) or ⚠️ (`:warning:`) for more significant problems or concerns needing attention - 🌱 (`:seedling:`) or ♻️ (`:recycle:`) for future improvements or indications of technical debt - ⛏ (`:pick:`) for minor or nitpick changes [PM-18570]: https://bitwarden.atlassian.net/browse/PM-18570?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

GiteaMirror added the pull-request label 2025-11-26 23:56:01 -06:00

GiteaMirror closed this issue