github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-05-08 04:16:40 -05:00
Code Issues 1.1k Packages Projects Releases 122 Wiki Activity

[PR #3092] [MERGED] [PM-7010] Fix for Android App crashing when launching app with invalid package name #52235

New Issue
Closed
opened 2026-05-01 16:08:15 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-05-01 16:08:15 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/3092
Author: @dinisvieira
Created: 3/17/2024
Status: ✅ Merged
Merged: 3/22/2024
Merged by: @dinisvieira

Base: main ← Head: bug/android-exception-launch-app-incorrect-package-name

📝 Commits (2)

  • 595819b Added specific try catch in Android launchApp to avoid the app crashing when trying to launch app package name that are not installed on the device.
  • 8ef6d6d Merge branch 'main' into bug/android-exception-launch-app-incorrect-package-name

📊 Changes

1 file changed (+19 additions, -8 deletions)

View changed files

📝 src/App/Platforms/Android/Services/DeviceActionService.cs (+19 -8)

📄 Description

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

Android App is currently crashing when launching a package name that is not found on the device.

Code changes

Added specific Exception Try Catch to avoid crashing when the package name is not found.
IntentSender.SendIntentException is the Exception we get in Debug when trying to launch an invalid package name.
Android.Util.AndroidException is an Exception that seems to be reported on AppCenter for the same issue.

  • DeviceActionService: Added the specific TryCatch

Screenshots

Before you submit

  • Please check for formatting errors (dotnet format --verify-no-changes) (required)
  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/3092 **Author:** [@dinisvieira](https://github.com/dinisvieira) **Created:** 3/17/2024 **Status:** ✅ Merged **Merged:** 3/22/2024 **Merged by:** [@dinisvieira](https://github.com/dinisvieira) **Base:** `main` ← **Head:** `bug/android-exception-launch-app-incorrect-package-name` --- ### 📝 Commits (2) - [`595819b`](https://github.com/bitwarden/android/commit/595819b2141e9f00c9c8303a304130ea3662f10c) Added specific try catch in Android launchApp to avoid the app crashing when trying to launch app package name that are not installed on the device. - [`8ef6d6d`](https://github.com/bitwarden/android/commit/8ef6d6dd40e43bc2a4269501760ae352aa00d9ee) Merge branch 'main' into bug/android-exception-launch-app-incorrect-package-name ### 📊 Changes **1 file changed** (+19 additions, -8 deletions) <details> <summary>View changed files</summary> 📝 `src/App/Platforms/Android/Services/DeviceActionService.cs` (+19 -8) </details> ### 📄 Description ## Type of change - [X] Bug fix - [ ] New feature development - [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc) - [ ] Build/deploy pipeline (DevOps) - [ ] Other ## Objective Android App is currently crashing when launching a package name that is not found on the device. ## Code changes Added specific Exception Try Catch to avoid crashing when the package name is not found. `IntentSender.SendIntentException` is the Exception we get in Debug when trying to launch an invalid package name. `Android.Util.AndroidException` is an Exception that seems to be reported on AppCenter for the same issue. * **DeviceActionService:** Added the specific TryCatch ## Screenshots <!--Required for any UI changes. Delete if not applicable--> ## Before you submit - Please check for formatting errors (`dotnet format --verify-no-changes`) (required) - Please add **unit tests** where it makes sense to do so (encouraged but not required) - If this change requires a **documentation update** - notify the documentation team - If this change has particular **deployment requirements** - notify the DevOps team --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-05-01 16:08:15 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#52235
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?