github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-03-22 20:41:29 -05:00
Code Issues 144 Packages Projects Releases 118 Wiki Activity

[PR #1746] [MERGED] Fix iOS top space on Account switching list overlay after modal #3092

New Issue
Closed
opened 2025-11-26 23:28:11 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-26 23:28:11 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/1746
Author: @fedemkr
Created: 2/2/2022
Status: ✅ Merged
Merged: 2/2/2022
Merged by: @mpbw2

Base: accountswitching ← Head: accountswitching-fix-top-space-after-modal

📝 Commits (2)

  • 102d8ba Fix top space added to Account switching list overlay after closing modal
  • a7f412f Fix top space added to Account switching list overlay after closing modal on lock, login and home views just in case we add modals in the future there as well

📊 Changes

7 files changed (+97 additions, -4 deletions)

View changed files

➕ src/App/Effects/ScrollViewContentInsetAdjustmentBehaviorEffect.cs (+33 -0)
📝 src/App/Pages/Accounts/HomePage.xaml (+7 -1)
📝 src/App/Pages/Accounts/LockPage.xaml (+7 -1)
📝 src/App/Pages/Accounts/LoginPage.xaml (+7 -1)
📝 src/App/Pages/Vault/GroupingsPage/GroupingsPage.xaml (+5 -1)
➕ src/iOS.Core/Effects/ScrollViewContentInsetAdjustmentBehaviorEffect.cs (+37 -0)
📝 src/iOS.Core/iOS.Core.csproj (+1 -0)

📄 Description

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

Fix top space shown on iOS on the Account Switching overlay after opening and closing a modal on the Vault and then opening the Account Switching list.

Code changes

  • GroupingsPage.xaml: Added effect to change the behavior of content inset adjustment on the list view of account switching overlay so that it never takes into account the Safe Area which was causing the issue.

Testing requirements

In the Vault, after opening and closing a modal like adding a cypher, and opening the account switching overlay shouldn't present any weird spaces at the top.

Before you submit

  • I have added unit tests where it makes sense to do so (encouraged but not required)
  • This change requires a documentation update (notify the documentation team)
  • This change has particular deployment requirements (notify the DevOps team)

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/1746 **Author:** [@fedemkr](https://github.com/fedemkr) **Created:** 2/2/2022 **Status:** ✅ Merged **Merged:** 2/2/2022 **Merged by:** [@mpbw2](https://github.com/mpbw2) **Base:** `accountswitching` ← **Head:** `accountswitching-fix-top-space-after-modal` --- ### 📝 Commits (2) - [`102d8ba`](https://github.com/bitwarden/android/commit/102d8bab9a129aa6c9aa5246b8bb7506df07ed17) Fix top space added to Account switching list overlay after closing modal - [`a7f412f`](https://github.com/bitwarden/android/commit/a7f412f77de3d4dddf9da56606c96dd587fdf542) Fix top space added to Account switching list overlay after closing modal on lock, login and home views just in case we add modals in the future there as well ### 📊 Changes **7 files changed** (+97 additions, -4 deletions) <details> <summary>View changed files</summary> ➕ `src/App/Effects/ScrollViewContentInsetAdjustmentBehaviorEffect.cs` (+33 -0) 📝 `src/App/Pages/Accounts/HomePage.xaml` (+7 -1) 📝 `src/App/Pages/Accounts/LockPage.xaml` (+7 -1) 📝 `src/App/Pages/Accounts/LoginPage.xaml` (+7 -1) 📝 `src/App/Pages/Vault/GroupingsPage/GroupingsPage.xaml` (+5 -1) ➕ `src/iOS.Core/Effects/ScrollViewContentInsetAdjustmentBehaviorEffect.cs` (+37 -0) 📝 `src/iOS.Core/iOS.Core.csproj` (+1 -0) </details> ### 📄 Description ## Type of change - [X] Bug fix - [X] New feature development - [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc) - [ ] Build/deploy pipeline (DevOps) - [ ] Other ## Objective <!--Describe what the purpose of this PR is. For example: what bug you're fixing or what new feature you're adding--> Fix top space shown on iOS on the Account Switching overlay after opening and closing a modal on the Vault and then opening the Account Switching list. ## Code changes <!--Explain the changes you've made to each file or major component. This should help the reviewer understand your changes--> <!--Also refer to any related changes or PRs in other repositories--> * **GroupingsPage.xaml:** Added effect to change the behavior of content inset adjustment on the list view of account switching overlay so that it never takes into account the Safe Area which was causing the issue. ## Testing requirements <!--What functionality requires testing by QA? This includes testing new behavior and regression testing--> In the Vault, after opening and closing a modal like adding a cypher, and opening the account switching overlay shouldn't present any weird spaces at the top. ## Before you submit - [ ] I have added **unit tests** where it makes sense to do so (encouraged but not required) - [ ] This change requires a **documentation update** (notify the documentation team) - [ ] This change has particular **deployment requirements** (notify the DevOps team) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-26 23:28:11 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#3092
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?