github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-03-09 03:33:36 -05:00
Code Issues 144 Packages Projects Releases 116 Wiki Activity

[PR #4794] [MERGED] [PM-16534] Monorepo prep - Update checkmarx, renovate and gitignore #5219

New Issue
Closed
opened 2025-11-26 23:55:47 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-26 23:55:47 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/4794
Author: @vvolkgang
Created: 2/26/2025
Status: ✅ Merged
Merged: 2/26/2025
Merged by: @vvolkgang

Base: main ← Head: repo-migration/last-files

📝 Commits (3)

  • 50e3e64 Update checkmarx filter to cover bwa
  • 56c6c2b Update gitignore to ignore production google-services.json used in PM and BWA
  • 1227d22 Add androidx.lifecycle to kotlin group in renovate config

📊 Changes

3 files changed (+4 additions, -2 deletions)

View changed files

📝 .checkmarx/config.yml (+1 -1)
📝 .github/renovate.json (+1 -0)
📝 .gitignore (+2 -1)

📄 Description

🎟️ Tracking

PM-16534

📔 Objective

Updates remaining files ahead of moving the authenticator app.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed
    issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/4794 **Author:** [@vvolkgang](https://github.com/vvolkgang) **Created:** 2/26/2025 **Status:** ✅ Merged **Merged:** 2/26/2025 **Merged by:** [@vvolkgang](https://github.com/vvolkgang) **Base:** `main` ← **Head:** `repo-migration/last-files` --- ### 📝 Commits (3) - [`50e3e64`](https://github.com/bitwarden/android/commit/50e3e640cdc39dc2b506996e7737e1db38a4007a) Update checkmarx filter to cover bwa - [`56c6c2b`](https://github.com/bitwarden/android/commit/56c6c2b148b9301723e28f2f3d053ca2cd120db8) Update gitignore to ignore production google-services.json used in PM and BWA - [`1227d22`](https://github.com/bitwarden/android/commit/1227d222855662d526be1ea86061a323e9635632) Add androidx.lifecycle to kotlin group in renovate config ### 📊 Changes **3 files changed** (+4 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `.checkmarx/config.yml` (+1 -1) 📝 `.github/renovate.json` (+1 -0) 📝 `.gitignore` (+2 -1) </details> ### 📄 Description ## 🎟️ Tracking PM-16534 ## 📔 Objective Updates remaining files ahead of moving the authenticator app. ## ⏰ Reminders before review - Contributor guidelines followed - All formatters and local linters executed and passed - Written new unit and / or integration tests where applicable - Used internationalization (i18n) for all UI strings - CI builds passed - Communicated to DevOps any deployment requirements - Updated any necessary documentation or informed the documentation team ## 🦮 Reviewer guidelines <!-- Suggested interactions but feel free to use (or not) as you desire! --> - 👍 (`:+1:`) or similar for great changes - 📝 (`:memo:`) or ℹ️ (`:information_source:`) for notes or general info - ❓ (`:question:`) for questions - 🤔 (`:thinking:`) or 💭 (`:thought_balloon:`) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion - 🎨 (`:art:`) for suggestions / improvements - ❌ (`:x:`) or ⚠️ (`:warning:`) for more significant problems or concerns needing attention - 🌱 (`:seedling:`) or ♻️ (`:recycle:`) for future improvements or indications of technical debt - ⛏ (`:pick:`) for minor or nitpick changes --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-26 23:55:47 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#5219
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?