github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-03-09 03:33:36 -05:00
Code Issues 144 Packages Projects Releases 116 Wiki Activity

[PR #4237] [MERGED] PM-14410: App restart timeout action #4794

New Issue
Closed
opened 2025-11-26 23:49:51 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-26 23:49:51 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/4237
Author: @david-livefront
Created: 11/5/2024
Status: ✅ Merged
Merged: 11/6/2024
Merged by: @david-livefront

Base: main ← Head: PM-14410-app-restart-timeout-action

📝 Commits (3)

  • 38298b4 Rename AppForegroundManager to AppStateManager
  • 5833c62 Add Logic for tracking app creation and destruction
  • a022758 PM-14410: When app is closed, on app restart action should execute

📊 Changes

21 files changed (+377 additions, -171 deletions)

View changed files

📝 app/src/main/java/com/x8bit/bitwarden/data/autofill/accessibility/di/ActivityAccessibilityModule.kt (+3 -3)
📝 app/src/main/java/com/x8bit/bitwarden/data/autofill/accessibility/manager/AccessibilityActivityManagerImpl.kt (+3 -3)
📝 app/src/main/java/com/x8bit/bitwarden/data/autofill/di/ActivityAutofillModule.kt (+3 -3)
📝 app/src/main/java/com/x8bit/bitwarden/data/autofill/manager/AutofillActivityManagerImpl.kt (+3 -3)
➖ app/src/main/java/com/x8bit/bitwarden/data/platform/manager/AppForegroundManager.kt (+0 -15)
➖ app/src/main/java/com/x8bit/bitwarden/data/platform/manager/AppForegroundManagerImpl.kt (+0 -36)
➕ app/src/main/java/com/x8bit/bitwarden/data/platform/manager/AppStateManager.kt (+24 -0)
➕ app/src/main/java/com/x8bit/bitwarden/data/platform/manager/AppStateManagerImpl.kt (+72 -0)
📝 app/src/main/java/com/x8bit/bitwarden/data/platform/manager/di/PlatformManagerModule.kt (+7 -6)
➕ app/src/main/java/com/x8bit/bitwarden/data/platform/manager/model/AppCreationState.kt (+16 -0)
📝 app/src/main/java/com/x8bit/bitwarden/data/platform/manager/restriction/RestrictionManagerImpl.kt (+3 -3)
📝 app/src/main/java/com/x8bit/bitwarden/data/vault/manager/VaultLockManagerImpl.kt (+26 -3)
📝 app/src/main/java/com/x8bit/bitwarden/data/vault/manager/di/VaultManagerModule.kt (+3 -3)
📝 app/src/test/java/com/x8bit/bitwarden/data/autofill/accessibility/manager/AccessibilityActivityManagerTest.kt (+3 -3)
📝 app/src/test/java/com/x8bit/bitwarden/data/autofill/manager/AutofillActivityManagerTest.kt (+3 -3)
➖ app/src/test/java/com/x8bit/bitwarden/data/platform/manager/AppForegroundManagerTest.kt (+0 -44)
➕ app/src/test/java/com/x8bit/bitwarden/data/platform/manager/AppStateManagerTest.kt (+82 -0)
📝 app/src/test/java/com/x8bit/bitwarden/data/platform/manager/restriction/RestrictionManagerTest.kt (+15 -15)
📝 app/src/test/java/com/x8bit/bitwarden/data/platform/manager/util/FakeAppStateManager.kt (+17 -3)
📝 app/src/test/java/com/x8bit/bitwarden/data/vault/manager/VaultLockManagerTest.kt (+93 -24)

...and 1 more files

📄 Description

🎟️ Tracking

PM-14410

📔 Objective

This PR updates the the way the On App Restart timeout action functions by watching for the number of active activities. This change is required because when the AccessibilityService is running the app is not killed as it usually would be.

📸 Screenshots

Before After

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed
    issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/4237 **Author:** [@david-livefront](https://github.com/david-livefront) **Created:** 11/5/2024 **Status:** ✅ Merged **Merged:** 11/6/2024 **Merged by:** [@david-livefront](https://github.com/david-livefront) **Base:** `main` ← **Head:** `PM-14410-app-restart-timeout-action` --- ### 📝 Commits (3) - [`38298b4`](https://github.com/bitwarden/android/commit/38298b4a83b3a40b73e141a508ea8706855610b4) Rename AppForegroundManager to AppStateManager - [`5833c62`](https://github.com/bitwarden/android/commit/5833c62456db859f716f84eb1b554e2be5e69435) Add Logic for tracking app creation and destruction - [`a022758`](https://github.com/bitwarden/android/commit/a0227582659f2e6a1cc353680139e4736395fcb6) PM-14410: When app is closed, on app restart action should execute ### 📊 Changes **21 files changed** (+377 additions, -171 deletions) <details> <summary>View changed files</summary> 📝 `app/src/main/java/com/x8bit/bitwarden/data/autofill/accessibility/di/ActivityAccessibilityModule.kt` (+3 -3) 📝 `app/src/main/java/com/x8bit/bitwarden/data/autofill/accessibility/manager/AccessibilityActivityManagerImpl.kt` (+3 -3) 📝 `app/src/main/java/com/x8bit/bitwarden/data/autofill/di/ActivityAutofillModule.kt` (+3 -3) 📝 `app/src/main/java/com/x8bit/bitwarden/data/autofill/manager/AutofillActivityManagerImpl.kt` (+3 -3) ➖ `app/src/main/java/com/x8bit/bitwarden/data/platform/manager/AppForegroundManager.kt` (+0 -15) ➖ `app/src/main/java/com/x8bit/bitwarden/data/platform/manager/AppForegroundManagerImpl.kt` (+0 -36) ➕ `app/src/main/java/com/x8bit/bitwarden/data/platform/manager/AppStateManager.kt` (+24 -0) ➕ `app/src/main/java/com/x8bit/bitwarden/data/platform/manager/AppStateManagerImpl.kt` (+72 -0) 📝 `app/src/main/java/com/x8bit/bitwarden/data/platform/manager/di/PlatformManagerModule.kt` (+7 -6) ➕ `app/src/main/java/com/x8bit/bitwarden/data/platform/manager/model/AppCreationState.kt` (+16 -0) 📝 `app/src/main/java/com/x8bit/bitwarden/data/platform/manager/restriction/RestrictionManagerImpl.kt` (+3 -3) 📝 `app/src/main/java/com/x8bit/bitwarden/data/vault/manager/VaultLockManagerImpl.kt` (+26 -3) 📝 `app/src/main/java/com/x8bit/bitwarden/data/vault/manager/di/VaultManagerModule.kt` (+3 -3) 📝 `app/src/test/java/com/x8bit/bitwarden/data/autofill/accessibility/manager/AccessibilityActivityManagerTest.kt` (+3 -3) 📝 `app/src/test/java/com/x8bit/bitwarden/data/autofill/manager/AutofillActivityManagerTest.kt` (+3 -3) ➖ `app/src/test/java/com/x8bit/bitwarden/data/platform/manager/AppForegroundManagerTest.kt` (+0 -44) ➕ `app/src/test/java/com/x8bit/bitwarden/data/platform/manager/AppStateManagerTest.kt` (+82 -0) 📝 `app/src/test/java/com/x8bit/bitwarden/data/platform/manager/restriction/RestrictionManagerTest.kt` (+15 -15) 📝 `app/src/test/java/com/x8bit/bitwarden/data/platform/manager/util/FakeAppStateManager.kt` (+17 -3) 📝 `app/src/test/java/com/x8bit/bitwarden/data/vault/manager/VaultLockManagerTest.kt` (+93 -24) _...and 1 more files_ </details> ### 📄 Description ## 🎟️ Tracking [PM-14410](https://bitwarden.atlassian.net/browse/PM-14410) ## 📔 Objective This PR updates the the way the `On App Restart` timeout action functions by watching for the number of active activities. This change is required because when the `AccessibilityService` is running the app is not killed as it usually would be. ## 📸 Screenshots | Before | After | | --- | --- | | <video src="https://github.com/user-attachments/assets/964807ba-4ec5-452a-be38-a5f99fab6198" width="300" /> | <video src="https://github.com/user-attachments/assets/4b3892a8-1e7c-459e-ac09-d0b083431286" width="300" /> | ## ⏰ Reminders before review - Contributor guidelines followed - All formatters and local linters executed and passed - Written new unit and / or integration tests where applicable - Used internationalization (i18n) for all UI strings - CI builds passed - Communicated to DevOps any deployment requirements - Updated any necessary documentation or informed the documentation team ## 🦮 Reviewer guidelines <!-- Suggested interactions but feel free to use (or not) as you desire! --> - 👍 (`:+1:`) or similar for great changes - 📝 (`:memo:`) or ℹ️ (`:information_source:`) for notes or general info - ❓ (`:question:`) for questions - 🤔 (`:thinking:`) or 💭 (`:thought_balloon:`) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion - 🎨 (`:art:`) for suggestions / improvements - ❌ (`:x:`) or ⚠️ (`:warning:`) for more significant problems or concerns needing attention - 🌱 (`:seedling:`) or ♻️ (`:recycle:`) for future improvements or indications of technical debt - ⛏ (`:pick:`) for minor or nitpick changes [PM-14410]: https://bitwarden.atlassian.net/browse/PM-14410?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-26 23:49:51 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#4794
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?