github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-05-07 03:23:29 -05:00
Code Issues 1.1k Packages Projects Releases 122 Wiki Activity

[PR #2949] [CLOSED] [PM-5830] Add username field term #52120

New Issue
Closed
opened 2026-05-01 15:55:45 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-05-01 15:55:45 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/2949
Author: @larena1
Created: 1/22/2024
Status: ❌ Closed

Base: main ← Head: add-username-term

📝 Commits (10+)

  • bf7d9b5 [SG-1022] Update min password requirements to 12 char (#2368)
  • c5d72ad State migration storage key refinement (#2379)
  • 0539eda Autosync the updated translations (#2381)
  • b26b9ea [EC-763] Cake build watchOS (#2278)
  • 3f72d35 [SG-744] Add claimed domain logic to mobile (#2333)
  • 6da1875 [PS-2520] Restore copy confirmation toast on Android 13+ (#2388)
  • 5164762 Autosync the updated translations (#2391)
  • 470e08f [EC-1002] [BEEEP] Add ability to change language in app (#2299)
  • a81dfc2 Patch/update ios provision profiles (#2398)
  • 3f86bb0 PM-1271 Removed StorageMediatorOptions and go to a plain parameters based approach (#2397)

📊 Changes

1 file changed (+1 additions, -1 deletions)

View changed files

📝 src/Android/Autofill/FieldCollection.cs (+1 -1)

📄 Description

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

Making autofill more reliable as it currently does not consider "e-mail" as username field.

Code changes

  • file.ext: Description of what was changed and why

Screenshots

Before you submit

  • Please check for formatting errors (dotnet format --verify-no-changes) (required)
  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/2949 **Author:** [@larena1](https://github.com/larena1) **Created:** 1/22/2024 **Status:** ❌ Closed **Base:** `main` ← **Head:** `add-username-term` --- ### 📝 Commits (10+) - [`bf7d9b5`](https://github.com/bitwarden/android/commit/bf7d9b5646003b4faf9b61f8108f77b5a497383a) [SG-1022] Update min password requirements to 12 char (#2368) - [`c5d72ad`](https://github.com/bitwarden/android/commit/c5d72ad7cb264bc725cd687739e93fa3831d2c47) State migration storage key refinement (#2379) - [`0539eda`](https://github.com/bitwarden/android/commit/0539eda57ee00e6fd252259b851cd4185820428f) Autosync the updated translations (#2381) - [`b26b9ea`](https://github.com/bitwarden/android/commit/b26b9ea41b98b9a66954e047d5aad64de782da71) [EC-763] Cake build watchOS (#2278) - [`3f72d35`](https://github.com/bitwarden/android/commit/3f72d3514519b5745ce5a34826c00e60921aadf7) [SG-744] Add claimed domain logic to mobile (#2333) - [`6da1875`](https://github.com/bitwarden/android/commit/6da1875ab690aeebcbb12f6604df852ce5c76989) [PS-2520] Restore copy confirmation toast on Android 13+ (#2388) - [`5164762`](https://github.com/bitwarden/android/commit/5164762f2e046fd868218ba13dc76de5a0553123) Autosync the updated translations (#2391) - [`470e08f`](https://github.com/bitwarden/android/commit/470e08f1654e5e987a7a908ffe87356bf8335fa4) [EC-1002] [BEEEP] Add ability to change language in app (#2299) - [`a81dfc2`](https://github.com/bitwarden/android/commit/a81dfc271c893c7ea27515c9c5148affafb13e1d) Patch/update ios provision profiles (#2398) - [`3f86bb0`](https://github.com/bitwarden/android/commit/3f86bb0cd7e33c29e7374c0caee402b9fd30386e) PM-1271 Removed StorageMediatorOptions and go to a plain parameters based approach (#2397) ### 📊 Changes **1 file changed** (+1 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `src/Android/Autofill/FieldCollection.cs` (+1 -1) </details> ### 📄 Description ## Type of change - [x] Bug fix - [ ] New feature development - [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc) - [ ] Build/deploy pipeline (DevOps) - [ ] Other ## Objective Making autofill more reliable as it currently does not consider "e-mail" as username field. <!--Describe what the purpose of this PR is. For example: what bug you're fixing or what new feature you're adding--> ## Code changes <!--Explain the changes you've made to each file or major component. This should help the reviewer understand your changes--> <!--Also refer to any related changes or PRs in other repositories--> * **file.ext:** Description of what was changed and why ## Screenshots <!--Required for any UI changes. Delete if not applicable--> ## Before you submit - Please check for formatting errors (`dotnet format --verify-no-changes`) (required) - Please add **unit tests** where it makes sense to do so (encouraged but not required) - If this change requires a **documentation update** - notify the documentation team - If this change has particular **deployment requirements** - notify the DevOps team --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-05-01 15:55:45 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#52120
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?