github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-08-23 17:47:57 -05:00
Code Issues 2.4k Packages Projects Releases 129 Wiki Activity

[PR #2939] [MERGED] [PM-5715] Route to import page when clicking on import items button Pt2 #52112

New Issue
Closed
opened 2026-05-01 15:54:59 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-05-01 15:54:59 -05:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/2939
Author: @djsmith85
Created: 1/16/2024
Status: ✅ Merged
Merged: 1/16/2024
Merged by: @djsmith85

Base: main ← Head: tools/pm-5715/extend-link-to-import-items

📝 Commits (1)

  • 9ba33a6 Import-link routes to import page after login

📊 Changes

2 files changed (+8 additions, -3 deletions)

View changed files

📝 src/App/Pages/Settings/VaultSettingsPageViewModel.cs (+3 -3)
📝 src/Core/ExternalLinksConstants.cs (+5 -0)

📄 Description

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

Follow-up from https://github.com/bitwarden/mobile/pull/2937

When tapping on the Import items button, the user gets asked if they want to get redirected to the web vault to import the items.

Clicking yes, opens the web-vault in the browser, but after logging in, they are on the vault page instead of the tools/import page.

Code changes

  • src/App/Pages/Settings/VaultSettingsPageViewModel.cs: Extend the existing url with "/#/tools/import" to route to the import page

Before you submit

  • Please check for formatting errors (dotnet format --verify-no-changes) (required)
  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/2939 **Author:** [@djsmith85](https://github.com/djsmith85) **Created:** 1/16/2024 **Status:** ✅ Merged **Merged:** 1/16/2024 **Merged by:** [@djsmith85](https://github.com/djsmith85) **Base:** `main` ← **Head:** `tools/pm-5715/extend-link-to-import-items` --- ### 📝 Commits (1) - [`9ba33a6`](https://github.com/bitwarden/android/commit/9ba33a69ffd4f530b873922571e409ad17be3705) Import-link routes to import page after login ### 📊 Changes **2 files changed** (+8 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `src/App/Pages/Settings/VaultSettingsPageViewModel.cs` (+3 -3) 📝 `src/Core/ExternalLinksConstants.cs` (+5 -0) </details> ### 📄 Description ## Type of change - [X] Bug fix - [ ] New feature development - [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc) - [ ] Build/deploy pipeline (DevOps) - [ ] Other ## Objective <!--Describe what the purpose of this PR is. For example: what bug you're fixing or what new feature you're adding--> Follow-up from https://github.com/bitwarden/mobile/pull/2937 When tapping on the Import items button, the user gets asked if they want to get redirected to the web vault to import the items. Clicking yes, opens the web-vault in the browser, but after logging in, they are on the vault page instead of the tools/import page. ## Code changes <!--Explain the changes you've made to each file or major component. This should help the reviewer understand your changes--> <!--Also refer to any related changes or PRs in other repositories--> * **src/App/Pages/Settings/VaultSettingsPageViewModel.cs:** Extend the existing url with "/#/tools/import" to route to the import page ## Before you submit - Please check for formatting errors (`dotnet format --verify-no-changes`) (required) - Please add **unit tests** where it makes sense to do so (encouraged but not required) - If this change requires a **documentation update** - notify the documentation team - If this change has particular **deployment requirements** - notify the DevOps team --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-05-01 15:54:59 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No labels pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
GiteaMirror ninjasurge (Kaehlen Rog)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#52112