github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-03-22 20:41:29 -05:00
Code Issues 144 Packages Projects Releases 118 Wiki Activity

[PR #1520] [MERGED] [SSO] Auto enroll during set password #2939

New Issue
Closed
opened 2025-11-26 23:26:11 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-26 23:26:11 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/1520
Author: @vincentsalucci
Created: 9/1/2021
Status: ✅ Merged
Merged: 9/8/2021
Merged by: @vincentsalucci

Base: master ← Head: m-auto-enroll-sso

📝 Commits (2)

  • 71fc73b [SSO] Auto enroll during set password
  • 741b98a Updated with requested changes

📊 Changes

17 files changed (+158 additions, -6 deletions)

View changed files

📝 src/App/Pages/Accounts/SetPasswordPage.xaml (+23 -1)
📝 src/App/Pages/Accounts/SetPasswordPageViewModel.cs (+34 -1)
📝 src/App/Resources/AppResources.Designer.cs (+6 -0)
📝 src/App/Resources/AppResources.resx (+3 -0)
📝 src/Core/Abstractions/IApiService.cs (+3 -0)
📝 src/Core/Abstractions/IPolicyService.cs (+3 -0)
📝 src/Core/Abstractions/IUserService.cs (+1 -0)
📝 src/Core/Enums/PolicyType.cs (+1 -0)
📝 src/Core/Models/Data/OrganizationData.cs (+4 -1)
📝 src/Core/Models/Domain/Organization.cs (+4 -1)
➕ src/Core/Models/Domain/ResetPasswordPolicyOptions.cs (+7 -0)
➕ src/Core/Models/Request/OrganizationUserResetPasswordEnrollmentRequest.cs (+7 -0)
➕ src/Core/Models/Response/OrganizationKeysResponse.cs (+8 -0)
📝 src/Core/Models/Response/ProfileOrganizationResponse.cs (+1 -0)
📝 src/Core/Services/ApiService.cs (+21 -1)
📝 src/Core/Services/PolicyService.cs (+19 -1)
📝 src/Core/Services/UserService.cs (+13 -0)

📄 Description

Objective

Expand the Set Password flow to handle Password Reset Auto Enrollment for the organization joined.

Code Changes

  • SetPasswordPage.xaml: Add new banner explaining auto enrollment
  • SetPasswordPageViewModel.cs: Add new properties/methods/conditionals for handling auto enrollment once a successful password is set
  • AppResources.resx: Added banner string
  • ApiService: Added two new API methods to be used during the auto enrollment flow
  • PolicyService: Added new getter method retrieving reset password policy options
  • UserService: Added new method to retrieve an organization by identifier
  • PolicyType: Added ResetPassword enumeration
  • OrganizationData: Added Identifier property
  • Organization: Added Identifier property
  • ResetPasswordPolicyOptions: Created object
  • OrganizationUserResetPasswordEnrollmentRequest: Created object
  • OrganizationKeysResponse: Created object
  • ProfileOrganizationResponse: Created object

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/1520 **Author:** [@vincentsalucci](https://github.com/vincentsalucci) **Created:** 9/1/2021 **Status:** ✅ Merged **Merged:** 9/8/2021 **Merged by:** [@vincentsalucci](https://github.com/vincentsalucci) **Base:** `master` ← **Head:** `m-auto-enroll-sso` --- ### 📝 Commits (2) - [`71fc73b`](https://github.com/bitwarden/android/commit/71fc73bd7a7788fd97ab28b125c96583e3be9fd9) [SSO] Auto enroll during set password - [`741b98a`](https://github.com/bitwarden/android/commit/741b98a7c6b6b4491010dde756a75e16c6346967) Updated with requested changes ### 📊 Changes **17 files changed** (+158 additions, -6 deletions) <details> <summary>View changed files</summary> 📝 `src/App/Pages/Accounts/SetPasswordPage.xaml` (+23 -1) 📝 `src/App/Pages/Accounts/SetPasswordPageViewModel.cs` (+34 -1) 📝 `src/App/Resources/AppResources.Designer.cs` (+6 -0) 📝 `src/App/Resources/AppResources.resx` (+3 -0) 📝 `src/Core/Abstractions/IApiService.cs` (+3 -0) 📝 `src/Core/Abstractions/IPolicyService.cs` (+3 -0) 📝 `src/Core/Abstractions/IUserService.cs` (+1 -0) 📝 `src/Core/Enums/PolicyType.cs` (+1 -0) 📝 `src/Core/Models/Data/OrganizationData.cs` (+4 -1) 📝 `src/Core/Models/Domain/Organization.cs` (+4 -1) ➕ `src/Core/Models/Domain/ResetPasswordPolicyOptions.cs` (+7 -0) ➕ `src/Core/Models/Request/OrganizationUserResetPasswordEnrollmentRequest.cs` (+7 -0) ➕ `src/Core/Models/Response/OrganizationKeysResponse.cs` (+8 -0) 📝 `src/Core/Models/Response/ProfileOrganizationResponse.cs` (+1 -0) 📝 `src/Core/Services/ApiService.cs` (+21 -1) 📝 `src/Core/Services/PolicyService.cs` (+19 -1) 📝 `src/Core/Services/UserService.cs` (+13 -0) </details> ### 📄 Description ## Objective > Expand the `Set Password` flow to handle Password Reset Auto Enrollment for the organization joined. ## Code Changes - **SetPasswordPage.xaml**: Add new banner explaining auto enrollment - **SetPasswordPageViewModel.cs**: Add new properties/methods/conditionals for handling auto enrollment once a successful password is set - **AppResources.resx**: Added banner string - **ApiService**: Added two new API methods to be used during the auto enrollment flow - **PolicyService**: Added new getter method retrieving reset password policy options - **UserService**: Added new method to retrieve an organization by `identifier` - **PolicyType**: Added `ResetPassword` enumeration - **OrganizationData**: Added `Identifier` property - **Organization**: Added `Identifier` property - **ResetPasswordPolicyOptions**: Created object - **OrganizationUserResetPasswordEnrollmentRequest**: Created object - **OrganizationKeysResponse**: Created object - **ProfileOrganizationResponse**: Created object --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-26 23:26:11 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#2939
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?