[PR #200] [MERGED] App: LoginPage.cs: Use a logo for the login button #50667

Closed
opened 2026-05-01 13:57:07 -05:00 by GiteaMirror · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/200
Author: @alistair23
Created: 12/7/2017
Status: Merged
Merged: 12/11/2017
Merged by: @kspearrin

Base: masterHead: alistair/image


📝 Commits (4)

  • 55bb92f App: LoginPage.cs: Use a logo for the login button
  • ff81970 App: Pages: Set an icon for the save button on Windows
  • 0d9e7aa App: Pages: Set an icon for submit, save and continue
  • 18ac44d App: Pages: Valut: Set an icon for the edit button

📊 Changes

15 files changed (+26 additions, -13 deletions)

View changed files

📝 src/App/Pages/EnvironmentPage.cs (+2 -1)
📝 src/App/Pages/Lock/LockPasswordPage.cs (+1 -1)
📝 src/App/Pages/LoginPage.cs (+1 -1)
📝 src/App/Pages/LoginTwoFactorPage.cs (+1 -1)
📝 src/App/Pages/PasswordHintPage.cs (+1 -1)
📝 src/App/Pages/RegisterPage.cs (+1 -1)
📝 src/App/Pages/Settings/SettingsAddFolderPage.cs (+1 -1)
📝 src/App/Pages/Settings/SettingsEditFolderPage.cs (+1 -1)
📝 src/App/Pages/Tools/ToolsPasswordGeneratorPage.cs (+1 -1)
📝 src/App/Pages/Vault/VaultAddCipherPage.cs (+1 -1)
📝 src/App/Pages/Vault/VaultAttachmentsPage.cs (+1 -1)
📝 src/App/Pages/Vault/VaultCustomFieldsPage.cs (+1 -1)
📝 src/App/Pages/Vault/VaultEditCipherPage.cs (+1 -1)
📝 src/App/Pages/Vault/VaultViewCipherPage.cs (+1 -0)
📝 src/App/Utilities/Helpers.cs (+11 -0)

📄 Description

This adds a helper function which we can use to set logos for Windows
platforms to ensure the user can see the UWP toolbar actions. This won't
have an effect on non-Windows platforms.

Signed-off-by: Alistair Francis alistair@alistair23.me


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/200 **Author:** [@alistair23](https://github.com/alistair23) **Created:** 12/7/2017 **Status:** ✅ Merged **Merged:** 12/11/2017 **Merged by:** [@kspearrin](https://github.com/kspearrin) **Base:** `master` ← **Head:** `alistair/image` --- ### 📝 Commits (4) - [`55bb92f`](https://github.com/bitwarden/android/commit/55bb92fff6cf9ac5cb9541f827cec069d5b31d80) App: LoginPage.cs: Use a logo for the login button - [`ff81970`](https://github.com/bitwarden/android/commit/ff819705e2f88b20844f42c3d57f15bd8debe081) App: Pages: Set an icon for the save button on Windows - [`0d9e7aa`](https://github.com/bitwarden/android/commit/0d9e7aaf40159d85744ce41c164e578b7569524e) App: Pages: Set an icon for submit, save and continue - [`18ac44d`](https://github.com/bitwarden/android/commit/18ac44d51a8d119914addf45f1d26bbd81b4baa9) App: Pages: Valut: Set an icon for the edit button ### 📊 Changes **15 files changed** (+26 additions, -13 deletions) <details> <summary>View changed files</summary> 📝 `src/App/Pages/EnvironmentPage.cs` (+2 -1) 📝 `src/App/Pages/Lock/LockPasswordPage.cs` (+1 -1) 📝 `src/App/Pages/LoginPage.cs` (+1 -1) 📝 `src/App/Pages/LoginTwoFactorPage.cs` (+1 -1) 📝 `src/App/Pages/PasswordHintPage.cs` (+1 -1) 📝 `src/App/Pages/RegisterPage.cs` (+1 -1) 📝 `src/App/Pages/Settings/SettingsAddFolderPage.cs` (+1 -1) 📝 `src/App/Pages/Settings/SettingsEditFolderPage.cs` (+1 -1) 📝 `src/App/Pages/Tools/ToolsPasswordGeneratorPage.cs` (+1 -1) 📝 `src/App/Pages/Vault/VaultAddCipherPage.cs` (+1 -1) 📝 `src/App/Pages/Vault/VaultAttachmentsPage.cs` (+1 -1) 📝 `src/App/Pages/Vault/VaultCustomFieldsPage.cs` (+1 -1) 📝 `src/App/Pages/Vault/VaultEditCipherPage.cs` (+1 -1) 📝 `src/App/Pages/Vault/VaultViewCipherPage.cs` (+1 -0) 📝 `src/App/Utilities/Helpers.cs` (+11 -0) </details> ### 📄 Description This adds a helper function which we can use to set logos for Windows platforms to ensure the user can see the UWP toolbar actions. This won't have an effect on non-Windows platforms. Signed-off-by: Alistair Francis <alistair@alistair23.me> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-05-01 13:57:07 -05:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#50667