[PR #4558] [MERGED] PM-16830 - Update global loading screen component to new reskinned version #5037

New Issue

2025-11-26T23:53:10-06:00

GiteaMirror commented

2025-11-26 23:53:10 -06:00

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/4558
Author: @phil-livefront
Created: 1/13/2025
Status: ✅ Merged
Merged: 1/13/2025
Merged by: @phil-livefront

Base: main ← Head: phil/PM-16830-Update-global-loading-screen-component-to-new-reskinned-version

📝 Commits (1)

5c1c33f PM-16830 - Update global loading screen component to new reskinned version

📊 Changes

1 file changed (+1 additions, -0 deletions)

View changed files

📝 app/src/main/java/com/x8bit/bitwarden/ui/platform/components/indicator/BitwardenCircularProgressIndicator.kt (+1 -0)

📄 Description

🎟️ Tracking

PM-16830

📔 Objective

Update the loading indicator to match the new reskin. Originally I had read this story wrong and was implementing this app-wide for the full screen loading but after a sync with Dave I realized this ticket is much smaller in size.
Using the existing CircularProgressIndicator and updated the trackColor property to match the new reskin color. Confirmed with Emily this looks good for this particular ticket.

📸 Screenshots

https://github.com/user-attachments/assets/e450a79f-818d-4978-951b-1f0f093d6809

⏰ Reminders before review

Contributor guidelines followed
All formatters and local linters executed and passed
Written new unit and / or integration tests where applicable
Used internationalization (i18n) for all UI strings
CI builds passed
Communicated to DevOps any deployment requirements
Updated any necessary documentation or informed the documentation team

🦮 Reviewer guidelines

👍 (:+1:) or similar for great changes
📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
❓ (:question:) for questions
🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed
issue and could potentially benefit from discussion
🎨 (:art:) for suggestions / improvements
❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
⛏ (:pick:) for minor or nitpick changes

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/4558 **Author:** [@phil-livefront](https://github.com/phil-livefront) **Created:** 1/13/2025 **Status:** ✅ Merged **Merged:** 1/13/2025 **Merged by:** [@phil-livefront](https://github.com/phil-livefront) **Base:** `main` ← **Head:** `phil/PM-16830-Update-global-loading-screen-component-to-new-reskinned-version` --- ### 📝 Commits (1) - [`5c1c33f`](https://github.com/bitwarden/android/commit/5c1c33fb2de20de50c557732b68bc74ed520c88b) PM-16830 - Update global loading screen component to new reskinned version ### 📊 Changes **1 file changed** (+1 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `app/src/main/java/com/x8bit/bitwarden/ui/platform/components/indicator/BitwardenCircularProgressIndicator.kt` (+1 -0) </details> ### 📄 Description ## 🎟️ Tracking [PM-16830](https://bitwarden.atlassian.net/browse/PM-16830) ## 📔 Objective - Update the loading indicator to match the new reskin. Originally I had read this story wrong and was implementing this app-wide for the full screen loading but after a sync with Dave I realized this ticket is much smaller in size. - Using the existing `CircularProgressIndicator` and updated the `trackColor` property to match the new reskin color. Confirmed with Emily this looks good for this particular ticket. ## 📸 Screenshots https://github.com/user-attachments/assets/e450a79f-818d-4978-951b-1f0f093d6809 ## ⏰ Reminders before review - Contributor guidelines followed - All formatters and local linters executed and passed - Written new unit and / or integration tests where applicable - Used internationalization (i18n) for all UI strings - CI builds passed - Communicated to DevOps any deployment requirements - Updated any necessary documentation or informed the documentation team ## 🦮 Reviewer guidelines  - 👍 (`:+1:`) or similar for great changes - 📝 (`:memo:`) or ℹ️ (`:information_source:`) for notes or general info - ❓ (`:question:`) for questions - 🤔 (`:thinking:`) or 💭 (`:thought_balloon:`) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion - 🎨 (`:art:`) for suggestions / improvements - ❌ (`:x:`) or ⚠️ (`:warning:`) for more significant problems or concerns needing attention - 🌱 (`:seedling:`) or ♻️ (`:recycle:`) for future improvements or indications of technical debt - ⛏ (`:pick:`) for minor or nitpick changes [PM-16830]: https://bitwarden.atlassian.net/browse/PM-16830?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

GiteaMirror added the pull-request label 2025-11-26 23:53:10 -06:00

GiteaMirror closed this issue