github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-03-19 13:36:39 -05:00
Code Issues 144 Packages Projects Releases 116 Wiki Activity

[PR #3957] [MERGED] [PM-7587] Support conditionally loading local sdk #4558

New Issue
Closed
opened 2025-11-26 23:46:29 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-26 23:46:29 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/3957
Author: @Hinton
Created: 9/24/2024
Status: ✅ Merged
Merged: 9/26/2024
Merged by: @Hinton

Base: main ← Head: ps/local-sdk-conditional

📝 Commits (5)

  • 4816865 Conditionally replace sdk with local version
  • f9edc55 Switch to using user.properties
  • be5bfad Added some text about using local sdk build.
  • 299bfcb Move section in readme
  • 64f3d9d Reword sentance

📊 Changes

3 files changed (+26 additions, -1 deletions)

View changed files

📝 README.md (+1 -0)
📝 app/build.gradle.kts (+22 -1)
📝 settings.gradle.kts (+3 -0)

📄 Description

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-7587

📔 Objective

For development purposes it can be beneficial to build against a local SDK build instead of the published artifacts. This utilizes the dependencySubstitution functionality of gradle to swap out the remote SDK dependency with a local version from your local maven artifactory if localSdk is set in user properties.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed
    issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/3957 **Author:** [@Hinton](https://github.com/Hinton) **Created:** 9/24/2024 **Status:** ✅ Merged **Merged:** 9/26/2024 **Merged by:** [@Hinton](https://github.com/Hinton) **Base:** `main` ← **Head:** `ps/local-sdk-conditional` --- ### 📝 Commits (5) - [`4816865`](https://github.com/bitwarden/android/commit/4816865561bceeebcf480966b2905c57fbb7db38) Conditionally replace sdk with local version - [`f9edc55`](https://github.com/bitwarden/android/commit/f9edc55c39c379409dbe28f2bc587679ae264a6c) Switch to using user.properties - [`be5bfad`](https://github.com/bitwarden/android/commit/be5bfad40f77de9b61299e588008bac940cbebe3) Added some text about using local sdk build. - [`299bfcb`](https://github.com/bitwarden/android/commit/299bfcb1d71e90a010cb1b531da4647ebc11ee55) Move section in readme - [`64f3d9d`](https://github.com/bitwarden/android/commit/64f3d9d9f554da361d4327f17ff221f690c4ab7d) Reword sentance ### 📊 Changes **3 files changed** (+26 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `README.md` (+1 -0) 📝 `app/build.gradle.kts` (+22 -1) 📝 `settings.gradle.kts` (+3 -0) </details> ### 📄 Description ## 🎟️ Tracking <!-- Paste the link to the Jira or GitHub issue or otherwise describe / point to where this change is coming from. --> https://bitwarden.atlassian.net/browse/PM-7587 ## 📔 Objective <!-- Describe what the purpose of this PR is, for example what bug you're fixing or new feature you're adding. --> For development purposes it can be beneficial to build against a local SDK build instead of the published artifacts. This utilizes the `dependencySubstitution` functionality of gradle to swap out the remote SDK dependency with a local version from your local maven artifactory if `localSdk` is set in user properties. ## ⏰ Reminders before review - Contributor guidelines followed - All formatters and local linters executed and passed - Written new unit and / or integration tests where applicable - Used internationalization (i18n) for all UI strings - CI builds passed - Communicated to DevOps any deployment requirements - Updated any necessary documentation or informed the documentation team ## 🦮 Reviewer guidelines <!-- Suggested interactions but feel free to use (or not) as you desire! --> - 👍 (`:+1:`) or similar for great changes - 📝 (`:memo:`) or ℹ️ (`:information_source:`) for notes or general info - ❓ (`:question:`) for questions - 🤔 (`:thinking:`) or 💭 (`:thought_balloon:`) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion - 🎨 (`:art:`) for suggestions / improvements - ❌ (`:x:`) or ⚠️ (`:warning:`) for more significant problems or concerns needing attention - 🌱 (`:seedling:`) or ♻️ (`:recycle:`) for future improvements or indications of technical debt - ⛏ (`:pick:`) for minor or nitpick changes --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-26 23:46:29 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#4558
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?