github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-03-11 20:54:58 -05:00
Code Issues 144 Packages Projects Releases 116 Wiki Activity

[PR #4539] [MERGED] [PM-13349] Hide Edit option in cipher list item overflow when editing not permitted #5025

New Issue
Closed
opened 2025-11-26 23:53:00 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-26 23:53:00 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/4539
Author: @mpbw2
Created: 1/9/2025
Status: ✅ Merged
Merged: 1/9/2025
Merged by: @mpbw2

Base: main ← Head: pm-13349/hide-edit-overflow-readonly

📝 Commits (3)

  • baa79c8 Hide Edit option in cipher list item overflow when editing not permitted
  • d0ae33a formatting
  • 394087b added tests

📊 Changes

2 files changed (+59 additions, -1 deletions)

View changed files

📝 app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/util/CipherViewExtensions.kt (+1 -1)
📝 app/src/test/java/com/x8bit/bitwarden/ui/vault/feature/util/CipherViewExtensionsTest.kt (+58 -0)

📄 Description

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-13349

📔 Objective

Hide Edit option in cipher list item overflow when editing not permitted (accompanies #4430)

📸 Screenshots

Screenshot 2025-01-09 at 12 48 02 PM

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed
    issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/4539 **Author:** [@mpbw2](https://github.com/mpbw2) **Created:** 1/9/2025 **Status:** ✅ Merged **Merged:** 1/9/2025 **Merged by:** [@mpbw2](https://github.com/mpbw2) **Base:** `main` ← **Head:** `pm-13349/hide-edit-overflow-readonly` --- ### 📝 Commits (3) - [`baa79c8`](https://github.com/bitwarden/android/commit/baa79c8aceb26e7f721648793379320ff3224c9d) Hide Edit option in cipher list item overflow when editing not permitted - [`d0ae33a`](https://github.com/bitwarden/android/commit/d0ae33aedb18e457c086b605004cf3cd00c08f64) formatting - [`394087b`](https://github.com/bitwarden/android/commit/394087b062bde11f4587440516ae70df98531fa3) added tests ### 📊 Changes **2 files changed** (+59 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/util/CipherViewExtensions.kt` (+1 -1) 📝 `app/src/test/java/com/x8bit/bitwarden/ui/vault/feature/util/CipherViewExtensionsTest.kt` (+58 -0) </details> ### 📄 Description ## 🎟️ Tracking https://bitwarden.atlassian.net/browse/PM-13349 ## 📔 Objective Hide Edit option in cipher list item overflow when editing not permitted (accompanies #4430) ## 📸 Screenshots ![Screenshot 2025-01-09 at 12 48 02 PM](https://github.com/user-attachments/assets/f139b397-facf-4c69-9ddc-9c2233031d16) ## ⏰ Reminders before review - Contributor guidelines followed - All formatters and local linters executed and passed - Written new unit and / or integration tests where applicable - Used internationalization (i18n) for all UI strings - CI builds passed - Communicated to DevOps any deployment requirements - Updated any necessary documentation or informed the documentation team ## 🦮 Reviewer guidelines <!-- Suggested interactions but feel free to use (or not) as you desire! --> - 👍 (`:+1:`) or similar for great changes - 📝 (`:memo:`) or ℹ️ (`:information_source:`) for notes or general info - ❓ (`:question:`) for questions - 🤔 (`:thinking:`) or 💭 (`:thought_balloon:`) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion - 🎨 (`:art:`) for suggestions / improvements - ❌ (`:x:`) or ⚠️ (`:warning:`) for more significant problems or concerns needing attention - 🌱 (`:seedling:`) or ♻️ (`:recycle:`) for future improvements or indications of technical debt - ⛏ (`:pick:`) for minor or nitpick changes --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-26 23:53:00 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#5025
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?