github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-03-16 16:57:18 -05:00
Code Issues 144 Packages Projects Releases 116 Wiki Activity

[PR #3936] [MERGED] [PM-10671] update password generator policy #4539

New Issue
Closed
opened 2025-11-26 23:46:09 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-26 23:46:09 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/3936
Author: @aj-rosado
Created: 9/18/2024
Status: ✅ Merged
Merged: 9/24/2024
Merged by: @aj-rosado

Base: main ← Head: PM-10671/update-password-generator-policy

📝 Commits (6)

  • d7b6a1e rename defaultType to overridePasswordType
  • 304765b Forcing overridePasswordType selected option on the generator screen
  • 3ef479b Removed unused getPasswordGeneratorPolicy method
  • ca6e822 Merge branch 'main' into PM-10671/update-password-generator-policy
  • d812d1d fix formatting issues
  • 4f3337b added tests to validate overridePassword and passcode.selectedType properly follow policies

📊 Changes

11 files changed (+155 additions, -225 deletions)

View changed files

📝 app/src/main/java/com/x8bit/bitwarden/data/auth/repository/model/PolicyInformation.kt (+3 -3)
📝 app/src/main/java/com/x8bit/bitwarden/data/tools/generator/repository/GeneratorRepository.kt (+0 -6)
📝 app/src/main/java/com/x8bit/bitwarden/data/tools/generator/repository/GeneratorRepositoryImpl.kt (+0 -70)
📝 app/src/main/java/com/x8bit/bitwarden/ui/tools/feature/generator/GeneratorScreen.kt (+5 -1)
📝 app/src/main/java/com/x8bit/bitwarden/ui/tools/feature/generator/GeneratorViewModel.kt (+18 -2)
📝 app/src/main/java/com/x8bit/bitwarden/ui/tools/feature/generator/util/PolicyInformationPasswordGeneratorExtensions.kt (+9 -1)
📝 app/src/test/java/com/x8bit/bitwarden/data/auth/repository/util/SyncResponseJsonExtensionsTest.kt (+1 -1)
📝 app/src/test/java/com/x8bit/bitwarden/data/tools/generator/repository/GeneratorRepositoryTest.kt (+0 -102)
📝 app/src/test/java/com/x8bit/bitwarden/data/tools/generator/repository/util/FakeGeneratorRepository.kt (+0 -8)
📝 app/src/test/java/com/x8bit/bitwarden/ui/tools/feature/generator/GeneratorViewModelTest.kt (+75 -27)
📝 app/src/test/java/com/x8bit/bitwarden/ui/tools/feature/generator/util/PolicyInformationPasswordGeneratorExtensionsTest.kt (+44 -4)

📄 Description

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-10671

📔 Objective

Renaming property defaultValue to overridePasswordType as it is the name used on the other clients
Updating the behaviour so that it forces the user to use the overridePasswordType.
Removed getPasswordGeneratorPolicy, it is not used as the policies are retrieved by the PolicyManager

📸 Screenshots

https://github.com/user-attachments/assets/de21db03-c42f-457f-9ade-ad54f817790a

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed
    issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/3936 **Author:** [@aj-rosado](https://github.com/aj-rosado) **Created:** 9/18/2024 **Status:** ✅ Merged **Merged:** 9/24/2024 **Merged by:** [@aj-rosado](https://github.com/aj-rosado) **Base:** `main` ← **Head:** `PM-10671/update-password-generator-policy` --- ### 📝 Commits (6) - [`d7b6a1e`](https://github.com/bitwarden/android/commit/d7b6a1e207408e2be31987af62271c00637adaf2) rename defaultType to overridePasswordType - [`304765b`](https://github.com/bitwarden/android/commit/304765bd0f881fb3d896d7f862be6662360b9283) Forcing overridePasswordType selected option on the generator screen - [`3ef479b`](https://github.com/bitwarden/android/commit/3ef479ba16745d11c75e3803addf4883c7ae6ce0) Removed unused getPasswordGeneratorPolicy method - [`ca6e822`](https://github.com/bitwarden/android/commit/ca6e822dcc46688395c3619093c96ebd3f99ec60) Merge branch 'main' into PM-10671/update-password-generator-policy - [`d812d1d`](https://github.com/bitwarden/android/commit/d812d1d9dfa2bc3bfbd2a0eaac9499de7e0b3d21) fix formatting issues - [`4f3337b`](https://github.com/bitwarden/android/commit/4f3337b4f6687aeacd9be24ed1355a351daa085b) added tests to validate overridePassword and passcode.selectedType properly follow policies ### 📊 Changes **11 files changed** (+155 additions, -225 deletions) <details> <summary>View changed files</summary> 📝 `app/src/main/java/com/x8bit/bitwarden/data/auth/repository/model/PolicyInformation.kt` (+3 -3) 📝 `app/src/main/java/com/x8bit/bitwarden/data/tools/generator/repository/GeneratorRepository.kt` (+0 -6) 📝 `app/src/main/java/com/x8bit/bitwarden/data/tools/generator/repository/GeneratorRepositoryImpl.kt` (+0 -70) 📝 `app/src/main/java/com/x8bit/bitwarden/ui/tools/feature/generator/GeneratorScreen.kt` (+5 -1) 📝 `app/src/main/java/com/x8bit/bitwarden/ui/tools/feature/generator/GeneratorViewModel.kt` (+18 -2) 📝 `app/src/main/java/com/x8bit/bitwarden/ui/tools/feature/generator/util/PolicyInformationPasswordGeneratorExtensions.kt` (+9 -1) 📝 `app/src/test/java/com/x8bit/bitwarden/data/auth/repository/util/SyncResponseJsonExtensionsTest.kt` (+1 -1) 📝 `app/src/test/java/com/x8bit/bitwarden/data/tools/generator/repository/GeneratorRepositoryTest.kt` (+0 -102) 📝 `app/src/test/java/com/x8bit/bitwarden/data/tools/generator/repository/util/FakeGeneratorRepository.kt` (+0 -8) 📝 `app/src/test/java/com/x8bit/bitwarden/ui/tools/feature/generator/GeneratorViewModelTest.kt` (+75 -27) 📝 `app/src/test/java/com/x8bit/bitwarden/ui/tools/feature/generator/util/PolicyInformationPasswordGeneratorExtensionsTest.kt` (+44 -4) </details> ### 📄 Description ## 🎟️ Tracking https://bitwarden.atlassian.net/browse/PM-10671 ## 📔 Objective Renaming property `defaultValue` to `overridePasswordType` as it is the name used on the other clients Updating the behaviour so that it forces the user to use the `overridePasswordType`. Removed `getPasswordGeneratorPolicy`, it is not used as the policies are retrieved by the `PolicyManager` ## 📸 Screenshots https://github.com/user-attachments/assets/de21db03-c42f-457f-9ade-ad54f817790a ## ⏰ Reminders before review - Contributor guidelines followed - All formatters and local linters executed and passed - Written new unit and / or integration tests where applicable - Used internationalization (i18n) for all UI strings - CI builds passed - Communicated to DevOps any deployment requirements - Updated any necessary documentation or informed the documentation team ## 🦮 Reviewer guidelines <!-- Suggested interactions but feel free to use (or not) as you desire! --> - 👍 (`:+1:`) or similar for great changes - 📝 (`:memo:`) or ℹ️ (`:information_source:`) for notes or general info - ❓ (`:question:`) for questions - 🤔 (`:thinking:`) or 💭 (`:thought_balloon:`) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion - 🎨 (`:art:`) for suggestions / improvements - ❌ (`:x:`) or ⚠️ (`:warning:`) for more significant problems or concerns needing attention - 🌱 (`:seedling:`) or ♻️ (`:recycle:`) for future improvements or indications of technical debt - ⛏ (`:pick:`) for minor or nitpick changes --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-26 23:46:09 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#4539
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?