github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-03-09 11:44:41 -05:00
Code Issues 144 Packages Projects Releases 116 Wiki Activity

[PR #4527] [MERGED] [PM-16695] Learn more new device verification #5015

New Issue
Closed
opened 2025-11-26 23:52:53 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-26 23:52:53 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/4527
Author: @aj-rosado
Created: 1/7/2025
Status: ✅ Merged
Merged: 1/9/2025
Merged by: @aj-rosado

Base: main ← Head: PM-16695/lean-more-new-device-verification

📝 Commits (6)

  • d2a199c Added "learn more" link to NewDeviceNoticeEmailAccess
  • 02d3c19 [PM-8217] Add local feature flag to ignore environment validation (#4516)
  • 0c0509f [PM-15969] Users with Can Edit access cannot assign collections (#4512)
  • ad6885c Merge branch 'release/2024.12-rc13' into PM-16695/lean-more-new-device-verification
  • f681b6f Merge branch 'main' into PM-16695/lean-more-new-device-verification
  • 3ab1513 Added remember viewmodel on NewDeviceNoticeEmailAccessScreen

📊 Changes

4 files changed (+75 additions, -3 deletions)

View changed files

📝 app/src/main/java/com/x8bit/bitwarden/ui/auth/feature/newdevicenotice/NewDeviceNoticeEmailAccessScreen.kt (+32 -3)
📝 app/src/main/java/com/x8bit/bitwarden/ui/auth/feature/newdevicenotice/NewDeviceNoticeEmailAccessViewModel.kt (+16 -0)
📝 app/src/test/java/com/x8bit/bitwarden/ui/auth/feature/newdevicenotice/NewDeviceNoticeEmailAccessScreenTest.kt (+17 -0)
📝 app/src/test/java/com/x8bit/bitwarden/ui/auth/feature/newdevicenotice/NewDeviceNoticeEmailAccessViewModelTest.kt (+10 -0)

📄 Description

Backport #4520

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-16695

📔 Objective

Added a "learn more" button that redirects the user into https://bitwarden.com/help/new-device-verification/

📸 Screenshots

New device verification with 'More info' link

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed
    issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/4527 **Author:** [@aj-rosado](https://github.com/aj-rosado) **Created:** 1/7/2025 **Status:** ✅ Merged **Merged:** 1/9/2025 **Merged by:** [@aj-rosado](https://github.com/aj-rosado) **Base:** `main` ← **Head:** `PM-16695/lean-more-new-device-verification` --- ### 📝 Commits (6) - [`d2a199c`](https://github.com/bitwarden/android/commit/d2a199cd14d6f57a841b7914b04830351d8622d3) Added "learn more" link to NewDeviceNoticeEmailAccess - [`02d3c19`](https://github.com/bitwarden/android/commit/02d3c19e1cbbb93122c436b45d35878d3b21c72e) [PM-8217] Add local feature flag to ignore environment validation (#4516) - [`0c0509f`](https://github.com/bitwarden/android/commit/0c0509f5671773246d8913bf722bcd5f3e13ceb4) [PM-15969] Users with `Can Edit` access cannot assign collections (#4512) - [`ad6885c`](https://github.com/bitwarden/android/commit/ad6885cf31a3a53ff7f9b6163e58a42ab29bbca9) Merge branch 'release/2024.12-rc13' into PM-16695/lean-more-new-device-verification - [`f681b6f`](https://github.com/bitwarden/android/commit/f681b6ffea744465794b2b24ede53598732f6b5e) Merge branch 'main' into PM-16695/lean-more-new-device-verification - [`3ab1513`](https://github.com/bitwarden/android/commit/3ab1513adf7420fb81d51b466c42ff620908c303) Added remember viewmodel on NewDeviceNoticeEmailAccessScreen ### 📊 Changes **4 files changed** (+75 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `app/src/main/java/com/x8bit/bitwarden/ui/auth/feature/newdevicenotice/NewDeviceNoticeEmailAccessScreen.kt` (+32 -3) 📝 `app/src/main/java/com/x8bit/bitwarden/ui/auth/feature/newdevicenotice/NewDeviceNoticeEmailAccessViewModel.kt` (+16 -0) 📝 `app/src/test/java/com/x8bit/bitwarden/ui/auth/feature/newdevicenotice/NewDeviceNoticeEmailAccessScreenTest.kt` (+17 -0) 📝 `app/src/test/java/com/x8bit/bitwarden/ui/auth/feature/newdevicenotice/NewDeviceNoticeEmailAccessViewModelTest.kt` (+10 -0) </details> ### 📄 Description Backport [#4520 ](https://github.com/bitwarden/android/pull/4520) ## 🎟️ Tracking https://bitwarden.atlassian.net/browse/PM-16695 ## 📔 Objective Added a "learn more" button that redirects the user into https://bitwarden.com/help/new-device-verification/ ## 📸 Screenshots <img width="314" alt="New device verification with 'More info' link" src="https://github.com/user-attachments/assets/711f3a15-fd92-4ec0-b0b7-0b647da3af26" > ## ⏰ Reminders before review - Contributor guidelines followed - All formatters and local linters executed and passed - Written new unit and / or integration tests where applicable - Used internationalization (i18n) for all UI strings - CI builds passed - Communicated to DevOps any deployment requirements - Updated any necessary documentation or informed the documentation team ## 🦮 Reviewer guidelines <!-- Suggested interactions but feel free to use (or not) as you desire! --> - 👍 (`:+1:`) or similar for great changes - 📝 (`:memo:`) or ℹ️ (`:information_source:`) for notes or general info - ❓ (`:question:`) for questions - 🤔 (`:thinking:`) or 💭 (`:thought_balloon:`) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion - 🎨 (`:art:`) for suggestions / improvements - ❌ (`:x:`) or ⚠️ (`:warning:`) for more significant problems or concerns needing attention - 🌱 (`:seedling:`) or ♻️ (`:recycle:`) for future improvements or indications of technical debt - ⛏ (`:pick:`) for minor or nitpick changes --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-26 23:52:53 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#5015
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?