github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-03-10 12:13:43 -05:00
Code Issues 144 Packages Projects Releases 116 Wiki Activity

[PR #3909] [MERGED] BITAU-108 Add unlockWithAuthenticatorSyncKey to VaultRepository #4516

New Issue
Closed
opened 2025-11-26 23:45:46 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-26 23:45:46 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/3909
Author: @ahaisting-livefront
Created: 9/11/2024
Status: ✅ Merged
Merged: 9/18/2024
Merged by: @ahaisting-livefront

Base: main ← Head: vault-unlock

📝 Commits (5)

  • 64c1c18 BITAU-108 Add unlockWithAuthenticatorSyncKey to VaultRepository
  • 8d6ba24 rename decryptedAuthenticatorSyncKey -> decryptedUserKey
  • bd17877 remove deriveTemporaryPinProtectedUserKeyIfNecessary and udpate tests
  • 780faf2 adjust naming around unlockVaultWithDecryptedUserKey
  • 71357ee also update test names

📊 Changes

3 files changed (+116 additions, -0 deletions)

View changed files

📝 app/src/main/java/com/x8bit/bitwarden/data/vault/repository/VaultRepository.kt (+12 -0)
📝 app/src/main/java/com/x8bit/bitwarden/data/vault/repository/VaultRepositoryImpl.kt (+10 -0)
📝 app/src/test/java/com/x8bit/bitwarden/data/vault/repository/VaultRepositoryTest.kt (+94 -0)

📄 Description

🎟️ Tracking

https://livefront.atlassian.net/browse/BITAU-108

📔 Objective

I had previously missed this requirement for this ticket:

"A function is added to VaultRepository / VaultLockManager that allows for this per-user key to be used to unlock a particular user's vault."

📸 Screenshots

N/A

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed
    issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/3909 **Author:** [@ahaisting-livefront](https://github.com/ahaisting-livefront) **Created:** 9/11/2024 **Status:** ✅ Merged **Merged:** 9/18/2024 **Merged by:** [@ahaisting-livefront](https://github.com/ahaisting-livefront) **Base:** `main` ← **Head:** `vault-unlock` --- ### 📝 Commits (5) - [`64c1c18`](https://github.com/bitwarden/android/commit/64c1c1828f0fe5f0bc79886063847e9aee5f86bc) BITAU-108 Add unlockWithAuthenticatorSyncKey to VaultRepository - [`8d6ba24`](https://github.com/bitwarden/android/commit/8d6ba24d0e4e97ee7442b2bb78dfc7f2c5c5722e) rename decryptedAuthenticatorSyncKey -> decryptedUserKey - [`bd17877`](https://github.com/bitwarden/android/commit/bd178778f4c8b17ea50de824327b4ef633e9f690) remove deriveTemporaryPinProtectedUserKeyIfNecessary and udpate tests - [`780faf2`](https://github.com/bitwarden/android/commit/780faf2d099ef9b9e4e2cd43922691cc77c57fa7) adjust naming around unlockVaultWithDecryptedUserKey - [`71357ee`](https://github.com/bitwarden/android/commit/71357ee2f2fc39c91a6b85a3d798cd7b50f21b85) also update test names ### 📊 Changes **3 files changed** (+116 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `app/src/main/java/com/x8bit/bitwarden/data/vault/repository/VaultRepository.kt` (+12 -0) 📝 `app/src/main/java/com/x8bit/bitwarden/data/vault/repository/VaultRepositoryImpl.kt` (+10 -0) 📝 `app/src/test/java/com/x8bit/bitwarden/data/vault/repository/VaultRepositoryTest.kt` (+94 -0) </details> ### 📄 Description ## 🎟️ Tracking https://livefront.atlassian.net/browse/BITAU-108 ## 📔 Objective I had previously missed this requirement for this ticket: "A function is added to `VaultRepository` / `VaultLockManager` that allows for this per-user key to be used to unlock a particular user's vault." ## 📸 Screenshots N/A ## ⏰ Reminders before review - Contributor guidelines followed - All formatters and local linters executed and passed - Written new unit and / or integration tests where applicable - Used internationalization (i18n) for all UI strings - CI builds passed - Communicated to DevOps any deployment requirements - Updated any necessary documentation or informed the documentation team ## 🦮 Reviewer guidelines <!-- Suggested interactions but feel free to use (or not) as you desire! --> - 👍 (`:+1:`) or similar for great changes - 📝 (`:memo:`) or ℹ️ (`:information_source:`) for notes or general info - ❓ (`:question:`) for questions - 🤔 (`:thinking:`) or 💭 (`:thought_balloon:`) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion - 🎨 (`:art:`) for suggestions / improvements - ❌ (`:x:`) or ⚠️ (`:warning:`) for more significant problems or concerns needing attention - 🌱 (`:seedling:`) or ♻️ (`:recycle:`) for future improvements or indications of technical debt - ⛏ (`:pick:`) for minor or nitpick changes --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-26 23:45:46 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#4516
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?