github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-03-09 19:54:19 -05:00
Code Issues 144 Packages Projects Releases 116 Wiki Activity

[PR #4188] [MERGED] QA-970: Adding testTags for radiobutton and floating options elements #4761

New Issue
Closed
opened 2025-11-26 23:49:24 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-26 23:49:24 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/4188
Author: @ifernandezdiaz
Created: 10/29/2024
Status: ✅ Merged
Merged: 11/1/2024
Merged by: @david-livefront

Base: main ← Head: QA-970/adding-testtags-to-overflow-components

📝 Commits (10+)

  • d0b6b5f Adding testTags for radiobutton and floating options elements
  • 11543b7 removing testTag var in OverflowMenuItemData
  • 49c9cc5 [deps]: Update gh minor (#4173)
  • 8b52d25 [deps]: Update com.google.devtools.ksp to v2.0.21-1.0.26 (#4172)
  • 13dfaab QA-953: Adding testTag to elements in Add TOTP screen (#4160)
  • b01943c PM-13698 only dismiss the card if the user dismisses or completes the… (#4165)
  • d0cac44 PM-14184: Update the switch thoughout the app (#4170)
  • 14a1168 [PM-13908] Disable ExtraTranslation lint warning (#4176)
  • 296ee17 PM-14009 complete fix importlogins card show logic (#4175)
  • 7d89044 PM-13908 fixing copy on step2 and step3 and making vault url dynamic (#4154)

📊 Changes

8 files changed (+10 additions, -14 deletions)

View changed files

📝 app/src/main/java/com/x8bit/bitwarden/ui/platform/components/appbar/BitwardenSearchTopAppBar.kt (+1 -0)
📝 app/src/main/java/com/x8bit/bitwarden/ui/platform/components/appbar/action/BitwardenOverflowActionItem.kt (+3 -8)
📝 app/src/main/java/com/x8bit/bitwarden/ui/platform/components/dialog/row/BitwardenSelectionRow.kt (+3 -0)
📝 app/src/main/java/com/x8bit/bitwarden/ui/platform/components/listitem/BitwardenListItem.kt (+2 -1)
📝 app/src/main/java/com/x8bit/bitwarden/ui/platform/feature/search/SearchScreen.kt (+0 -2)
📝 app/src/main/java/com/x8bit/bitwarden/ui/tools/feature/generator/passwordhistory/PasswordHistoryScreen.kt (+0 -1)
📝 app/src/main/java/com/x8bit/bitwarden/ui/tools/feature/send/SendListItem.kt (+0 -1)
📝 app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/vault/VaultContent.kt (+1 -1)

📄 Description

🎟️ Tracking

📔 Objective

This work is a subtask of QA-947, a story created to group all the native app views that contain elements without Automation IDs.
NOTE: Not all the elements will require an AutomationID. We are adding the ones we currently need so we can reduce the flakiness on some critical Mobile e2e tests

📸 Screenshots

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed
    issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/4188 **Author:** [@ifernandezdiaz](https://github.com/ifernandezdiaz) **Created:** 10/29/2024 **Status:** ✅ Merged **Merged:** 11/1/2024 **Merged by:** [@david-livefront](https://github.com/david-livefront) **Base:** `main` ← **Head:** `QA-970/adding-testtags-to-overflow-components` --- ### 📝 Commits (10+) - [`d0b6b5f`](https://github.com/bitwarden/android/commit/d0b6b5f50196d0b6af4b1fb3515f07b63a33513b) Adding testTags for radiobutton and floating options elements - [`11543b7`](https://github.com/bitwarden/android/commit/11543b7503e0a7ac2885130c9c9285570cf2f23a) removing testTag var in OverflowMenuItemData - [`49c9cc5`](https://github.com/bitwarden/android/commit/49c9cc557710cc9bebe7259411d2c1ea02801185) [deps]: Update gh minor (#4173) - [`8b52d25`](https://github.com/bitwarden/android/commit/8b52d256ffc4655e66252172de52647cd25917f9) [deps]: Update com.google.devtools.ksp to v2.0.21-1.0.26 (#4172) - [`13dfaab`](https://github.com/bitwarden/android/commit/13dfaab04381e6c9cb8be3bc7fafbaf43b2092a7) QA-953: Adding testTag to elements in Add TOTP screen (#4160) - [`b01943c`](https://github.com/bitwarden/android/commit/b01943cb6ddd2e83a036d01370ae83b0ba8eee60) PM-13698 only dismiss the card if the user dismisses or completes the… (#4165) - [`d0cac44`](https://github.com/bitwarden/android/commit/d0cac441c4b149e55074da26216c8c39671f60d6) PM-14184: Update the switch thoughout the app (#4170) - [`14a1168`](https://github.com/bitwarden/android/commit/14a11680b12c63395fda3c6359dfb0d54e5470af) [PM-13908] Disable ExtraTranslation lint warning (#4176) - [`296ee17`](https://github.com/bitwarden/android/commit/296ee17211189662db9feec66f1481aff21495d0) PM-14009 complete fix importlogins card show logic (#4175) - [`7d89044`](https://github.com/bitwarden/android/commit/7d89044183a2b2c71a487ec47db38f687eeed0da) PM-13908 fixing copy on step2 and step3 and making vault url dynamic (#4154) ### 📊 Changes **8 files changed** (+10 additions, -14 deletions) <details> <summary>View changed files</summary> 📝 `app/src/main/java/com/x8bit/bitwarden/ui/platform/components/appbar/BitwardenSearchTopAppBar.kt` (+1 -0) 📝 `app/src/main/java/com/x8bit/bitwarden/ui/platform/components/appbar/action/BitwardenOverflowActionItem.kt` (+3 -8) 📝 `app/src/main/java/com/x8bit/bitwarden/ui/platform/components/dialog/row/BitwardenSelectionRow.kt` (+3 -0) 📝 `app/src/main/java/com/x8bit/bitwarden/ui/platform/components/listitem/BitwardenListItem.kt` (+2 -1) 📝 `app/src/main/java/com/x8bit/bitwarden/ui/platform/feature/search/SearchScreen.kt` (+0 -2) 📝 `app/src/main/java/com/x8bit/bitwarden/ui/tools/feature/generator/passwordhistory/PasswordHistoryScreen.kt` (+0 -1) 📝 `app/src/main/java/com/x8bit/bitwarden/ui/tools/feature/send/SendListItem.kt` (+0 -1) 📝 `app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/vault/VaultContent.kt` (+1 -1) </details> ### 📄 Description ## 🎟️ Tracking <!-- Paste the link to the Jira or GitHub issue or otherwise describe / point to where this change is coming from. --> ## 📔 Objective This work is a subtask of [QA-947](https://bitwarden.atlassian.net/browse/QA-947), a story created to group all the native app views that contain elements without Automation IDs. NOTE: Not all the elements will require an AutomationID. We are adding the ones we currently need so we can reduce the flakiness on some critical Mobile e2e tests ## 📸 Screenshots <!-- Required for any UI changes; delete if not applicable. Use fixed width images for better display. --> ## ⏰ Reminders before review - Contributor guidelines followed - All formatters and local linters executed and passed - Written new unit and / or integration tests where applicable - Used internationalization (i18n) for all UI strings - CI builds passed - Communicated to DevOps any deployment requirements - Updated any necessary documentation or informed the documentation team ## 🦮 Reviewer guidelines <!-- Suggested interactions but feel free to use (or not) as you desire! --> - 👍 (`:+1:`) or similar for great changes - 📝 (`:memo:`) or ℹ️ (`:information_source:`) for notes or general info - ❓ (`:question:`) for questions - 🤔 (`:thinking:`) or 💭 (`:thought_balloon:`) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion - 🎨 (`:art:`) for suggestions / improvements - ❌ (`:x:`) or ⚠️ (`:warning:`) for more significant problems or concerns needing attention - 🌱 (`:seedling:`) or ♻️ (`:recycle:`) for future improvements or indications of technical debt - ⛏ (`:pick:`) for minor or nitpick changes [QA-947]: https://bitwarden.atlassian.net/browse/QA-947?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-26 23:49:24 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#4761
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?