github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-05-07 19:39:41 -05:00
Code Issues 1.1k Packages Projects Releases 122 Wiki Activity

[PR #4761] [MERGED] [PM-15149] Remove ssh feature flag #31199

New Issue
Closed
opened 2026-04-18 14:49:13 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-18 14:49:13 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/4761
Author: @quexten
Created: 2/21/2025
Status: ✅ Merged
Merged: 2/25/2025
Merged by: @SaintPatrck

Base: main ← Head: km/pm-15149/remove-ssh-featureflag

📝 Commits (7)

  • 8703793 Remove ssh feature flag
  • b87cdba Attempt to fix tests
  • f31b6db Fix tests
  • 3425152 Fix tests
  • e569530 Merge branch 'main' into km/pm-15149/remove-ssh-featureflag
  • 0aef9df Remove ssh_key_cipher_item_types from strings.xml
  • 7eaed31 Merge branch 'km/pm-15149/remove-ssh-featureflag' of github.com:bitwarden/android into km/pm-15149/remove-ssh-featureflag

📊 Changes

12 files changed (+39 additions, -236 deletions)

View changed files

📝 app/src/main/java/com/x8bit/bitwarden/data/platform/manager/model/FlagKey.kt (+0 -10)
📝 app/src/main/java/com/x8bit/bitwarden/ui/platform/feature/debugmenu/components/FeatureFlagListItems.kt (+0 -2)
📝 app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/vault/VaultContent.kt (+15 -22)
📝 app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/vault/VaultScreen.kt (+0 -1)
📝 app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/vault/VaultViewModel.kt (+6 -28)
📝 app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/vault/util/VaultDataExtensions.kt (+1 -21)
📝 app/src/main/res/values/strings.xml (+0 -1)
📝 app/src/test/java/com/x8bit/bitwarden/data/platform/manager/FlagKeyTest.kt (+0 -6)
📝 app/src/test/java/com/x8bit/bitwarden/ui/platform/feature/debugmenu/DebugMenuViewModelTest.kt (+0 -2)
📝 app/src/test/java/com/x8bit/bitwarden/ui/vault/feature/vault/VaultScreenTest.kt (+0 -16)
📝 app/src/test/java/com/x8bit/bitwarden/ui/vault/feature/vault/VaultViewModelTest.kt (+5 -57)
📝 app/src/test/java/com/x8bit/bitwarden/ui/vault/feature/vault/util/VaultDataExtensionsTest.kt (+12 -70)

📄 Description

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-15149

📔 Objective

Removes the ssh feature flag that decides whether the ssh key item type is displayed. This feature is rolled out on cloud.

📸 Screenshots

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed
    issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/4761 **Author:** [@quexten](https://github.com/quexten) **Created:** 2/21/2025 **Status:** ✅ Merged **Merged:** 2/25/2025 **Merged by:** [@SaintPatrck](https://github.com/SaintPatrck) **Base:** `main` ← **Head:** `km/pm-15149/remove-ssh-featureflag` --- ### 📝 Commits (7) - [`8703793`](https://github.com/bitwarden/android/commit/87037935f2f24cfa6d62350538e01999c30c27e4) Remove ssh feature flag - [`b87cdba`](https://github.com/bitwarden/android/commit/b87cdba68c77a9f868a1efe250683f61b3f8e66f) Attempt to fix tests - [`f31b6db`](https://github.com/bitwarden/android/commit/f31b6db5d6dd5d72ad1603feeaea568c33794180) Fix tests - [`3425152`](https://github.com/bitwarden/android/commit/3425152f16fad4a886c50a27cbaf0fae606ed6af) Fix tests - [`e569530`](https://github.com/bitwarden/android/commit/e5695303b33e356a9aed681672c6824bdee6535c) Merge branch 'main' into km/pm-15149/remove-ssh-featureflag - [`0aef9df`](https://github.com/bitwarden/android/commit/0aef9dff0d3ceb1de829c3459f15b0bb6108b861) Remove `ssh_key_cipher_item_types` from strings.xml - [`7eaed31`](https://github.com/bitwarden/android/commit/7eaed3110839f2127822db59f3ec9f62d61de1d6) Merge branch 'km/pm-15149/remove-ssh-featureflag' of github.com:bitwarden/android into km/pm-15149/remove-ssh-featureflag ### 📊 Changes **12 files changed** (+39 additions, -236 deletions) <details> <summary>View changed files</summary> 📝 `app/src/main/java/com/x8bit/bitwarden/data/platform/manager/model/FlagKey.kt` (+0 -10) 📝 `app/src/main/java/com/x8bit/bitwarden/ui/platform/feature/debugmenu/components/FeatureFlagListItems.kt` (+0 -2) 📝 `app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/vault/VaultContent.kt` (+15 -22) 📝 `app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/vault/VaultScreen.kt` (+0 -1) 📝 `app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/vault/VaultViewModel.kt` (+6 -28) 📝 `app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/vault/util/VaultDataExtensions.kt` (+1 -21) 📝 `app/src/main/res/values/strings.xml` (+0 -1) 📝 `app/src/test/java/com/x8bit/bitwarden/data/platform/manager/FlagKeyTest.kt` (+0 -6) 📝 `app/src/test/java/com/x8bit/bitwarden/ui/platform/feature/debugmenu/DebugMenuViewModelTest.kt` (+0 -2) 📝 `app/src/test/java/com/x8bit/bitwarden/ui/vault/feature/vault/VaultScreenTest.kt` (+0 -16) 📝 `app/src/test/java/com/x8bit/bitwarden/ui/vault/feature/vault/VaultViewModelTest.kt` (+5 -57) 📝 `app/src/test/java/com/x8bit/bitwarden/ui/vault/feature/vault/util/VaultDataExtensionsTest.kt` (+12 -70) </details> ### 📄 Description ## 🎟️ Tracking https://bitwarden.atlassian.net/browse/PM-15149 ## 📔 Objective Removes the ssh feature flag that decides whether the ssh key item type is displayed. This feature is rolled out on cloud. ## 📸 Screenshots <!-- Required for any UI changes; delete if not applicable. Use fixed width images for better display. --> ## ⏰ Reminders before review - Contributor guidelines followed - All formatters and local linters executed and passed - Written new unit and / or integration tests where applicable - Used internationalization (i18n) for all UI strings - CI builds passed - Communicated to DevOps any deployment requirements - Updated any necessary documentation or informed the documentation team ## 🦮 Reviewer guidelines <!-- Suggested interactions but feel free to use (or not) as you desire! --> - 👍 (`:+1:`) or similar for great changes - 📝 (`:memo:`) or ℹ️ (`:information_source:`) for notes or general info - ❓ (`:question:`) for questions - 🤔 (`:thinking:`) or 💭 (`:thought_balloon:`) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion - 🎨 (`:art:`) for suggestions / improvements - ❌ (`:x:`) or ⚠️ (`:warning:`) for more significant problems or concerns needing attention - 🌱 (`:seedling:`) or ♻️ (`:recycle:`) for future improvements or indications of technical debt - ⛏ (`:pick:`) for minor or nitpick changes --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-18 14:49:13 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#31199
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?