github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-03-12 21:24:24 -05:00
Code Issues 144 Packages Projects Releases 116 Wiki Activity

[PR #4124] [MERGED] [PM-13900] Track last database scheme change #4703

New Issue
Closed
opened 2025-11-26 23:48:37 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-26 23:48:37 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/4124
Author: @SaintPatrck
Created: 10/21/2024
Status: ✅ Merged
Merged: 10/24/2024
Merged by: @SaintPatrck

Base: main ← Head: PM-13900/collection-manage-property

📝 Commits (9)

  • 1e46681 [PM-13900] Track last database scheme change
  • 486b073 Merge branch 'main' into PM-13900/collection-manage-property
  • ce03fde Remove v4 scheme
  • 7292b50 [TEMP] Upload test reports on failure
  • d61e568 Unmockk static fun
  • d7cfbfb Merge remote-tracking branch 'origin/main' into PM-13900/collection-manage-property
  • fd24c9e Don't mock the clock! Yeeaaaaa boiiiiii!
  • 9ccd806 Merge remote-tracking branch 'origin/main' into PM-13900/collection-manage-property
  • 8869a41 Add docs

📊 Changes

16 files changed (+320 additions, -7 deletions)

View changed files

📝 app/src/main/java/com/x8bit/bitwarden/data/platform/datasource/disk/SettingsDiskSource.kt (+6 -0)
📝 app/src/main/java/com/x8bit/bitwarden/data/platform/datasource/disk/SettingsDiskSourceImpl.kt (+5 -0)
📝 app/src/main/java/com/x8bit/bitwarden/data/platform/datasource/disk/di/PlatformDiskModule.kt (+14 -1)
➕ app/src/main/java/com/x8bit/bitwarden/data/platform/manager/DatabaseSchemeManager.kt (+17 -0)
➕ app/src/main/java/com/x8bit/bitwarden/data/platform/manager/DatabaseSchemeManagerImpl.kt (+17 -0)
📝 app/src/main/java/com/x8bit/bitwarden/data/platform/manager/di/PlatformManagerModule.kt (+10 -0)
📝 app/src/main/java/com/x8bit/bitwarden/data/tools/generator/datasource/disk/di/GeneratorDiskModule.kt (+14 -1)
➕ app/src/main/java/com/x8bit/bitwarden/data/vault/datasource/disk/callback/DatabaseSchemeCallback.kt (+18 -0)
📝 app/src/main/java/com/x8bit/bitwarden/data/vault/datasource/disk/di/VaultDiskModule.kt (+9 -1)
📝 app/src/main/java/com/x8bit/bitwarden/data/vault/repository/VaultRepositoryImpl.kt (+17 -4)
📝 app/src/main/java/com/x8bit/bitwarden/data/vault/repository/di/VaultRepositoryModule.kt (+3 -0)
📝 app/src/test/java/com/x8bit/bitwarden/data/platform/datasource/disk/SettingsDiskSourceTest.kt (+49 -0)
📝 app/src/test/java/com/x8bit/bitwarden/data/platform/datasource/disk/util/FakeSettingsDiskSource.kt (+5 -0)
➕ app/src/test/java/com/x8bit/bitwarden/data/platform/manager/DatabaseSchemeManagerTest.kt (+45 -0)
➕ app/src/test/java/com/x8bit/bitwarden/data/vault/datasource/disk/callback/DatabaseSchemeCallbackTest.kt (+32 -0)
📝 app/src/test/java/com/x8bit/bitwarden/data/vault/repository/VaultRepositoryTest.kt (+59 -0)

📄 Description

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-13900

📔 Objective

This change introduces a mechanism to track the last time a database scheme change was applied.

  • It adds a DatabaseSchemeCallback to update a timestamp in shared preferences whenever a destructive migration occurs.
  • It adds a DatabaseSchemeManager to manage and store this timestamp.
  • It modifies the VaultRepository to consider this timestamp when determining if a sync is necessary.
  • It updates the PasswordHistoryDatabase and PlatformDatabase to utilize the new DatabaseSchemeCallback.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed
    issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/4124 **Author:** [@SaintPatrck](https://github.com/SaintPatrck) **Created:** 10/21/2024 **Status:** ✅ Merged **Merged:** 10/24/2024 **Merged by:** [@SaintPatrck](https://github.com/SaintPatrck) **Base:** `main` ← **Head:** `PM-13900/collection-manage-property` --- ### 📝 Commits (9) - [`1e46681`](https://github.com/bitwarden/android/commit/1e466815f5330110418786176200b79f16add251) [PM-13900] Track last database scheme change - [`486b073`](https://github.com/bitwarden/android/commit/486b0735da181e1f86a994be00eb6b5b2eff086a) Merge branch 'main' into PM-13900/collection-manage-property - [`ce03fde`](https://github.com/bitwarden/android/commit/ce03fde7d1f1af5fc287962ea2704560d3e12866) Remove v4 scheme - [`7292b50`](https://github.com/bitwarden/android/commit/7292b509e4f6ee682b60b5190cb9e337a5008b42) [TEMP] Upload test reports on failure - [`d61e568`](https://github.com/bitwarden/android/commit/d61e5683b8070acc41417523fefc6559b0cea26c) Unmockk static fun - [`d7cfbfb`](https://github.com/bitwarden/android/commit/d7cfbfb7f174be2858d423c0429280808b7a2afb) Merge remote-tracking branch 'origin/main' into PM-13900/collection-manage-property - [`fd24c9e`](https://github.com/bitwarden/android/commit/fd24c9eaaf26f47c07b0e2f7a175ef6acf16b9ba) Don't mock the clock! Yeeaaaaa boiiiiii! - [`9ccd806`](https://github.com/bitwarden/android/commit/9ccd806b15b7903bbcb91f08d8e4c5f5ec9da37a) Merge remote-tracking branch 'origin/main' into PM-13900/collection-manage-property - [`8869a41`](https://github.com/bitwarden/android/commit/8869a41b860688a12a782f4a0ff148fc31d04b47) Add docs ### 📊 Changes **16 files changed** (+320 additions, -7 deletions) <details> <summary>View changed files</summary> 📝 `app/src/main/java/com/x8bit/bitwarden/data/platform/datasource/disk/SettingsDiskSource.kt` (+6 -0) 📝 `app/src/main/java/com/x8bit/bitwarden/data/platform/datasource/disk/SettingsDiskSourceImpl.kt` (+5 -0) 📝 `app/src/main/java/com/x8bit/bitwarden/data/platform/datasource/disk/di/PlatformDiskModule.kt` (+14 -1) ➕ `app/src/main/java/com/x8bit/bitwarden/data/platform/manager/DatabaseSchemeManager.kt` (+17 -0) ➕ `app/src/main/java/com/x8bit/bitwarden/data/platform/manager/DatabaseSchemeManagerImpl.kt` (+17 -0) 📝 `app/src/main/java/com/x8bit/bitwarden/data/platform/manager/di/PlatformManagerModule.kt` (+10 -0) 📝 `app/src/main/java/com/x8bit/bitwarden/data/tools/generator/datasource/disk/di/GeneratorDiskModule.kt` (+14 -1) ➕ `app/src/main/java/com/x8bit/bitwarden/data/vault/datasource/disk/callback/DatabaseSchemeCallback.kt` (+18 -0) 📝 `app/src/main/java/com/x8bit/bitwarden/data/vault/datasource/disk/di/VaultDiskModule.kt` (+9 -1) 📝 `app/src/main/java/com/x8bit/bitwarden/data/vault/repository/VaultRepositoryImpl.kt` (+17 -4) 📝 `app/src/main/java/com/x8bit/bitwarden/data/vault/repository/di/VaultRepositoryModule.kt` (+3 -0) 📝 `app/src/test/java/com/x8bit/bitwarden/data/platform/datasource/disk/SettingsDiskSourceTest.kt` (+49 -0) 📝 `app/src/test/java/com/x8bit/bitwarden/data/platform/datasource/disk/util/FakeSettingsDiskSource.kt` (+5 -0) ➕ `app/src/test/java/com/x8bit/bitwarden/data/platform/manager/DatabaseSchemeManagerTest.kt` (+45 -0) ➕ `app/src/test/java/com/x8bit/bitwarden/data/vault/datasource/disk/callback/DatabaseSchemeCallbackTest.kt` (+32 -0) 📝 `app/src/test/java/com/x8bit/bitwarden/data/vault/repository/VaultRepositoryTest.kt` (+59 -0) </details> ### 📄 Description ## 🎟️ Tracking https://bitwarden.atlassian.net/browse/PM-13900 ## 📔 Objective This change introduces a mechanism to track the last time a database scheme change was applied. - It adds a `DatabaseSchemeCallback` to update a timestamp in shared preferences whenever a destructive migration occurs. - It adds a `DatabaseSchemeManager` to manage and store this timestamp. - It modifies the `VaultRepository` to consider this timestamp when determining if a sync is necessary. - It updates the `PasswordHistoryDatabase` and `PlatformDatabase` to utilize the new `DatabaseSchemeCallback`. ## ⏰ Reminders before review - Contributor guidelines followed - All formatters and local linters executed and passed - Written new unit and / or integration tests where applicable - Used internationalization (i18n) for all UI strings - CI builds passed - Communicated to DevOps any deployment requirements - Updated any necessary documentation or informed the documentation team ## 🦮 Reviewer guidelines <!-- Suggested interactions but feel free to use (or not) as you desire! --> - 👍 (`:+1:`) or similar for great changes - 📝 (`:memo:`) or ℹ️ (`:information_source:`) for notes or general info - ❓ (`:question:`) for questions - 🤔 (`:thinking:`) or 💭 (`:thought_balloon:`) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion - 🎨 (`:art:`) for suggestions / improvements - ❌ (`:x:`) or ⚠️ (`:warning:`) for more significant problems or concerns needing attention - 🌱 (`:seedling:`) or ♻️ (`:recycle:`) for future improvements or indications of technical debt - ⛏ (`:pick:`) for minor or nitpick changes --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-26 23:48:37 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#4703
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?