github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-03-13 13:44:36 -05:00
Code Issues 144 Packages Projects Releases 116 Wiki Activity

[PR #3265] [PM-950] Cannot save new login if personal ownership is disabled #4124

New Issue
Closed
opened 2025-11-26 23:40:48 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-26 23:40:48 -06:00
Owner
Copy Link

Original Pull Request: https://github.com/bitwarden/android/pull/3265

State: closed
Merged: No

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

Fixes https://github.com/bitwarden/mobile/issues/1874

Add the ability to select a collection for the new item if personal ownership is disabled.

Code changes

  • LoginAddViewController.cs: Refactor how the number of rows and sections are calculated based on the value of the flag _personalOwnershipPolicyApplies. Added cells to warn the user the personal ownership is disabled and allow organisation and collection selection.
  • FormEntryTableViewCell.cs: Allow a form entry empty.

Screenshots

BEFORE
image

AFTER
image
image

Before you submit

  • Please check for formatting errors (dotnet format --verify-no-changes) (required)
  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team
**Original Pull Request:** https://github.com/bitwarden/android/pull/3265 **State:** closed **Merged:** No --- ## Type of change - [X] Bug fix - [ ] New feature development - [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc) - [ ] Build/deploy pipeline (DevOps) - [ ] Other ## Objective <!--Describe what the purpose of this PR is. For example: what bug you're fixing or what new feature you're adding--> Fixes https://github.com/bitwarden/mobile/issues/1874 Add the ability to select a collection for the new item if personal ownership is disabled. ## Code changes <!--Explain the changes you've made to each file or major component. This should help the reviewer understand your changes--> <!--Also refer to any related changes or PRs in other repositories--> * **LoginAddViewController.cs:** Refactor how the number of rows and sections are calculated based on the value of the flag `_personalOwnershipPolicyApplies`. Added cells to warn the user the personal ownership is disabled and allow organisation and collection selection. * **FormEntryTableViewCell.cs:** Allow a form entry empty. ## Screenshots <!--Required for any UI changes. Delete if not applicable--> **BEFORE** <img width="322" alt="image" src="https://github.com/bitwarden/mobile/assets/6855596/1e59f8d3-5a62-4d67-8b97-aa8a7368f913"> **AFTER** <img width="322" alt="image" src="https://github.com/bitwarden/mobile/assets/6855596/1b0b16f0-9ad7-435a-8b3a-f00bfcd3d584"> <img width="322" alt="image" src="https://github.com/bitwarden/mobile/assets/6855596/952763e8-527b-45ff-823f-6f7ac6f902e8"> ## Before you submit - Please check for formatting errors (`dotnet format --verify-no-changes`) (required) - Please add **unit tests** where it makes sense to do so (encouraged but not required) - If this change requires a **documentation update** - notify the documentation team - If this change has particular **deployment requirements** - notify the DevOps team
GiteaMirror added the pull-request label 2025-11-26 23:40:48 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#4124
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?