github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-05-07 19:39:41 -05:00
Code Issues 1.1k Packages Projects Releases 122 Wiki Activity

[PR #3988] [MERGED] BITAU-99 Expose and protect AuthenticatorBridgeService #4587

New Issue
Closed
opened 2025-11-26 23:46:56 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-26 23:46:56 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/3988
Author: @ahaisting-livefront
Created: 9/27/2024
Status: ✅ Merged
Merged: 10/3/2024
Merged by: @ahaisting-livefront

Base: main ← Head: protect-bridge-service

📝 Commits (3)

  • dbafc0e BITAU-99 Expose and Protect AuthenticatorBridgeService
  • 7ca58e2 clarify google play signing key
  • 46e7558 another typo

📊 Changes

4 files changed (+39 additions, -0 deletions)

View changed files

➕ app/src/beta/res/values/manifest.xml (+9 -0)
➕ app/src/debug/res/values/manifest.xml (+5 -0)
📝 app/src/main/AndroidManifest.xml (+19 -0)
➕ app/src/release/res/values/manifest.xml (+6 -0)

📄 Description

Note

I tested these two cases:

[X] does this work for release <> release variant communication.

I tested this with two one-off builds:

By clicking on the build links, you can see the commit that was build to see what changes are required by the authenticator app.

[X] what happens under android version S?

  • The coroutines wrapper returns an error in this case because we cannot connect to the bridge service. I'm going to add code to the wrapper to handle this expicitly and return a OSVersionNotSupported as part of BITAU-69.

🎟️ Tracking

https://livefront.atlassian.net/browse/BITAU-99

📔 Objective

The goal of this PR is to expose access to authenticator bridge service behind a permission that is scoped so that only the bitwarden authenticator app may use the service.

📸 Screenshots

N/A

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed
    issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/3988 **Author:** [@ahaisting-livefront](https://github.com/ahaisting-livefront) **Created:** 9/27/2024 **Status:** ✅ Merged **Merged:** 10/3/2024 **Merged by:** [@ahaisting-livefront](https://github.com/ahaisting-livefront) **Base:** `main` ← **Head:** `protect-bridge-service` --- ### 📝 Commits (3) - [`dbafc0e`](https://github.com/bitwarden/android/commit/dbafc0eaff4d4fce3fca391dda256cc9050bf3ae) BITAU-99 Expose and Protect AuthenticatorBridgeService - [`7ca58e2`](https://github.com/bitwarden/android/commit/7ca58e2097f2251a605a38488b698d9ee34833f1) clarify google play signing key - [`46e7558`](https://github.com/bitwarden/android/commit/46e75585e68aba9ed633f25e16aae9503ccbde58) another typo ### 📊 Changes **4 files changed** (+39 additions, -0 deletions) <details> <summary>View changed files</summary> ➕ `app/src/beta/res/values/manifest.xml` (+9 -0) ➕ `app/src/debug/res/values/manifest.xml` (+5 -0) 📝 `app/src/main/AndroidManifest.xml` (+19 -0) ➕ `app/src/release/res/values/manifest.xml` (+6 -0) </details> ### 📄 Description > [!NOTE] > I tested these two cases: [X] does this work for release <> release variant communication. I tested this with two one-off builds: - [Main App Build](https://github.com/bitwarden/android/actions/runs/11151653148) - [Authenticator App Build](https://github.com/bitwarden/authenticator-android/actions/runs/11148769402) By clicking on the build links, you can see the commit that was build to see what changes are required by the authenticator app. [X] what happens under android version S? - The coroutines wrapper returns an error in this case because we cannot connect to the bridge service. I'm going to add code to the wrapper to handle this expicitly and return a `OSVersionNotSupported` as part of BITAU-69. ## 🎟️ Tracking https://livefront.atlassian.net/browse/BITAU-99 ## 📔 Objective The goal of this PR is to expose access to authenticator bridge service behind a permission that is scoped so that only the bitwarden authenticator app may use the service. ## 📸 Screenshots N/A ## ⏰ Reminders before review - Contributor guidelines followed - All formatters and local linters executed and passed - Written new unit and / or integration tests where applicable - Used internationalization (i18n) for all UI strings - CI builds passed - Communicated to DevOps any deployment requirements - Updated any necessary documentation or informed the documentation team ## 🦮 Reviewer guidelines <!-- Suggested interactions but feel free to use (or not) as you desire! --> - 👍 (`:+1:`) or similar for great changes - 📝 (`:memo:`) or ℹ️ (`:information_source:`) for notes or general info - ❓ (`:question:`) for questions - 🤔 (`:thinking:`) or 💭 (`:thought_balloon:`) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion - 🎨 (`:art:`) for suggestions / improvements - ❌ (`:x:`) or ⚠️ (`:warning:`) for more significant problems or concerns needing attention - 🌱 (`:seedling:`) or ♻️ (`:recycle:`) for future improvements or indications of technical debt - ⛏ (`:pick:`) for minor or nitpick changes --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-26 23:46:56 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#4587
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?