github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-06-16 13:26:35 -05:00
Code Issues 2.4k Packages Projects Releases 129 Wiki Activity

[PR #3103] [MERGED] [PM-6706] Fix 5 attempts on passkeys User verification #45628

New Issue
Closed
opened 2026-04-26 12:55:29 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-26 12:55:29 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/3103
Author: @fedemkr
Created: 3/21/2024
Status: ✅ Merged
Merged: 3/21/2024
Merged by: @fedemkr

Base: feature/maui-migration-passkeys ← Head: vault/pm-6706/fix-5-attempts-on-uv

📝 Commits (1)

  • 5f874f8 PM-6706 Fixed UV attempts to be maximum 5 attempts and not 6

📊 Changes

1 file changed (+1 additions, -1 deletions)

View changed files

📝 src/Core/Services/UserVerification/UserVerificationMediatorService.cs (+1 -1)

📄 Description

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

Fix attempts on passkeys User verification to be 5 instead of 6

Code changes

  • UserVerificationMediatorService: Changed how the addition is done so the attempts are maximum 5 instead of 6.

Before you submit

  • Please check for formatting errors (dotnet format --verify-no-changes) (required)
  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/3103 **Author:** [@fedemkr](https://github.com/fedemkr) **Created:** 3/21/2024 **Status:** ✅ Merged **Merged:** 3/21/2024 **Merged by:** [@fedemkr](https://github.com/fedemkr) **Base:** `feature/maui-migration-passkeys` ← **Head:** `vault/pm-6706/fix-5-attempts-on-uv` --- ### 📝 Commits (1) - [`5f874f8`](https://github.com/bitwarden/android/commit/5f874f8926329538217574c3e3791a0e8e929d5b) PM-6706 Fixed UV attempts to be maximum 5 attempts and not 6 ### 📊 Changes **1 file changed** (+1 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `src/Core/Services/UserVerification/UserVerificationMediatorService.cs` (+1 -1) </details> ### 📄 Description ## Type of change - [X] Bug fix - [ ] New feature development - [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc) - [ ] Build/deploy pipeline (DevOps) - [ ] Other ## Objective <!--Describe what the purpose of this PR is. For example: what bug you're fixing or what new feature you're adding--> Fix attempts on passkeys User verification to be 5 instead of 6 ## Code changes <!--Explain the changes you've made to each file or major component. This should help the reviewer understand your changes--> <!--Also refer to any related changes or PRs in other repositories--> * **UserVerificationMediatorService:** Changed how the addition is done so the attempts are maximum 5 instead of 6. ## Before you submit - Please check for formatting errors (`dotnet format --verify-no-changes`) (required) - Please add **unit tests** where it makes sense to do so (encouraged but not required) - If this change requires a **documentation update** - notify the documentation team - If this change has particular **deployment requirements** - notify the DevOps team --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-26 12:55:29 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#45628
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?