github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-03-11 20:54:58 -05:00
Code Issues 144 Packages Projects Releases 116 Wiki Activity

[PR #1759] [MERGED] Fix crash Autofocus on TOTP Scan #3103

New Issue
Closed
opened 2025-11-26 23:28:20 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-26 23:28:20 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/1759
Author: @fedemkr
Created: 2/9/2022
Status: ✅ Merged
Merged: 2/9/2022
Merged by: @fedemkr

Base: master ← Head: fix-scan-autofocus-crash

📝 Commits (1)

  • 4c59e3a Improved Autofocus code on ScanPage for better cancellation and exception handling #1228

📊 Changes

1 file changed (+37 additions, -9 deletions)

View changed files

📝 src/App/Pages/Vault/ScanPage.xaml.cs (+37 -9)

📄 Description

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

Fix the crash on TOTP Scan Autofocus and improve the code for better cancellation and exception handling.

Code changes

  • ScanPage.xaml.cs: Improved the code for better cancellation and exception handling.

Testing requirements

I'm not sure how to reproduce the issue because it seems to be a race condition, but the Scan view shouldn't crash when scanning the QR. Also the Scan should keep working as before.

Before you submit

  • I have added unit tests where it makes sense to do so (encouraged but not required)
  • This change requires a documentation update (notify the documentation team)
  • This change has particular deployment requirements (notify the DevOps team)

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/1759 **Author:** [@fedemkr](https://github.com/fedemkr) **Created:** 2/9/2022 **Status:** ✅ Merged **Merged:** 2/9/2022 **Merged by:** [@fedemkr](https://github.com/fedemkr) **Base:** `master` ← **Head:** `fix-scan-autofocus-crash` --- ### 📝 Commits (1) - [`4c59e3a`](https://github.com/bitwarden/android/commit/4c59e3a8274fd89ea9584d047cf290dd893ccbc8) Improved Autofocus code on ScanPage for better cancellation and exception handling #1228 ### 📊 Changes **1 file changed** (+37 additions, -9 deletions) <details> <summary>View changed files</summary> 📝 `src/App/Pages/Vault/ScanPage.xaml.cs` (+37 -9) </details> ### 📄 Description ## Type of change - [X] Bug fix - [ ] New feature development - [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc) - [ ] Build/deploy pipeline (DevOps) - [ ] Other ## Objective <!--Describe what the purpose of this PR is. For example: what bug you're fixing or what new feature you're adding--> Fix the crash on TOTP Scan Autofocus and improve the code for better cancellation and exception handling. ## Code changes <!--Explain the changes you've made to each file or major component. This should help the reviewer understand your changes--> <!--Also refer to any related changes or PRs in other repositories--> * **ScanPage.xaml.cs:** Improved the code for better cancellation and exception handling. ## Testing requirements <!--What functionality requires testing by QA? This includes testing new behavior and regression testing--> I'm not sure how to reproduce the issue because it seems to be a race condition, but the Scan view shouldn't crash when scanning the QR. Also the Scan should keep working as before. ## Before you submit - [ ] I have added **unit tests** where it makes sense to do so (encouraged but not required) - [ ] This change requires a **documentation update** (notify the documentation team) - [ ] This change has particular **deployment requirements** (notify the DevOps team) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-26 23:28:20 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#3103
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?