github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-03-22 06:11:38 -05:00
Code Issues 144 Packages Projects Releases 116 Wiki Activity

[PR #3959] [MERGED] BITAU-172 Rename Authenticator Bridge SDK #4560

New Issue
Closed
opened 2025-11-26 23:46:31 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-26 23:46:31 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/3959
Author: @ahaisting-livefront
Created: 9/24/2024
Status: ✅ Merged
Merged: 9/24/2024
Merged by: @ahaisting-livefront

Base: main ← Head: rename-authenticator-bridge-sdk

📝 Commits (4)

  • ad59214 BITAU-172 Rename Authenticator Bridge SDK
  • ac94dd6 couple more tiny name tweaks
  • d7e2883 add @OmitFromCoverage to AuthenticatorBridgeService
  • 05e5806 remove fully qualified

📊 Changes

48 files changed (+212 additions, -207 deletions)

View changed files

📝 app/build.gradle.kts (+1 -1)
➕ app/libs/authenticatorbridge-0.1.0-SNAPSHOT-release.aar (+0 -0)
➖ app/libs/bridge-0.1.0-SNAPSHOT-release.aar (+0 -0)
📝 app/src/main/java/com/x8bit/bitwarden/data/platform/manager/di/PlatformManagerModule.kt (+7 -7)
➕ app/src/main/java/com/x8bit/bitwarden/data/platform/processor/AuthenticatorBridgeProcessor.kt (+16 -0)
📝 app/src/main/java/com/x8bit/bitwarden/data/platform/processor/AuthenticatorBridgeProcessorImpl.kt (+27 -23)
➖ app/src/main/java/com/x8bit/bitwarden/data/platform/processor/BridgeServiceProcessor.kt (+0 -14)
📝 app/src/main/java/com/x8bit/bitwarden/data/platform/repository/AuthenticatorBridgeRepository.kt (+4 -3)
📝 app/src/main/java/com/x8bit/bitwarden/data/platform/repository/AuthenticatorBridgeRepositoryImpl.kt (+4 -4)
📝 app/src/main/java/com/x8bit/bitwarden/data/platform/repository/SettingsRepositoryImpl.kt (+1 -1)
📝 app/src/main/java/com/x8bit/bitwarden/data/platform/repository/di/PlatformRepositoryModule.kt (+4 -4)
➕ app/src/main/java/com/x8bit/bitwarden/data/platform/service/AuthenticatorBridgeService.kt (+27 -0)
➖ app/src/main/java/com/x8bit/bitwarden/data/platform/service/BridgeService.kt (+0 -27)
📝 app/src/test/java/com/x8bit/bitwarden/data/auth/datasource/disk/AuthDiskSourceTest.kt (+1 -1)
📝 app/src/test/java/com/x8bit/bitwarden/data/platform/processor/AuthenticatorBridgeProcessorTest.kt (+33 -33)
📝 app/src/test/java/com/x8bit/bitwarden/data/platform/repository/AuthenticatorBridgeRepositoryTest.kt (+14 -14)
📝 app/src/test/java/com/x8bit/bitwarden/data/platform/repository/SettingsRepositoryTest.kt (+1 -1)
📝 authenticatorbridge/.gitignore (+0 -0)
📝 authenticatorbridge/CHANGELOG.md (+0 -0)
📝 authenticatorbridge/CHANGELOG_FORMAT.MD (+0 -0)

...and 28 more files

📄 Description

🎟️ Tracking

https://livefront.atlassian.net/browse/BITAU-172

📔 Objective

The goal of this PR is to rename the "Bridge SDK" to "Authenticator Bridge SDK"

📸 Screenshots

N/A

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed
    issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/3959 **Author:** [@ahaisting-livefront](https://github.com/ahaisting-livefront) **Created:** 9/24/2024 **Status:** ✅ Merged **Merged:** 9/24/2024 **Merged by:** [@ahaisting-livefront](https://github.com/ahaisting-livefront) **Base:** `main` ← **Head:** `rename-authenticator-bridge-sdk` --- ### 📝 Commits (4) - [`ad59214`](https://github.com/bitwarden/android/commit/ad5921454ce40023c7eaef942bd494348681b493) BITAU-172 Rename Authenticator Bridge SDK - [`ac94dd6`](https://github.com/bitwarden/android/commit/ac94dd66444ed301129854c9bb6c049537fb0e9a) couple more tiny name tweaks - [`d7e2883`](https://github.com/bitwarden/android/commit/d7e288366ff73d364a84a3a2bd32b7e3cc6c12d8) add @OmitFromCoverage to AuthenticatorBridgeService - [`05e5806`](https://github.com/bitwarden/android/commit/05e5806c019f3c93161698be88831c8cff9cf736) remove fully qualified ### 📊 Changes **48 files changed** (+212 additions, -207 deletions) <details> <summary>View changed files</summary> 📝 `app/build.gradle.kts` (+1 -1) ➕ `app/libs/authenticatorbridge-0.1.0-SNAPSHOT-release.aar` (+0 -0) ➖ `app/libs/bridge-0.1.0-SNAPSHOT-release.aar` (+0 -0) 📝 `app/src/main/java/com/x8bit/bitwarden/data/platform/manager/di/PlatformManagerModule.kt` (+7 -7) ➕ `app/src/main/java/com/x8bit/bitwarden/data/platform/processor/AuthenticatorBridgeProcessor.kt` (+16 -0) 📝 `app/src/main/java/com/x8bit/bitwarden/data/platform/processor/AuthenticatorBridgeProcessorImpl.kt` (+27 -23) ➖ `app/src/main/java/com/x8bit/bitwarden/data/platform/processor/BridgeServiceProcessor.kt` (+0 -14) 📝 `app/src/main/java/com/x8bit/bitwarden/data/platform/repository/AuthenticatorBridgeRepository.kt` (+4 -3) 📝 `app/src/main/java/com/x8bit/bitwarden/data/platform/repository/AuthenticatorBridgeRepositoryImpl.kt` (+4 -4) 📝 `app/src/main/java/com/x8bit/bitwarden/data/platform/repository/SettingsRepositoryImpl.kt` (+1 -1) 📝 `app/src/main/java/com/x8bit/bitwarden/data/platform/repository/di/PlatformRepositoryModule.kt` (+4 -4) ➕ `app/src/main/java/com/x8bit/bitwarden/data/platform/service/AuthenticatorBridgeService.kt` (+27 -0) ➖ `app/src/main/java/com/x8bit/bitwarden/data/platform/service/BridgeService.kt` (+0 -27) 📝 `app/src/test/java/com/x8bit/bitwarden/data/auth/datasource/disk/AuthDiskSourceTest.kt` (+1 -1) 📝 `app/src/test/java/com/x8bit/bitwarden/data/platform/processor/AuthenticatorBridgeProcessorTest.kt` (+33 -33) 📝 `app/src/test/java/com/x8bit/bitwarden/data/platform/repository/AuthenticatorBridgeRepositoryTest.kt` (+14 -14) 📝 `app/src/test/java/com/x8bit/bitwarden/data/platform/repository/SettingsRepositoryTest.kt` (+1 -1) 📝 `authenticatorbridge/.gitignore` (+0 -0) 📝 `authenticatorbridge/CHANGELOG.md` (+0 -0) 📝 `authenticatorbridge/CHANGELOG_FORMAT.MD` (+0 -0) _...and 28 more files_ </details> ### 📄 Description ## 🎟️ Tracking https://livefront.atlassian.net/browse/BITAU-172 ## 📔 Objective The goal of this PR is to rename the "Bridge SDK" to "Authenticator Bridge SDK" ## 📸 Screenshots N/A ## ⏰ Reminders before review - Contributor guidelines followed - All formatters and local linters executed and passed - Written new unit and / or integration tests where applicable - Used internationalization (i18n) for all UI strings - CI builds passed - Communicated to DevOps any deployment requirements - Updated any necessary documentation or informed the documentation team ## 🦮 Reviewer guidelines <!-- Suggested interactions but feel free to use (or not) as you desire! --> - 👍 (`:+1:`) or similar for great changes - 📝 (`:memo:`) or ℹ️ (`:information_source:`) for notes or general info - ❓ (`:question:`) for questions - 🤔 (`:thinking:`) or 💭 (`:thought_balloon:`) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion - 🎨 (`:art:`) for suggestions / improvements - ❌ (`:x:`) or ⚠️ (`:warning:`) for more significant problems or concerns needing attention - 🌱 (`:seedling:`) or ♻️ (`:recycle:`) for future improvements or indications of technical debt - ⛏ (`:pick:`) for minor or nitpick changes --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-26 23:46:31 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#4560
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?