github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-05-08 04:16:40 -05:00
Code Issues 1.1k Packages Projects Releases 122 Wiki Activity

[PR #4560] [CLOSED] PM-16631 Adding coach mark container and state to allow for guided coach mark tours #35539

New Issue
Closed
opened 2026-04-21 02:55:21 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-21 02:55:21 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/4560
Author: @dseverns-livefront
Created: 1/14/2025
Status: ❌ Closed

Base: main ← Head: PM-16631-coachmark-new-login

📝 Commits (1)

  • 4b5f16d PM-16631 Adding coach mark container and state to allow for guided screen tours

📊 Changes

4 files changed (+1198 additions, -0 deletions)

View changed files

➕ app/src/main/java/com/x8bit/bitwarden/ui/platform/components/coachmark/CoachMarkContainer.kt (+246 -0)
➕ app/src/main/java/com/x8bit/bitwarden/ui/platform/components/coachmark/CoachMarkScope.kt (+125 -0)
➕ app/src/main/java/com/x8bit/bitwarden/ui/platform/components/coachmark/CoachMarkScopeInstance.kt (+362 -0)
➕ app/src/main/java/com/x8bit/bitwarden/ui/platform/components/coachmark/CoachMarkState.kt (+465 -0)

📄 Description

🎟️ Tracking

PM-16631 [PART 1]

📔 Objective

  • This lays the groundwork for the Coach Mark stories for users first time interactions on pages.
  • When content is wrapped inCoachMarkContainer can highlight certain components of the UI and show a tooltip.

📸 Screenshots

https://github.com/user-attachments/assets/8dfc0e71-eccb-4f29-9327-2bdd905311ae

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed
    issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/4560 **Author:** [@dseverns-livefront](https://github.com/dseverns-livefront) **Created:** 1/14/2025 **Status:** ❌ Closed **Base:** `main` ← **Head:** `PM-16631-coachmark-new-login` --- ### 📝 Commits (1) - [`4b5f16d`](https://github.com/bitwarden/android/commit/4b5f16d4073aa9382b0571c28ab9beef3ed3c3ca) PM-16631 Adding coach mark container and state to allow for guided screen tours ### 📊 Changes **4 files changed** (+1198 additions, -0 deletions) <details> <summary>View changed files</summary> ➕ `app/src/main/java/com/x8bit/bitwarden/ui/platform/components/coachmark/CoachMarkContainer.kt` (+246 -0) ➕ `app/src/main/java/com/x8bit/bitwarden/ui/platform/components/coachmark/CoachMarkScope.kt` (+125 -0) ➕ `app/src/main/java/com/x8bit/bitwarden/ui/platform/components/coachmark/CoachMarkScopeInstance.kt` (+362 -0) ➕ `app/src/main/java/com/x8bit/bitwarden/ui/platform/components/coachmark/CoachMarkState.kt` (+465 -0) </details> ### 📄 Description ## 🎟️ Tracking [PM-16631](https://bitwarden.atlassian.net/browse/PM-16631) [PART 1] <!-- Paste the link to the Jira or GitHub issue or otherwise describe / point to where this change is coming from. --> ## 📔 Objective - This lays the groundwork for the Coach Mark stories for users first time interactions on pages. - When content is wrapped in`CoachMarkContainer` can highlight certain components of the UI and show a tooltip. <!-- Describe what the purpose of this PR is, for example what bug you're fixing or new feature you're adding. --> ## 📸 Screenshots https://github.com/user-attachments/assets/8dfc0e71-eccb-4f29-9327-2bdd905311ae <!-- Required for any UI changes; delete if not applicable. Use fixed width images for better display. --> ## ⏰ Reminders before review - Contributor guidelines followed - All formatters and local linters executed and passed - Written new unit and / or integration tests where applicable - Used internationalization (i18n) for all UI strings - CI builds passed - Communicated to DevOps any deployment requirements - Updated any necessary documentation or informed the documentation team ## 🦮 Reviewer guidelines <!-- Suggested interactions but feel free to use (or not) as you desire! --> - 👍 (`:+1:`) or similar for great changes - 📝 (`:memo:`) or ℹ️ (`:information_source:`) for notes or general info - ❓ (`:question:`) for questions - 🤔 (`:thinking:`) or 💭 (`:thought_balloon:`) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion - 🎨 (`:art:`) for suggestions / improvements - ❌ (`:x:`) or ⚠️ (`:warning:`) for more significant problems or concerns needing attention - 🌱 (`:seedling:`) or ♻️ (`:recycle:`) for future improvements or indications of technical debt - ⛏ (`:pick:`) for minor or nitpick changes [PM-16631]: https://bitwarden.atlassian.net/browse/PM-16631?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-21 02:55:21 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#35539
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?