github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-05-08 04:16:40 -05:00
Code Issues 1.1k Packages Projects Releases 122 Wiki Activity

[PR #2900] [MERGED] Fix version bump workflow on call #45477

New Issue
Closed
opened 2026-04-26 12:47:11 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-26 12:47:11 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/2900
Author: @vgrassia
Created: 12/12/2023
Status: ✅ Merged
Merged: 12/12/2023
Merged by: @vgrassia

Base: master ← Head: fix-version-bump-workflow-call

📝 Commits (1)

  • 8503036 Fix version bump workflow on call

📊 Changes

1 file changed (+4 additions, -1 deletions)

View changed files

📝 .github/workflows/version-bump.yml (+4 -1)

📄 Description

Type of change

- [ ] Bug fix
- [ ] New feature development
- [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc)
- [X] Build/deploy pipeline (DevOps)
- [ ] Other

Objective

This PR updates the checkout step to always be master. This limits the use of the workflow to only bump the version on master, but we shouldn't be using it on any other branch anyways. This was needed because when the workflow was called from another repository it was checking out the wrong repository.

Code changes

  • .github/workflows/version-bump.yml: Force checkout step to use master and create PR for merging into master.

Before you submit

  • Please check for formatting errors (dotnet format --verify-no-changes) (required)
  • If making database changes - make sure you also update Entity Framework queries and/or migrations
  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/2900 **Author:** [@vgrassia](https://github.com/vgrassia) **Created:** 12/12/2023 **Status:** ✅ Merged **Merged:** 12/12/2023 **Merged by:** [@vgrassia](https://github.com/vgrassia) **Base:** `master` ← **Head:** `fix-version-bump-workflow-call` --- ### 📝 Commits (1) - [`8503036`](https://github.com/bitwarden/android/commit/850303643d7d221ffe1de649ab266bfd12d8e060) Fix version bump workflow on call ### 📊 Changes **1 file changed** (+4 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `.github/workflows/version-bump.yml` (+4 -1) </details> ### 📄 Description ## Type of change <!-- (mark with an `X`) --> ``` - [ ] Bug fix - [ ] New feature development - [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc) - [X] Build/deploy pipeline (DevOps) - [ ] Other ``` ## Objective <!--Describe what the purpose of this PR is. For example: what bug you're fixing or what new feature you're adding--> This PR updates the checkout step to always be `master`. This limits the use of the workflow to only bump the version on `master`, but we shouldn't be using it on any other branch anyways. This was needed because when the workflow was called from another repository it was checking out the wrong repository. ## Code changes <!--Explain the changes you've made to each file or major component. This should help the reviewer understand your changes--> <!--Also refer to any related changes or PRs in other repositories--> * **.github/workflows/version-bump.yml:** Force checkout step to use `master` and create PR for merging into `master`. ## Before you submit - Please check for formatting errors (`dotnet format --verify-no-changes`) (required) - If making database changes - make sure you also update Entity Framework queries and/or migrations - Please add **unit tests** where it makes sense to do so (encouraged but not required) - If this change requires a **documentation update** - notify the documentation team - If this change has particular **deployment requirements** - notify the DevOps team --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-26 12:47:11 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#45477
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?