github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-03-18 11:44:32 -05:00
Code Issues 144 Packages Projects Releases 116 Wiki Activity

[PR #1453] [MERGED] Fix for password unlock for autofill and share-to-send on Android #2900

New Issue
Closed
opened 2025-11-26 23:25:40 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-26 23:25:40 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/1453
Author: @mpbw2
Created: 7/9/2021
Status: ✅ Merged
Merged: 7/9/2021
Merged by: @mpbw2

Base: master ← Head: bugfix-pw-unlock

📝 Commits (1)

  • 54ede2d Fix for password unlock for autofill and share-to-send on Android

📊 Changes

5 files changed (+41 additions, -1 deletions)

View changed files

📝 src/Android/Autofill/AutofillService.cs (+1 -0)
📝 src/App/Pages/Send/SendAddEditPage.xaml.cs (+17 -0)
📝 src/App/Pages/Send/SendAddEditPageViewModel.cs (+9 -1)
📝 src/App/Pages/Vault/AddEditPage.xaml.cs (+7 -0)
📝 src/App/Pages/Vault/AutofillCiphersPage.xaml.cs (+7 -0)

📄 Description

Recent changes to the order of operations for vault timeout created a bug specific to activities that are launched by an intent other than the system app launcher and when the user isn't using biometrics (race condition between showing the lock screen and clearing data needed to unlock). This PR fixes that as well as a few other bugs discovered along the way.

  • AutofillService.cs: calls CheckVaultTimeoutAsync before checking the lock status to make sure the timeout is taken into account before providing creds to the autofill service
  • SendAddEditPage.xaml.cs and SendAddEditPageViewModel.cs: calls CheckVaultTimeoutAsync and checks lock status when appearing to prevent attempts to load anything before unlock can occur, and handle back button to close activity properly (recently done for AutofillCiphersPage.xaml.cs as well)
  • AddEditPage.xaml.cs: calls CheckVaultTimeoutAsync and checks lock status when appearing to prevent attempts to load anything before unlock can occur
  • AutofillCiphersPage.xaml.cs: calls CheckVaultTimeoutAsync and checks lock status when appearing to prevent attempts to load anything before unlock can occur

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/1453 **Author:** [@mpbw2](https://github.com/mpbw2) **Created:** 7/9/2021 **Status:** ✅ Merged **Merged:** 7/9/2021 **Merged by:** [@mpbw2](https://github.com/mpbw2) **Base:** `master` ← **Head:** `bugfix-pw-unlock` --- ### 📝 Commits (1) - [`54ede2d`](https://github.com/bitwarden/android/commit/54ede2d72e02fe8f2aa1269af9767406fa869b3c) Fix for password unlock for autofill and share-to-send on Android ### 📊 Changes **5 files changed** (+41 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `src/Android/Autofill/AutofillService.cs` (+1 -0) 📝 `src/App/Pages/Send/SendAddEditPage.xaml.cs` (+17 -0) 📝 `src/App/Pages/Send/SendAddEditPageViewModel.cs` (+9 -1) 📝 `src/App/Pages/Vault/AddEditPage.xaml.cs` (+7 -0) 📝 `src/App/Pages/Vault/AutofillCiphersPage.xaml.cs` (+7 -0) </details> ### 📄 Description Recent changes to the order of operations for vault timeout created a bug specific to activities that are launched by an intent other than the system app launcher and when the user isn't using biometrics (race condition between showing the lock screen and clearing data needed to unlock). This PR fixes that as well as a few other bugs discovered along the way. - **AutofillService.cs**: calls `CheckVaultTimeoutAsync` before checking the lock status to make sure the timeout is taken into account before providing creds to the autofill service - **SendAddEditPage.xaml.cs** and **SendAddEditPageViewModel.cs**: calls `CheckVaultTimeoutAsync` and checks lock status when appearing to prevent attempts to load anything before unlock can occur, and handle back button to close activity properly (recently done for **AutofillCiphersPage.xaml.cs** as well) - **AddEditPage.xaml.cs**: calls `CheckVaultTimeoutAsync` and checks lock status when appearing to prevent attempts to load anything before unlock can occur - **AutofillCiphersPage.xaml.cs**: calls `CheckVaultTimeoutAsync` and checks lock status when appearing to prevent attempts to load anything before unlock can occur --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-26 23:25:40 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#2900
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?