github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-08-25 17:09:55 -05:00
Code Issues 2.4k Packages Projects Releases 129 Wiki Activity

[PR #2879] [CLOSED] PM-4920: Add Username to Fido2Credential #45462

New Issue
Closed
opened 2026-04-26 12:46:22 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-26 12:46:22 -05:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/2879
Author: @abergs
Created: 11/23/2023
Status: ❌ Closed

Base: main ← Head: pm-4920-username

📝 Commits (1)

📊 Changes

1 file changed (+1 additions, -0 deletions)

View changed files

📝 src/Core/Models/Api/Fido2CredentialApi.cs (+1 -0)

📄 Description

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

We added a userName to the Fido2Credential models. This needs to be propagated to the mobile client so that editing a cipher with a passkey does not wipe out the value by passing NULL to the server.

There are no UI changes in this PR.

Before you submit

  • Please check for formatting errors (dotnet format --verify-no-changes) (required)
  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/2879 **Author:** [@abergs](https://github.com/abergs) **Created:** 11/23/2023 **Status:** ❌ Closed **Base:** `main` ← **Head:** `pm-4920-username` --- ### 📝 Commits (1) - [`5a345a6`](https://github.com/bitwarden/android/commit/5a345a60e78bf512679c9695300a2bbbaf0944d7) Small remark ### 📊 Changes **1 file changed** (+1 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `src/Core/Models/Api/Fido2CredentialApi.cs` (+1 -0) </details> ### 📄 Description ## Type of change - [X] Bug fix - [ ] New feature development - [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc) - [ ] Build/deploy pipeline (DevOps) - [ ] Other ## Objective We added a userName to the Fido2Credential models. This needs to be propagated to the mobile client so that editing a cipher with a passkey does not wipe out the value by passing NULL to the server. There are no UI changes in this PR. ## Before you submit - Please check for formatting errors (`dotnet format --verify-no-changes`) (required) - Please add **unit tests** where it makes sense to do so (encouraged but not required) - If this change requires a **documentation update** - notify the documentation team - If this change has particular **deployment requirements** - notify the DevOps team --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-26 12:46:22 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No labels pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
GiteaMirror ninjasurge (Kaehlen Rog)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#45462