github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-03-12 05:04:17 -05:00
Code Issues 144 Packages Projects Releases 116 Wiki Activity

[PR #1422] [MERGED] Use type to ensure transmitted data is encrypted #2879

New Issue
Closed
opened 2025-11-26 23:25:24 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-26 23:25:24 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/1422
Author: @MGibson1
Created: 6/9/2021
Status: ✅ Merged
Merged: 6/9/2021
Merged by: @MGibson1

Base: master ← Head: fix-cipher-attachment-upload-filename-type

📝 Commits (1)

  • 028c38b Use type to ensure transmitted data is encrypted

📊 Changes

4 files changed (+7 additions, -6 deletions)

View changed files

📝 src/Core/Abstractions/IFileUploadService.cs (+1 -1)
📝 src/Core/Services/CipherService.cs (+1 -1)
📝 src/Core/Services/FileUploadService.cs (+2 -2)
📝 test/Core.Test/Services/CipherServiceTests.cs (+3 -2)

📄 Description

Overview

See bitwarden/jslib#403. The issue wasn't present here, but the type change still is a good idea to protect against that kind of typo

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/1422 **Author:** [@MGibson1](https://github.com/MGibson1) **Created:** 6/9/2021 **Status:** ✅ Merged **Merged:** 6/9/2021 **Merged by:** [@MGibson1](https://github.com/MGibson1) **Base:** `master` ← **Head:** `fix-cipher-attachment-upload-filename-type` --- ### 📝 Commits (1) - [`028c38b`](https://github.com/bitwarden/android/commit/028c38bb92634defe274512200bfa304eac35f83) Use type to ensure transmitted data is encrypted ### 📊 Changes **4 files changed** (+7 additions, -6 deletions) <details> <summary>View changed files</summary> 📝 `src/Core/Abstractions/IFileUploadService.cs` (+1 -1) 📝 `src/Core/Services/CipherService.cs` (+1 -1) 📝 `src/Core/Services/FileUploadService.cs` (+2 -2) 📝 `test/Core.Test/Services/CipherServiceTests.cs` (+3 -2) </details> ### 📄 Description # Overview See bitwarden/jslib#403. The issue wasn't present here, but the type change still is a good idea to protect against that kind of typo --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-26 23:25:24 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#2879
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?